Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33495

Separate scrollspy widget code out from tab widget code

XMLWordPrintable

      The new scrollspy widget code was pasted in on top of the tab widget code. It should be separated out into a dedicated widget, leaving the tab widget as a tab widget.

          [JENKINS-33495] Separate scrollspy widget code out from tab widget code

          Tom FENNELLY added a comment -

          WiP PR at https://github.com/jenkinsci/jenkins/pull/2121

          Tom FENNELLY added a comment - WiP PR at https://github.com/jenkinsci/jenkins/pull/2121

          Kohsuke Kawaguchi added a comment -

          While Tom is away, Keith takes it over. There's one blocking issue he and Gus are working on.

          Kohsuke Kawaguchi added a comment - While Tom is away, Keith takes it over. There's one blocking issue he and Gus are working on.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Tom Fennelly
          Path:
          core/src/main/resources/hudson/model/Job/configure.jelly
          core/src/main/resources/lib/form/select/select.js
          core/src/main/resources/lib/layout/layout.jelly
          war/gulpfile.js
          war/src/main/js/config-scrollspy.js
          war/src/main/js/config-scrollspy.less
          war/src/main/js/config-tabbar.js
          war/src/main/js/config-tabbar.less
          war/src/main/js/util/behavior-shim.js
          war/src/main/js/util/localStorage.js
          war/src/main/js/util/page.js
          war/src/main/js/widgets/config/model/ConfigSection.js
          war/src/main/js/widgets/config/model/ConfigTableMetaData.js
          war/src/main/js/widgets/config/tabbar.js
          war/src/main/js/widgets/config/tabbar.less
          war/src/main/js/widgets/form/form-mixins.less
          war/src/main/js/widgets/jenkins-widgets.less
          war/src/main/js/widgets/layout-mixins.less
          war/src/main/webapp/css/style.css
          war/src/test/js/widgets/config/freestyle-config-scrollspy.html
          war/src/test/js/widgets/config/freestyle-config-tabbed.html
          war/src/test/js/widgets/config/freestyle-config.html
          war/src/test/js/widgets/config/mocks.js
          war/src/test/js/widgets/config/scrollspy-spec.js
          war/src/test/js/widgets/config/tabbar-spec.js
          http://jenkins-ci.org/commit/jenkins/904d9b170fbe135fb001fe049cf31eecefc42a6a
          Log:
          Merge pull request #2121 from tfennelly/JENKINS-33495

          [JENKINS-33495 and JENKINS-33496] Separate scrollspy widget code out from tab widget code

          Compare: https://github.com/jenkinsci/jenkins/compare/8c1f8cf64216...904d9b170fbe

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tom Fennelly Path: core/src/main/resources/hudson/model/Job/configure.jelly core/src/main/resources/lib/form/select/select.js core/src/main/resources/lib/layout/layout.jelly war/gulpfile.js war/src/main/js/config-scrollspy.js war/src/main/js/config-scrollspy.less war/src/main/js/config-tabbar.js war/src/main/js/config-tabbar.less war/src/main/js/util/behavior-shim.js war/src/main/js/util/localStorage.js war/src/main/js/util/page.js war/src/main/js/widgets/config/model/ConfigSection.js war/src/main/js/widgets/config/model/ConfigTableMetaData.js war/src/main/js/widgets/config/tabbar.js war/src/main/js/widgets/config/tabbar.less war/src/main/js/widgets/form/form-mixins.less war/src/main/js/widgets/jenkins-widgets.less war/src/main/js/widgets/layout-mixins.less war/src/main/webapp/css/style.css war/src/test/js/widgets/config/freestyle-config-scrollspy.html war/src/test/js/widgets/config/freestyle-config-tabbed.html war/src/test/js/widgets/config/freestyle-config.html war/src/test/js/widgets/config/mocks.js war/src/test/js/widgets/config/scrollspy-spec.js war/src/test/js/widgets/config/tabbar-spec.js http://jenkins-ci.org/commit/jenkins/904d9b170fbe135fb001fe049cf31eecefc42a6a Log: Merge pull request #2121 from tfennelly/ JENKINS-33495 [JENKINS-33495 and JENKINS-33496] Separate scrollspy widget code out from tab widget code Compare: https://github.com/jenkinsci/jenkins/compare/8c1f8cf64216...904d9b170fbe

            kzantow Keith Zantow
            tfennelly Tom FENNELLY
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: