[JENKINS-33578] Snippetizer broken for DownstreamBuildSelector with Jenkins Pipeline

Type: Bug
Resolution: Fixed
Priority: Minor
Component/s: copyartifact-plugin
Labels:
- pipeline

Similar Issues:
Powered by SuggestiMate

Show

Copy artifact is throwing a NPE when pointing at Jenkins Pipelines in the Jenkins Pipeline snippet generator when creating a copy artifact step using the DownstreamBuildSelector:

Caused by: java.lang.NullPointerException
	at hudson.plugins.copyartifact.DownstreamBuildSelector$DescriptorImpl.doCheckUpstreamProjectName(DownstreamBuildSelector.java:198)
	at sun.reflect.GeneratedMethodAccessor1349.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)

depends on

JENKINS-32526 NPE from CopyArtifact$DescriptorImpl.doCheckProjectName when using Copy artifact from Another Project in Promotion process of a template

Closed

is related to

JENKINS-33577 "Unable to find a build" when using DownstreamBuildSelector with Jenkins Pipelines

Closed

links to

fix suggestion

Jesse Glick added a comment - 2016-03-16 13:04

~~JENKINS-32526~~ would fix the error, without making the validation actually work.

Jesse Glick added a comment - 2016-03-16 13:04 JENKINS-32526 would fix the error, without making the validation actually work.

ikedam added a comment - 2016-04-03 05:32

~~JENKINS-32526~~ fixed the error, but it warns "Not Found" when you specified pipeline jobs for the upstream project.

I found that DownstreamBuildSelector cannot pick builds related to pipeline jobs, as it depends on AbstractBuild#getUpstreamRelationshipBuild to detect relationships, which can be applicable only to `AbstractProject`.

I'll add a change to display to warn that DownstreamBuildSelector is applicable only to AbstractProject for now.

ikedam added a comment - 2016-04-03 05:32 JENKINS-32526 fixed the error, but it warns "Not Found" when you specified pipeline jobs for the upstream project. I found that DownstreamBuildSelector cannot pick builds related to pipeline jobs, as it depends on AbstractBuild#getUpstreamRelationshipBuild to detect relationships, which can be applicable only to `AbstractProject`. I'll add a change to display to warn that DownstreamBuildSelector is applicable only to AbstractProject for now.

ikedam added a comment - 2016-04-03 07:16

https://github.com/jenkinsci/copyartifact-plugin/pull/84

ikedam added a comment - 2016-04-03 07:16 https://github.com/jenkinsci/copyartifact-plugin/pull/84

SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Code changed in jenkins
User: ikedam
Path:
src/main/java/hudson/plugins/copyartifact/DownstreamBuildSelector.java
src/main/resources/hudson/plugins/copyartifact/DownstreamBuildSelector/help-upstreamProjectName.html
src/main/resources/hudson/plugins/copyartifact/DownstreamBuildSelector/help-upstreamProjectName_ja.html
src/main/resources/hudson/plugins/copyartifact/Messages.properties
src/main/resources/hudson/plugins/copyartifact/Messages_ja.properties
src/test/java/hudson/plugins/copyartifact/DownstreamBuildSelectorTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/cafa6135bccb864c5aaadb8af3614d343498a15c
Log:
~~JENKINS-33578~~ Displays error or warning messages when applied DownstreamBuildSelector to Workflow jobs.

SCM/JIRA link daemon added a comment - 2016-04-17 00:21 Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/copyartifact/DownstreamBuildSelector.java src/main/resources/hudson/plugins/copyartifact/DownstreamBuildSelector/help-upstreamProjectName.html src/main/resources/hudson/plugins/copyartifact/DownstreamBuildSelector/help-upstreamProjectName_ja.html src/main/resources/hudson/plugins/copyartifact/Messages.properties src/main/resources/hudson/plugins/copyartifact/Messages_ja.properties src/test/java/hudson/plugins/copyartifact/DownstreamBuildSelectorTest.java http://jenkins-ci.org/commit/copyartifact-plugin/cafa6135bccb864c5aaadb8af3614d343498a15c Log: JENKINS-33578 Displays error or warning messages when applied DownstreamBuildSelector to Workflow jobs.

SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Code changed in jenkins
User: ikedam
Path:
src/test/java/hudson/plugins/copyartifact/DownstreamBuildSelectorTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/2e349bea6791d31799defad01649a09d902b1ac7
Log:
~~JENKINS-33578~~ Removed a test for doAutoCompleteUpstreamProjectName for DownstreamBuildSelector. Workflow projects continue to be listed as allow to complete folder names.

SCM/JIRA link daemon added a comment - 2016-04-17 00:21 Code changed in jenkins User: ikedam Path: src/test/java/hudson/plugins/copyartifact/DownstreamBuildSelectorTest.java http://jenkins-ci.org/commit/copyartifact-plugin/2e349bea6791d31799defad01649a09d902b1ac7 Log: JENKINS-33578 Removed a test for doAutoCompleteUpstreamProjectName for DownstreamBuildSelector. Workflow projects continue to be listed as allow to complete folder names.

SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Code changed in jenkins
User: ikedam
Path:
src/main/java/hudson/plugins/copyartifact/DownstreamBuildSelector.java
src/test/java/hudson/plugins/copyartifact/DownstreamBuildSelectorTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/53af7b06084f5af8912a564d200951988ee635b6
Log:
~~JENKINS-33578~~ Improved the message when the upstream is non-AbstractProject for DownstreamBuildSelector.

SCM/JIRA link daemon added a comment - 2016-04-17 00:21 Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/copyartifact/DownstreamBuildSelector.java src/test/java/hudson/plugins/copyartifact/DownstreamBuildSelectorTest.java http://jenkins-ci.org/commit/copyartifact-plugin/53af7b06084f5af8912a564d200951988ee635b6 Log: JENKINS-33578 Improved the message when the upstream is non-AbstractProject for DownstreamBuildSelector.

SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Code changed in jenkins
User: ikedam
Path:
src/main/java/hudson/plugins/copyartifact/DownstreamBuildSelector.java
src/main/resources/hudson/plugins/copyartifact/DownstreamBuildSelector/help-upstreamProjectName.html
src/main/resources/hudson/plugins/copyartifact/DownstreamBuildSelector/help-upstreamProjectName_ja.html
src/main/resources/hudson/plugins/copyartifact/Messages.properties
src/main/resources/hudson/plugins/copyartifact/Messages_ja.properties
src/test/java/hudson/plugins/copyartifact/DownstreamBuildSelectorTest.java
http://jenkins-ci.org/commit/copyartifact-plugin/12ec59c7e8992850d55b8d35613326d90a5b0bfd
Log:
Merge pull request #84 from ikedam/feature/~~JENKINS-33578~~_DownstreamBuildSelectorForWorkflow

~~JENKINS-33578~~ DownstreamBuildSelector is not applicable to Workflow jobs.

Compare: https://github.com/jenkinsci/copyartifact-plugin/compare/0e4974f90951...12ec59c7e899

SCM/JIRA link daemon added a comment - 2016-04-17 00:21 Code changed in jenkins User: ikedam Path: src/main/java/hudson/plugins/copyartifact/DownstreamBuildSelector.java src/main/resources/hudson/plugins/copyartifact/DownstreamBuildSelector/help-upstreamProjectName.html src/main/resources/hudson/plugins/copyartifact/DownstreamBuildSelector/help-upstreamProjectName_ja.html src/main/resources/hudson/plugins/copyartifact/Messages.properties src/main/resources/hudson/plugins/copyartifact/Messages_ja.properties src/test/java/hudson/plugins/copyartifact/DownstreamBuildSelectorTest.java http://jenkins-ci.org/commit/copyartifact-plugin/12ec59c7e8992850d55b8d35613326d90a5b0bfd Log: Merge pull request #84 from ikedam/feature/ JENKINS-33578 _DownstreamBuildSelectorForWorkflow JENKINS-33578 DownstreamBuildSelector is not applicable to Workflow jobs. Compare: https://github.com/jenkinsci/copyartifact-plugin/compare/0e4974f90951...12ec59c7e899

ikedam added a comment - 2016-04-17 01:21

Released 1.38 containing this fix.
It will be available in the update center in a day.

ikedam added a comment - 2016-04-17 01:21 Released 1.38 containing this fix. It will be available in the update center in a day.

Assignee:: ikedam

Reporter:: Andy Pemberton

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 2016-03-16 08:21

Updated:: 2016-08-29 17:26

Resolved:: 2016-04-17 01:20

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Jesse Glick added a comment - 2016-03-16 13:04

Expand comment: Jesse Glick added a comment - 2016-03-16 13:04

Collapse comment: ikedam added a comment - 2016-04-03 05:32

Expand comment: ikedam added a comment - 2016-04-03 05:32

Collapse comment: ikedam added a comment - 2016-04-03 07:16

Expand comment: ikedam added a comment - 2016-04-03 07:16

Collapse comment: SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Expand comment: SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Collapse comment: SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Expand comment: SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Collapse comment: SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Expand comment: SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Collapse comment: SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Expand comment: SCM/JIRA link daemon added a comment - 2016-04-17 00:21

Collapse comment: ikedam added a comment - 2016-04-17 01:21

Expand comment: ikedam added a comment - 2016-04-17 01:21

People

Dates