• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      During the setup wizard, Jenkins asks if I want to create an admin user or skip it. When I choose skip, it'll still create an admin user anyway.

      This is unintuitive. The expectation with the 'Skip' label is that I'm NOT creating an admin user. There are legitimate reasons to do this - for example if I'm setting up Jenkins with a real security realm like LDAP, I really do not want the admin user.

      The problem is further made worse by the fact that this default admin user has the security token as the password, which you can never recover if you haven't written it down.

      I think we are going too far here. We make it very obvious and natural for people to create an admin user, and 'Skip' is very under-emphasized already. This should be sufficient. It shouldn't get in the way of people who know what they are doing, just like we let people not install any recommended plugins.

      If we insist on forcing people to create an admin user just to install LDAP plugin & throw that user away, then I'd rather not have the "Skip" button. As a reference, Atlassian tools for example doesn't let you skip creating admin user. You always have to create one.

          [JENKINS-33601] Setup wizard: 'skip' is not actually skip

          Daniel Beck added a comment -

          Yeah integrating the security config into the initial wizard would be an improvement for everyone integrating with another system. FWIW you can just use the same name you use there for admin user creation, then there's no additional user record – just an extra, unused password record for that user.

          However, we will not make not having an admin user the default, or make it exceptionally easy (e.g. giant button rather than e.g. having to uncheck "Enable security") to opt out. Not during my term as security officer.

          Daniel Beck added a comment - Yeah integrating the security config into the initial wizard would be an improvement for everyone integrating with another system. FWIW you can just use the same name you use there for admin user creation, then there's no additional user record – just an extra, unused password record for that user. However, we will not make not having an admin user the default, or make it exceptionally easy (e.g. giant button rather than e.g. having to uncheck "Enable security") to opt out. Not during my term as security officer.

          Daniel Beck added a comment -

          When I press skip now, I end up at an error page in 2.0 beta:

          drulli Could you please provide detailed instructions how to reproduce this problem? When I click 'Skip' on admin user creation, the final screen shows. Is there maybe something logged in the browser console, or Jenkins log?

          Daniel Beck added a comment - When I press skip now, I end up at an error page in 2.0 beta: drulli Could you please provide detailed instructions how to reproduce this problem? When I click 'Skip' on admin user creation, the final screen shows. Is there maybe something logged in the browser console, or Jenkins log?

          Keith Zantow added a comment - - edited

          I think we should get rid of the skip option altogether, rather than leaving Jenkins unsecured, since the whole point of these changes was to make Jenkins secure. If we want to integrate the security config in again, that's trivial to do, just let me know what the decision is to proceed, please. kohsuke danielbeck

          Keith Zantow added a comment - - edited I think we should get rid of the skip option altogether, rather than leaving Jenkins unsecured, since the whole point of these changes was to make Jenkins secure. If we want to integrate the security config in again, that's trivial to do, just let me know what the decision is to proceed, please. kohsuke danielbeck

          Daniel Beck added a comment -

          kzantow Assuming it actually is trivial to do, it would be great if we could get a PR with security config to try how it works with security setup integrated here.

          Ideally it would be prefaced with a selection dialog like the very first "default plugins"/"customize plugins" that says "default security setup"/"customize security". If selecting the former, or choosing "Jenkins realm" in the latter, the register admin dialog should come up.

          I feel like I suggested this already somewhere, but don't remember where.

          FTR The idea is to make security opt out, rather than forcing it on people. It currently is opt-in, and that's very, very bad.

          Daniel Beck added a comment - kzantow Assuming it actually is trivial to do, it would be great if we could get a PR with security config to try how it works with security setup integrated here. Ideally it would be prefaced with a selection dialog like the very first "default plugins"/"customize plugins" that says "default security setup"/"customize security". If selecting the former, or choosing "Jenkins realm" in the latter, the register admin dialog should come up. I feel like I suggested this already somewhere, but don't remember where. FTR The idea is to make security opt out, rather than forcing it on people. It currently is opt-in, and that's very, very bad .

          Daniel Beck added a comment -

          drulli Could you please file the bug with the error message in a new issue once you can get it reproducible? This issue is actually about something different, just in the same top-level feature.

          Daniel Beck added a comment - drulli Could you please file the bug with the error message in a new issue once you can get it reproducible? This issue is actually about something different, just in the same top-level feature.

          Ulli Hafner added a comment - - edited

          I got the error message after pressing the start button.

          I don't get the error message again, though... Maybe something unrelated.

          Ulli Hafner added a comment - - edited I got the error message after pressing the start button. I don't get the error message again, though... Maybe something unrelated.

          Ulli Hafner added a comment -

          Then it would be good to add some more inline help texts to describe that from now on Jenkins requires at least one user. (And that this user may be a normal user that gets admin rights). BTW: Why not call it create user rather than admin user if this user could be a normal user...?

          If we enforce at least one user in Jenkins then the skip button should be removed. (And in the user administration we should ensure that at least one admin user is defined).

          Ulli Hafner added a comment - Then it would be good to add some more inline help texts to describe that from now on Jenkins requires at least one user. (And that this user may be a normal user that gets admin rights). BTW: Why not call it create user rather than admin user if this user could be a normal user...? If we enforce at least one user in Jenkins then the skip button should be removed. (And in the user administration we should ensure that at least one admin user is defined).

          Keith Zantow added a comment -

          danielbeck https://github.com/jenkinsci/jenkins/pull/2187 has the security setup integrated again, it skips user creation if you don't pick the HudsonPrivateSecurityRealm (e.g. opt for no security).

          Keith Zantow added a comment - danielbeck https://github.com/jenkinsci/jenkins/pull/2187 has the security setup integrated again, it skips user creation if you don't pick the HudsonPrivateSecurityRealm (e.g. opt for no security).

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/jenkins/install/pluginSetupWizard.properties
          http://jenkins-ci.org/commit/jenkins/f2ba3b9642a1465652327fea52aa4598389b9c5a
          Log:
          Merge pull request #2213 from kzantow/JENKINS-33601-rename-skip

          [FIXED ENKINS-33601] Change 'Skip' text in setup wizard

          Compare: https://github.com/jenkinsci/jenkins/compare/dc94c2dcd2ee...f2ba3b9642a1

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/jenkins/install/pluginSetupWizard.properties http://jenkins-ci.org/commit/jenkins/f2ba3b9642a1465652327fea52aa4598389b9c5a Log: Merge pull request #2213 from kzantow/ JENKINS-33601 -rename-skip [FIXED ENKINS-33601] Change 'Skip' text in setup wizard Compare: https://github.com/jenkinsci/jenkins/compare/dc94c2dcd2ee...f2ba3b9642a1

          Daniel Beck added a comment -

          ENKINS

          Daniel Beck added a comment - ENKINS

            kzantow Keith Zantow
            kohsuke Kohsuke Kawaguchi
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: