Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33705

Security token not printed with proper line endings on Windows

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      While testing on Windows, I noticed that the security token is hiding in my logs! (see the attached screenshot).

      I have a feeling that this is because the security token is being logged with Unix-specific line endings \n instead of Windows ones \r\n.

      Ideally we should be using our logging framework or some cross-platform abstraction to make this a bit easier

      If you can't find the security token in the screenshot, it's only one line starting with "*****"

          [JENKINS-33705] Security token not printed with proper line endings on Windows

          Daniel Beck added a comment -

          Daniel Beck added a comment - http://docs.oracle.com/javase/8/docs/api/java/lang/System.html#lineSeparator--

          Daniel Beck added a comment -

          Daniel Beck added a comment - PR at https://github.com/jenkinsci/jenkins/pull/2150

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/jenkins/install/SetupWizard.java
          http://jenkins-ci.org/commit/jenkins/012a92e7de75d10a90afa580badb843a7c5efb0d
          Log:
          [FIX JENKINS-33705] Use platform line endings

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/install/SetupWizard.java http://jenkins-ci.org/commit/jenkins/012a92e7de75d10a90afa580badb843a7c5efb0d Log: [FIX JENKINS-33705] Use platform line endings

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/jenkins/install/SetupWizard.java
          http://jenkins-ci.org/commit/jenkins/3fdd8666b762cc36d3ccca35c3848f911d619d27
          Log:
          Merge pull request #2150 from daniel-beck/JENKINS-33705

          [FIX JENKINS-33705] Use platform line endings

          Compare: https://github.com/jenkinsci/jenkins/compare/82d3eb8644ad...3fdd8666b762

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/install/SetupWizard.java http://jenkins-ci.org/commit/jenkins/3fdd8666b762cc36d3ccca35c3848f911d619d27 Log: Merge pull request #2150 from daniel-beck/ JENKINS-33705 [FIX JENKINS-33705] Use platform line endings Compare: https://github.com/jenkinsci/jenkins/compare/82d3eb8644ad...3fdd8666b762

            danielbeck Daniel Beck
            rtyler R. Tyler Croy
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: