Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33813

2.0 Setup wizard: No valid crumb was included in the request

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • #1873c6f aka jenkins-2.0-beta-1

      I was following the installation wizard, but I waited a long long time after the installation of plugins to fill the admin creation form and it failed.

      Several feedbacks

      • There is a CSS issue with the error box which is too large (we can scroll horizontally within the wizard panel)
      • There no action excepted to close the wizard window...

      On server side I have :

      Mar 25, 2016 11:22:30 AM hudson.security.csrf.CrumbFilter doFilter
      WARNING: Found invalid crumb 0ed082c24c273051e46287ad26df37ca.  Will check remaining parameters for a valid one...
      Mar 25, 2016 11:22:30 AM hudson.security.csrf.CrumbFilter doFilter
      WARNING: No valid crumb was included in request for /securityRealm/createFirstAccount. Returning 403.
      

          [JENKINS-33813] 2.0 Setup wizard: No valid crumb was included in the request

          AH AH AH. Nothing happens if I click on the close button ...
          perhaps because of the 403 error

          Arnaud Héritier added a comment - AH AH AH. Nothing happens if I click on the close button ... perhaps because of the 403 error

          Daniel Beck added a comment -

          My best guess is that the integrated account creation and login somehow messes with the crumbs, as the account is part of that.

          Daniel Beck added a comment - My best guess is that the integrated account creation and login somehow messes with the crumbs, as the account is part of that.

          Keith Zantow added a comment - - edited

          This is expected, you let the session time out. I would not necessarily consider this critical. Refreshing the page would fix the issue.

          However, we need a better way to restart the wizard/login in this case. I'll fix the CSS issue on this page, add text to indicate the user can retry, and add a link back to the root, which will direct them back through security token, setup wizard, etc.. Unless something bad happens like Jenkins has crashed, in which case they're sorta out of luck.

          Do you agree with this danielbeck ?

          Keith Zantow added a comment - - edited This is expected, you let the session time out. I would not necessarily consider this critical. Refreshing the page would fix the issue. However, we need a better way to restart the wizard/login in this case. I'll fix the CSS issue on this page, add text to indicate the user can retry, and add a link back to the root, which will direct them back through security token, setup wizard, etc.. Unless something bad happens like Jenkins has crashed, in which case they're sorta out of luck. Do you agree with this danielbeck ?

          Daniel Beck added a comment -

          Suggestion looks good.

          Daniel Beck added a comment - Suggestion looks good.

          Code changed in jenkins
          User: kzantow
          Path:
          core/src/main/resources/jenkins/install/SetupWizard/authenticate-security-token.jelly
          core/src/main/resources/jenkins/install/pluginSetupWizard.properties
          core/src/main/resources/lib/layout/html.jelly
          war/src/main/js/pluginSetupWizardGui.js
          war/src/main/js/templates/errorPanel.hbs
          war/src/main/less/pluginSetupWizard.less
          http://jenkins-ci.org/commit/jenkins/2757b471a0a7430dbc85db2ac042dc3f02a52f9c
          Log:
          JENKINS-33813 - fix error page styling issue, add option to retry, fix
          check for setup wizard js include

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: kzantow Path: core/src/main/resources/jenkins/install/SetupWizard/authenticate-security-token.jelly core/src/main/resources/jenkins/install/pluginSetupWizard.properties core/src/main/resources/lib/layout/html.jelly war/src/main/js/pluginSetupWizardGui.js war/src/main/js/templates/errorPanel.hbs war/src/main/less/pluginSetupWizard.less http://jenkins-ci.org/commit/jenkins/2757b471a0a7430dbc85db2ac042dc3f02a52f9c Log: JENKINS-33813 - fix error page styling issue, add option to retry, fix check for setup wizard js include

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/jenkins/install/SetupWizard/authenticate-security-token.jelly
          core/src/main/resources/jenkins/install/pluginSetupWizard.properties
          core/src/main/resources/lib/layout/html.jelly
          war/src/main/js/pluginSetupWizardGui.js
          war/src/main/js/templates/errorPanel.hbs
          war/src/main/less/pluginSetupWizard.less
          http://jenkins-ci.org/commit/jenkins/cbe9ea008af0eebd74673cdfbbcae9cd5dd5d278
          Log:
          Merge pull request #2184 from kzantow/JENKINS-33813-graceful-setup-wizard-restart

          JENKINS-33813 - fix issues when errors happen during setup wizard

          Compare: https://github.com/jenkinsci/jenkins/compare/e32232258478...cbe9ea008af0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/jenkins/install/SetupWizard/authenticate-security-token.jelly core/src/main/resources/jenkins/install/pluginSetupWizard.properties core/src/main/resources/lib/layout/html.jelly war/src/main/js/pluginSetupWizardGui.js war/src/main/js/templates/errorPanel.hbs war/src/main/less/pluginSetupWizard.less http://jenkins-ci.org/commit/jenkins/cbe9ea008af0eebd74673cdfbbcae9cd5dd5d278 Log: Merge pull request #2184 from kzantow/ JENKINS-33813 -graceful-setup-wizard-restart JENKINS-33813 - fix issues when errors happen during setup wizard Compare: https://github.com/jenkinsci/jenkins/compare/e32232258478...cbe9ea008af0

          Daniel Beck added a comment -

          kzantow The merged commit fixes this, right?

          Daniel Beck added a comment - kzantow The merged commit fixes this, right?

          Keith Zantow added a comment -

          danielbeck yes, I'm considering this one fixed

          Keith Zantow added a comment - danielbeck yes, I'm considering this one fixed

          Daniel Beck added a comment -

          Bot needs [FIX JENKINS-num] in commit messages.

          Daniel Beck added a comment - Bot needs [FIX JENKINS-num] in commit messages.

            kzantow Keith Zantow
            aheritier Arnaud Héritier
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: