Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33822

New Item creation keyboard navigation does not work

      We'll need to make sure keyboard navigation works on this. Currently the radio buttons are display: none, which makes the browser not allow selection.

          [JENKINS-33822] New Item creation keyboard navigation does not work

          gus reiber added a comment -

          kzantow happy to take it. Pretty straight forward, I think.

          gus reiber added a comment - kzantow happy to take it. Pretty straight forward, I think.

          This is not a regression since never worked fine.

          Manuel Recena Soto added a comment - This is not a regression since never worked fine.

          Manuel Recena Soto added a comment - - edited

          kzantow The radio buttons should be removed completly.

          Manuel Recena Soto added a comment - - edited kzantow The radio buttons should be removed completly.

          gusreiber I've updated the status of this issue.

          Manuel Recena Soto added a comment - gusreiber I've updated the status of this issue.

          teilo Could you try on window my PR proposed for this issue? https://github.com/jenkinsci/jenkins/pull/2250

          Manuel Recena Soto added a comment - teilo Could you try on window my PR proposed for this issue? https://github.com/jenkinsci/jenkins/pull/2250

          There is a PR verified and reviewed here.

          Manuel Recena Soto added a comment - There is a PR verified and reviewed here .

          I've recorded a screencast in order to make easier the result. https://goo.gl/xNpn3D

          Manuel Recena Soto added a comment - I've recorded a screencast in order to make easier the result. https://goo.gl/xNpn3D

          Code changed in jenkins
          User: Manuel Recena
          Path:
          core/src/main/resources/hudson/model/View/newJob.jelly
          war/src/main/js/add-item.js
          war/src/main/js/widgets/add/addform.less
          http://jenkins-ci.org/commit/jenkins/ece6606066abcf33dbff7be42b35e78253cad267
          Log:
          JENKINS-33822 Create a new item using the keyboard

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: core/src/main/resources/hudson/model/View/newJob.jelly war/src/main/js/add-item.js war/src/main/js/widgets/add/addform.less http://jenkins-ci.org/commit/jenkins/ece6606066abcf33dbff7be42b35e78253cad267 Log: JENKINS-33822 Create a new item using the keyboard

          Code changed in jenkins
          User: Manuel Recena
          Path:
          war/src/main/js/add-item.js
          http://jenkins-ci.org/commit/jenkins/fc05e5cb6b498f7f1cd6e3ec3b9048e395ce5a4f
          Log:
          JENKINS-33822 Handled when CopyFrom is focused

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: war/src/main/js/add-item.js http://jenkins-ci.org/commit/jenkins/fc05e5cb6b498f7f1cd6e3ec3b9048e395ce5a4f Log: JENKINS-33822 Handled when CopyFrom is focused

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/resources/hudson/model/View/newJob.jelly
          war/src/main/js/add-item.js
          war/src/main/js/widgets/add/addform.less
          http://jenkins-ci.org/commit/jenkins/eae8cd6fb3cc4ff1bb92b037d6830686d56a31e5
          Log:
          Merge pull request #2250 from recena/JENKINS-33822

          JENKINS-33822 Create a new item using the keyboard

          Compare: https://github.com/jenkinsci/jenkins/compare/d442682699b6...eae8cd6fb3cc

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/model/View/newJob.jelly war/src/main/js/add-item.js war/src/main/js/widgets/add/addform.less http://jenkins-ci.org/commit/jenkins/eae8cd6fb3cc4ff1bb92b037d6830686d56a31e5 Log: Merge pull request #2250 from recena/ JENKINS-33822 JENKINS-33822 Create a new item using the keyboard Compare: https://github.com/jenkinsci/jenkins/compare/d442682699b6...eae8cd6fb3cc

            recena Manuel Recena Soto
            kzantow Keith Zantow
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: