Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34101

Option for input parameters to be flattened to string

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Currently InputStepExecution.convert calls ParameterValue.getValue() and returns the value raw, under the assumption it is Serializable and sandbox-friendly.

      This is not true at least for the case of RunParameterValue. We would prefer to have the option to call buildEnvironment and return a flat Map<String,String>.

        Attachments

          Issue Links

            Activity

            jglick Jesse Glick created issue -
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Remote Link This issue links to "Question (Web Link)" [ 14171 ]
            Hide
            jglick Jesse Glick added a comment - - edited

            In a sense the opposite of JENKINS-27295, though that pertains to build parameters whereas this is about parameters passed to the input step.

            Show
            jglick Jesse Glick added a comment - - edited In a sense the opposite of JENKINS-27295 , though that pertains to build parameters whereas this is about parameters passed to the input step.
            jglick Jesse Glick made changes -
            Link This issue is related to JENKINS-27295 [ JENKINS-27295 ]
            jglick Jesse Glick made changes -
            Epic Link JENKINS-35394 [ 171187 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 170131 ] JNJira + In-Review [ 183776 ]
            abayer Andrew Bayer made changes -
            Component/s pipeline-general [ 21692 ]
            abayer Andrew Bayer made changes -
            Component/s workflow-plugin [ 18820 ]
            jglick Jesse Glick made changes -
            Component/s pipeline-input-step-plugin [ 21708 ]
            Component/s pipeline [ 21692 ]
            jglick Jesse Glick made changes -
            Link This issue is blocking JENKINS-38394 [ JENKINS-38394 ]
            Hide
            jglick Jesse Glick added a comment -

            Should probably refuse to include PasswordParameterValue since these would neither be stored safely in program.dat (via SecretPickle) nor masked in console output. For that it is better to use withCredentials and ask for per-user credentials, or use the Mask Passwords plugin (though for that case probably structs needs to be amended to let a Secret be bound to a String so that you can create a VarPasswordPair without even temporarily storing plaintext in the program).

            Show
            jglick Jesse Glick added a comment - Should probably refuse to include PasswordParameterValue since these would neither be stored safely in program.dat (via SecretPickle ) nor masked in console output. For that it is better to use withCredentials and ask for per-user credentials, or use the Mask Passwords plugin (though for that case probably structs needs to be amended to let a Secret be bound to a String so that you can create a VarPasswordPair without even temporarily storing plaintext in the program).
            jglick Jesse Glick made changes -
            Link This issue relates to JENKINS-43857 [ JENKINS-43857 ]

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: