-
Bug
-
Resolution: Fixed
-
Minor
-
None
-
Jenkins 1.656. Active Choices 1.4
On my Jenkins master, I see a lot of the following noise in jenkins.log:
Apr 12, 2016 3:21:06 PM org.biouno.unochoice.AbstractScriptableParameter getChoices WARNING: Script parameter with name 'PARAM_NAME_HERE' is not an instance of java.util.Map. The parameter value is Apr 12, 2016 3:21:06 PM org.biouno.unochoice.AbstractScriptableParameter getChoices WARNING: Script parameter with name 'PARAM_NAME_HERE' is not an instance of java.util.Map. The parameter value is
The mentioned parameter (name altered here for privacy) is an Active Choices Reactive Reference Parameter, of type "formatted html", and the HTML contains the following field (with value also altered for privacy):
<input type="hidden" name="value" value="http://example.com/some_url" class="setting-input"/>
[JENKINS-34188] jenkins.log noise: "script parameter ... is not an instance of Java.util.Map."
Hi Dana, Ben.
When that log entry was implemented, the plug-in was being refactored, and it was useful for troubleshooting regressions or bugs.
Now I agree with you two, so let's fix it.
The reason why, even though the script works, the message is still displayed; is that - from what I recall - there was one initial call done, before the screen was completely rendered, and that generated this log entry. Shortly after that there is another call and the message should not be displayed again (though it may be happening anyway).
The fix is quite simple. Let's make this a debug level entry only, and prevent it from spamming the logs. Included in the next release (as soon as I find some spare time for that).
Bruno
Could you do a release just to fix this? It's literally 90% of the logs for my entire jenkins server.
(or maybe a log4j guru could provide a config to filter this spam)
The master branch has already a few fixes, and we are now working on tickets like JENKINS-38889, which we can ship quite soon. A hotfix with just this fix is doable, but I would rather wait to release everything in the next days.
The plug-in is part of the BioUno project. And we will have a project meeting on November 18th. I just replied the meeting announcement e-mail from ioannis suggesting to cut a release before the meeting, and another release before the end of the year - https://groups.google.com/forum/#!topic/biouno-users/2Scg0u6V3kM
So if, besides this ticket, there are any other features/bugs that you would like to get shipped in the next releases, just reply here or join the hangout 
Cheers
B
Apologies for the delay to fix this.
Pushed to master. Now this message will appear in the log, only if the logger is enabled to debug in the FINE level.
Included in the next release (1.5.4 probably), scheduled for December. An alpha version should be available in the experimental update center late this week, on Friday NZ time.
Code changed in jenkins
User: Bruno P. Kinoshita
Path:
src/main/java/org/biouno/unochoice/AbstractScriptableParameter.java
http://jenkins-ci.org/commit/active-choices-plugin/db09e6d928553f14fa5b0f0f698c146a12cb4b99
Log:
[FIXED JENKINS-34188] suppress log entry, unless level FINE is enabled
We also have this issue, it's super annoying.