Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34228

IOException produced in CLI 'delete-builds'

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: cli
    • Labels:
      None
    • Similar Issues:

      Description

      IOException is produced when delete-buidls is invoked with a repeated build number.

      It can be made by mistake e.g. delete-builds 1,2,3,3 or intentionally e.g. delete-builds 1-6,3-10.

      DeleteBuildsCommand class is derived from AbstractBuildRangeCommand where it is possible to have a build specified more times for whatever reason. In current impl. it is responsibility of DeleteBuildsCommand to handle that situation correctly.

        Attachments

          Issue Links

            Activity

            Hide
            pajasoft Pavel Janoušek added a comment -

            PR sent.

            Show
            pajasoft Pavel Janoušek added a comment - PR sent.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ing. Pavel Janousek
            Path:
            core/src/main/java/hudson/cli/DeleteBuildsCommand.java
            http://jenkins-ci.org/commit/jenkins/efc1285d67fb7a8e3df2cd1d499a15edc6641d02
            Log:
            JENKINS-34228 Fixed IOException in DeleteBuildsCommand class

            'delete-builds' CLi can be invoked with more occurence of the same
            build number. Handle such a situation is responsibility of the
            command impl. itself.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ing. Pavel Janousek Path: core/src/main/java/hudson/cli/DeleteBuildsCommand.java http://jenkins-ci.org/commit/jenkins/efc1285d67fb7a8e3df2cd1d499a15edc6641d02 Log: JENKINS-34228 Fixed IOException in DeleteBuildsCommand class 'delete-builds' CLi can be invoked with more occurence of the same build number. Handle such a situation is responsibility of the command impl. itself.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/java/hudson/cli/DeleteBuildsCommand.java
            http://jenkins-ci.org/commit/jenkins/ce9de5a19dceb82aea49787c4401e9886c21e09a
            Log:
            Merge pull request #2263 from pjanouse/JENKINS-34228

            JENKINS-34228 Fixed IOException in DeleteBuildsCommand class

            Compare: https://github.com/jenkinsci/jenkins/compare/e1dc525fda14...ce9de5a19dce

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/hudson/cli/DeleteBuildsCommand.java http://jenkins-ci.org/commit/jenkins/ce9de5a19dceb82aea49787c4401e9886c21e09a Log: Merge pull request #2263 from pjanouse/ JENKINS-34228 JENKINS-34228 Fixed IOException in DeleteBuildsCommand class Compare: https://github.com/jenkinsci/jenkins/compare/e1dc525fda14...ce9de5a19dce
            Hide
            danielbeck Daniel Beck added a comment -

            Fixed towards 2.1.

            Show
            danielbeck Daniel Beck added a comment - Fixed towards 2.1.

              People

              Assignee:
              pajasoft Pavel Janoušek
              Reporter:
              pajasoft Pavel Janoušek
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: