Probably more a nit-pick, but I tried to read the code today in Eclipse, and it was quite messy. Looks like tabs and spaces were used, which may work fine in some editors and operating systems, but is not very readable in GitHub web UI or in some editors.

By using only spaces (or only tabs, as long as we are consistent) it will be easier to review bigger pull request (sent only two trivial pull requests today, but one for JENKINS-34296 for example would change many parts of the code).