Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34464

DescribableModel can't inspect ReverseBuildTrigger; need binding for Result

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core, (1)
      structs-plugin
    • None
    • core 2.0
      structs 1.1

      DescribableModel reports an error for hudson.model.Result.

      Run this in script console to reproduce:

      import org.jenkinsci.plugins.structs.describable.*
      import jenkins.triggers.*
        
      new DescribableModel(ReverseBuildTrigger)
      

      Result:

      (upstreamProjects: String, threshold: org.kohsuke.stapler.NoStaplerConstructorException: There's no @DataBoundConstructor on any constructor of class hudson.model.Result)
      

          [JENKINS-34464] DescribableModel can't inspect ReverseBuildTrigger; need binding for Result

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java
          plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java
          plugin/src/main/java/org/jenkinsci/plugins/structs/describable/ParameterType.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java
          http://jenkins-ci.org/commit/structs-plugin/1c8a50cff6b53babc8d155b5c92b3497fe33c6b3
          Log:
          [FIXED JENKINS-34464] Enable DescribableModel binding for Result

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableModel.java plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java plugin/src/main/java/org/jenkinsci/plugins/structs/describable/ParameterType.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java http://jenkins-ci.org/commit/structs-plugin/1c8a50cff6b53babc8d155b5c92b3497fe33c6b3 Log: [FIXED JENKINS-34464] Enable DescribableModel binding for Result

          Andrew Bayer added a comment -

          Fixed in next release (1.7?) of structs plugin.

          Andrew Bayer added a comment - Fixed in next release (1.7?) of structs plugin.

          Andrew Bayer added a comment -

          Hrm, having some problem with the downstream test. Reopening until I get that straightened out.

          Andrew Bayer added a comment - Hrm, having some problem with the downstream test. Reopening until I get that straightened out.

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
          src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/b5343636ebdcb5da3b1a2d1be6ce6afb128cb258
          Log:
          JENKINS-34464 Bump structs version, add test for result roundtrip

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java http://jenkins-ci.org/commit/workflow-cps-plugin/b5343636ebdcb5da3b1a2d1be6ce6afb128cb258 Log: JENKINS-34464 Bump structs version, add test for result roundtrip

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java
          src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/448fe7a6d701f21c5b43a9cb8dd880edd6f9b0ad
          Log:
          Merge pull request #136 from abayer/jenkins-34464

          JENKINS-34464 Bump structs version, add test for result roundtrip

          Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/21e1ef16c7fe...448fe7a6d701

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/cps/SnippetizerTest.java src/test/java/org/jenkinsci/plugins/workflow/testMetaStep/EchoResultStep.java http://jenkins-ci.org/commit/workflow-cps-plugin/448fe7a6d701f21c5b43a9cb8dd880edd6f9b0ad Log: Merge pull request #136 from abayer/jenkins-34464 JENKINS-34464 Bump structs version, add test for result roundtrip Compare: https://github.com/jenkinsci/workflow-cps-plugin/compare/21e1ef16c7fe...448fe7a6d701

          Andrew Bayer added a comment -

          Fixed in structs 1.7 release.

          Andrew Bayer added a comment - Fixed in structs 1.7 release.

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/ec7abe9bfe60caeaeaa55df949eb1b2b04cbfa5d
          Log:
          JENKINS-34464 Test for Result working in Snippet Generator

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/ec7abe9bfe60caeaeaa55df949eb1b2b04cbfa5d Log: JENKINS-34464 Test for Result working in Snippet Generator

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          pom.xml
          src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java
          http://jenkins-ci.org/commit/workflow-multibranch-plugin/adf46741ea0520c42aea62cc02c916ff5a8e6d21
          Log:
          Merge pull request #63 from abayer/jenkins-34464

          JENKINS-34464 Test for Result working in Snippet Generator

          Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/0f5fae969de6...adf46741ea05

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/test/java/org/jenkinsci/plugins/workflow/multibranch/JobPropertyStepTest.java http://jenkins-ci.org/commit/workflow-multibranch-plugin/adf46741ea0520c42aea62cc02c916ff5a8e6d21 Log: Merge pull request #63 from abayer/jenkins-34464 JENKINS-34464 Test for Result working in Snippet Generator Compare: https://github.com/jenkinsci/workflow-multibranch-plugin/compare/0f5fae969de6...adf46741ea05

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
          http://jenkins-ci.org/commit/jenkins/3b712af2ded342d992aed559fcce314e11bb32b7
          Log:
          JENKINS-34464 Switch ReverseBuildTrigger.threshold to DataBoundSetter

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java http://jenkins-ci.org/commit/jenkins/3b712af2ded342d992aed559fcce314e11bb32b7 Log: JENKINS-34464 Switch ReverseBuildTrigger.threshold to DataBoundSetter

          Code changed in jenkins
          User: Daniel Beck
          Path:
          core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
          http://jenkins-ci.org/commit/jenkins/4515a075182e3dd98bec027047ed8385be137064
          Log:
          Merge pull request #2895 from abayer/jenkins-34464

          JENKINS-34464 Switch ReverseBuildTrigger.threshold to DataBoundSetter

          Compare: https://github.com/jenkinsci/jenkins/compare/2b8b18997945...4515a075182e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java http://jenkins-ci.org/commit/jenkins/4515a075182e3dd98bec027047ed8385be137064 Log: Merge pull request #2895 from abayer/jenkins-34464 JENKINS-34464 Switch ReverseBuildTrigger.threshold to DataBoundSetter Compare: https://github.com/jenkinsci/jenkins/compare/2b8b18997945...4515a075182e

            abayer Andrew Bayer
            daspilker Daniel Spilker
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: