Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3465

Option for view to display Last Stable/Unstable rather than Last Success/Failure

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      At the indicated URL we care about stable builds. Unstable builds are little
      better than failed builds. So we want to see when the build was last stable.
      Unstable builds could be counted in the failed column, or have their own column.
      Would like to be able to set this as an option at

      http://deadlock.netbeans.org/hudson/view/Push%20To%20main-silver%20builds/configure

        Attachments

          Activity

          Hide
          jglick Jesse Glick added a comment -

          DescribableList-based approach under investigation in

          https://hudson.dev.java.net/svn/hudson/branches/configurable-view-columns-3465

          Show
          jglick Jesse Glick added a comment - DescribableList-based approach under investigation in https://hudson.dev.java.net/svn/hudson/branches/configurable-view-columns-3465
          Hide
          jglick Jesse Glick added a comment -

          Created an attachment (id=674)
          Demo usage - adds an option for Last Success column to show # of test failures

          Show
          jglick Jesse Glick added a comment - Created an attachment (id=674) Demo usage - adds an option for Last Success column to show # of test failures
          Hide
          jglick Jesse Glick added a comment -

          Note messiness with newInstance which is called with req==null. Cleaner would
          perhaps be to have a ListViewColumnDescriptor with a dedicated method such as

          public ListViewColumn newAutoInstance() {
          return null;
          }

          and ListView could call this instead of the current

          descriptor.newInstance(null, null)

          which throws NPE unless newInstance is overridden in each descriptor subclass.

          I won't do this for now: (1) would be incompatible for existing ListViewColumn
          impls (would need to change descriptor supertype); (2) the generics would get
          pretty complicated, since ListViewColumn implements Describable<ListViewColumn>
          rather than Describable<T extends ListViewColumn> or something like this; (3)
          the workaround is not hard:

          @Override
          public ListViewColumn newInstance(StaplerRequest _1, JSONObject _2)

          { return new LastSuccessColumn(false); }
          Show
          jglick Jesse Glick added a comment - Note messiness with newInstance which is called with req==null. Cleaner would perhaps be to have a ListViewColumnDescriptor with a dedicated method such as public ListViewColumn newAutoInstance() { return null; } and ListView could call this instead of the current descriptor.newInstance(null, null) which throws NPE unless newInstance is overridden in each descriptor subclass. I won't do this for now: (1) would be incompatible for existing ListViewColumn impls (would need to change descriptor supertype); (2) the generics would get pretty complicated, since ListViewColumn implements Describable<ListViewColumn> rather than Describable<T extends ListViewColumn> or something like this; (3) the workaround is not hard: @Override public ListViewColumn newInstance(StaplerRequest _1, JSONObject _2) { return new LastSuccessColumn(false); }
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jglick
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/ListView.java
          trunk/hudson/main/core/src/main/java/hudson/views/ListViewColumn.java
          trunk/hudson/main/core/src/main/resources/hudson/model/ListView/configure-entries.jelly
          trunk/hudson/main/core/src/main/resources/lib/form/hetero-list.jelly
          http://fisheye4.cenqua.com/changelog/hudson/?cs=17352
          Log:
          [FIXED JENKINS-3465] Permit configurable column lists in views, and add optional Last Stable column.
          Currently no columns have configurable data, but this can be added if desired (see issue report for demo).
          API changes: type change in ListView.columns and getColumns; ListViewColumn.shownByDefault added.
          [merged https://hudson.dev.java.net/svn/hudson/branches/configurable-view-columns-3465]

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jglick Path: trunk/hudson/main/core/src/main/java/hudson/model/ListView.java trunk/hudson/main/core/src/main/java/hudson/views/ListViewColumn.java trunk/hudson/main/core/src/main/resources/hudson/model/ListView/configure-entries.jelly trunk/hudson/main/core/src/main/resources/lib/form/hetero-list.jelly http://fisheye4.cenqua.com/changelog/hudson/?cs=17352 Log: [FIXED JENKINS-3465] Permit configurable column lists in views, and add optional Last Stable column. Currently no columns have configurable data, but this can be added if desired (see issue report for demo). API changes: type change in ListView.columns and getColumns; ListViewColumn.shownByDefault added. [merged https://hudson.dev.java.net/svn/hudson/branches/configurable-view-columns-3465]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : jglick
          Path:
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=17353
          Log:
          JENKINS-3465 Noting.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : jglick Path: trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=17353 Log: JENKINS-3465 Noting.

            People

            Assignee:
            jglick Jesse Glick
            Reporter:
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: