Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34669

Static resources are being included twice in SetupWizard

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: In Progress (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      There are views in SetupWizard where the resources /jenkins/jsbundles/pluginSetupWizard.js and /jenkins/jsbundles/pluginSetupWizard.css are being included twice (here and here).

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Tom FENNELLY is working on it

            Show
            oleg_nenashev Oleg Nenashev added a comment - Tom FENNELLY is working on it
            Hide
            recena Manuel Recena Soto added a comment - - edited

            I had a PR ready for this

            My proposal is to remove these lines.

            Show
            recena Manuel Recena Soto added a comment - - edited I had a PR ready for this My proposal is to remove these lines .
            Hide
            tfennelly Tom FENNELLY added a comment -

            Manuel Recena Soto Ooops ... you it was not marked as in-progress so we didn't know you were doing anything with it.

            Anyway ... not sure removing those lines will work. I assume Keith Zantow added them for a reason.

            I created this PR: https://github.com/jenkinsci/jenkins/pull/2322

            It changes to use an adjunct, which makes sure the .js file is only loaded once.

            Show
            tfennelly Tom FENNELLY added a comment - Manuel Recena Soto Ooops ... you it was not marked as in-progress so we didn't know you were doing anything with it. Anyway ... not sure removing those lines will work. I assume Keith Zantow added them for a reason. I created this PR: https://github.com/jenkinsci/jenkins/pull/2322 It changes to use an adjunct, which makes sure the .js file is only loaded once.
            Hide
            recena Manuel Recena Soto added a comment -

            Tom FENNELLY

            Since the setup wizard is using html.jelly as custom template (for its layout), those lines are not needed.

            With <st:adjunct /> we are doing a double check.

            Show
            recena Manuel Recena Soto added a comment - Tom FENNELLY Since the setup wizard is using html.jelly as custom template (for its layout), those lines are not needed. With <st:adjunct /> we are doing a double check.
            Hide
            tfennelly Tom FENNELLY added a comment -

            Manuel Recena Soto

            Yeah, that looks to be the case. But I would leave Keith Zantow to be the final decision maker on that since this is his "baby". If it's only needed in one place then maybe jenkins/install/SetupWizard/index.jelly is the one to leave, incase html.jelly is used for other stuff. Otherwise, it would appear as though jenkins/install/SetupWizard/index.jelly should just be deleted.

            Anyway ... ask Keith Zantow what his original intention was for this.

            Show
            tfennelly Tom FENNELLY added a comment - Manuel Recena Soto Yeah, that looks to be the case. But I would leave Keith Zantow to be the final decision maker on that since this is his "baby". If it's only needed in one place then maybe jenkins/install/SetupWizard/index.jelly is the one to leave, incase html.jelly is used for other stuff. Otherwise, it would appear as though jenkins/install/SetupWizard/index.jelly should just be deleted. Anyway ... ask Keith Zantow what his original intention was for this.
            Hide
            recena Manuel Recena Soto added a comment -

            As far as I can see, this issue is already solved as part of this PR.

            Show
            recena Manuel Recena Soto added a comment - As far as I can see, this issue is already solved as part of this PR .

              People

              Assignee:
              tfennelly Tom FENNELLY
              Reporter:
              recena Manuel Recena Soto
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: