Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34669

Static resources are being included twice in SetupWizard

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • core
    • None

      There are views in SetupWizard where the resources /jenkins/jsbundles/pluginSetupWizard.js and /jenkins/jsbundles/pluginSetupWizard.css are being included twice (here and here).

          [JENKINS-34669] Static resources are being included twice in SetupWizard

          Oleg Nenashev added a comment -

          tfennelly is working on it

          Oleg Nenashev added a comment - tfennelly is working on it

          Manuel Recena Soto added a comment - - edited

          I had a PR ready for this

          My proposal is to remove these lines.

          Manuel Recena Soto added a comment - - edited I had a PR ready for this My proposal is to remove these lines .

          Tom FENNELLY added a comment -

          recena Ooops ... you it was not marked as in-progress so we didn't know you were doing anything with it.

          Anyway ... not sure removing those lines will work. I assume kzantow added them for a reason.

          I created this PR: https://github.com/jenkinsci/jenkins/pull/2322

          It changes to use an adjunct, which makes sure the .js file is only loaded once.

          Tom FENNELLY added a comment - recena Ooops ... you it was not marked as in-progress so we didn't know you were doing anything with it. Anyway ... not sure removing those lines will work. I assume kzantow added them for a reason. I created this PR: https://github.com/jenkinsci/jenkins/pull/2322 It changes to use an adjunct, which makes sure the .js file is only loaded once.

          Manuel Recena Soto added a comment -

          tfennelly

          Since the setup wizard is using html.jelly as custom template (for its layout), those lines are not needed.

          With <st:adjunct /> we are doing a double check.

          Manuel Recena Soto added a comment - tfennelly Since the setup wizard is using html.jelly as custom template (for its layout), those lines are not needed. With <st:adjunct /> we are doing a double check.

          Tom FENNELLY added a comment -

          recena

          Yeah, that looks to be the case. But I would leave kzantow to be the final decision maker on that since this is his "baby". If it's only needed in one place then maybe jenkins/install/SetupWizard/index.jelly is the one to leave, incase html.jelly is used for other stuff. Otherwise, it would appear as though jenkins/install/SetupWizard/index.jelly should just be deleted.

          Anyway ... ask kzantow what his original intention was for this.

          Tom FENNELLY added a comment - recena Yeah, that looks to be the case. But I would leave kzantow to be the final decision maker on that since this is his "baby". If it's only needed in one place then maybe jenkins/install/SetupWizard/index.jelly is the one to leave, incase html.jelly is used for other stuff. Otherwise, it would appear as though jenkins/install/SetupWizard/index.jelly should just be deleted. Anyway ... ask kzantow what his original intention was for this.

          Manuel Recena Soto added a comment -

          As far as I can see, this issue is already solved as part of this PR.

          Manuel Recena Soto added a comment - As far as I can see, this issue is already solved as part of this PR .

            tfennelly Tom FENNELLY
            recena Manuel Recena Soto
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: