Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34755

Allow setting of system properties from context.xml in addition to setting from command line

      Issue for https://github.com/jenkinsci/jenkins/pull/1914

      Goals:

      • Allow the specification of system properties in context.xml in addition to in environment variables
      • Avoid having to edit tomcat's systemd.service file to run Jenkins with flags.
      • Avoid having to restart app server if flags are changed in context.xml.
      • Makes it easier for Jenkins to coexist with other apps on the same app server.
      • Centralize parsing of system properties:
        • over time, consistent error reporting can be implemented for malformed system properties. Right now, that code is all over the place (e.g. what is and isn't true or false in boolean values is implemented differently)
        • access to system properties is now logged, which helps with debugging setups

          [JENKINS-34755] Allow setting of system properties from context.xml in addition to setting from command line

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/jenkins/util/SystemProperties.java
          http://jenkins-ci.org/commit/jenkins/d03e68f03c886631d986b2555c58ca91a2d5d248
          Log:
          JENKINS-34755 - Wrap SecurityExceptions, they should not go outside

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/util/SystemProperties.java http://jenkins-ci.org/commit/jenkins/d03e68f03c886631d986b2555c58ca91a2d5d248 Log: JENKINS-34755 - Wrap SecurityExceptions, they should not go outside

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/jenkins/util/SystemProperties.java
          test/src/test/java/jenkins/util/SystemPropertiesTest.java
          http://jenkins-ci.org/commit/jenkins/d0012ea8d76c433fd327319e26547f7d4c02957e
          Log:
          JENKINS-34755 - Add some tests

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/util/SystemProperties.java test/src/test/java/jenkins/util/SystemPropertiesTest.java http://jenkins-ci.org/commit/jenkins/d0012ea8d76c433fd327319e26547f7d4c02957e Log: JENKINS-34755 - Add some tests

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/jenkins/util/SystemProperties.java
          http://jenkins-ci.org/commit/jenkins/c9a5995cc3fd87228671331b4d88d6e83ea52cdd
          Log:
          JENKINS-34755 - Wrap all loggers with logging level checks

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/util/SystemProperties.java http://jenkins-ci.org/commit/jenkins/c9a5995cc3fd87228671331b4d88d6e83ea52cdd Log: JENKINS-34755 - Wrap all loggers with logging level checks

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/jenkins/util/SystemProperties.java
          http://jenkins-ci.org/commit/jenkins/cf0444f056ee5cd426701596a8c2901b61819f3b
          Log:
          JENKINS-34755 - Added disclaimer regarding the non-initialized context

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/jenkins/util/SystemProperties.java http://jenkins-ci.org/commit/jenkins/cf0444f056ee5cd426701596a8c2901b61819f3b Log: JENKINS-34755 - Added disclaimer regarding the non-initialized context

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          changelog.html
          core/pom.xml
          core/src/main/java/hudson/FilePath.java
          core/src/main/java/hudson/PluginManager.java
          core/src/main/java/hudson/model/Job.java
          core/src/main/java/hudson/model/Run.java
          core/src/main/java/hudson/model/UpdateCenter.java
          core/src/main/java/hudson/model/UpdateSite.java
          core/src/main/java/hudson/security/SecurityRealm.java
          core/src/main/resources/hudson/security/SecurityRealm/loginLink.jelly
          core/src/main/resources/hudson/triggers/TimerTrigger/help-spec.html
          core/src/main/resources/jenkins/model/CoreEnvironmentContributor/buildEnv.groovy
          core/src/main/resources/jenkins/model/CoreEnvironmentContributor/buildEnv.properties
          core/src/test/java/hudson/FilePathTest.java
          pom.xml
          test/src/test/java/hudson/cli/DeleteBuildsCommandTest.java
          test/src/test/java/hudson/model/ExecutorTest.java
          war/src/main/js/util/jenkins.js
          http://jenkins-ci.org/commit/jenkins/fdabb525034e587bab2ec56eb7fc4c2431908232
          Log:
          Merge branch 'master' into JENKINS-34755

          Conflicts:
          core/src/main/java/hudson/FilePath.java

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: changelog.html core/pom.xml core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/model/Job.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/security/SecurityRealm.java core/src/main/resources/hudson/security/SecurityRealm/loginLink.jelly core/src/main/resources/hudson/triggers/TimerTrigger/help-spec.html core/src/main/resources/jenkins/model/CoreEnvironmentContributor/buildEnv.groovy core/src/main/resources/jenkins/model/CoreEnvironmentContributor/buildEnv.properties core/src/test/java/hudson/FilePathTest.java pom.xml test/src/test/java/hudson/cli/DeleteBuildsCommandTest.java test/src/test/java/hudson/model/ExecutorTest.java war/src/main/js/util/jenkins.js http://jenkins-ci.org/commit/jenkins/fdabb525034e587bab2ec56eb7fc4c2431908232 Log: Merge branch 'master' into JENKINS-34755 Conflicts: core/src/main/java/hudson/FilePath.java

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/ClassicPluginStrategy.java
          core/src/main/java/hudson/DNSMultiCast.java
          core/src/main/java/hudson/FilePath.java
          core/src/main/java/hudson/Functions.java
          core/src/main/java/hudson/LocalPluginManager.java
          core/src/main/java/hudson/Main.java
          core/src/main/java/hudson/PluginManager.java
          core/src/main/java/hudson/TcpSlaveAgentListener.java
          core/src/main/java/hudson/UDPBroadcastThread.java
          core/src/main/java/hudson/Util.java
          core/src/main/java/hudson/WebAppMain.java
          core/src/main/java/hudson/cli/CLICommand.java
          core/src/main/java/hudson/init/InitStrategy.java
          core/src/main/java/hudson/lifecycle/Lifecycle.java
          core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java
          core/src/main/java/hudson/model/AbstractBuild.java
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/model/DownloadService.java
          core/src/main/java/hudson/model/FullDuplexHttpChannel.java
          core/src/main/java/hudson/model/Item.java
          core/src/main/java/hudson/model/LoadStatistics.java
          core/src/main/java/hudson/model/Queue.java
          core/src/main/java/hudson/model/Run.java
          core/src/main/java/hudson/model/Slave.java
          core/src/main/java/hudson/model/TreeView.java
          core/src/main/java/hudson/model/UpdateCenter.java
          core/src/main/java/hudson/model/UpdateSite.java
          core/src/main/java/hudson/model/UsageStatistics.java
          core/src/main/java/hudson/model/User.java
          core/src/main/java/hudson/model/ViewJob.java
          core/src/main/java/hudson/model/WorkspaceCleanupThread.java
          core/src/main/java/hudson/model/queue/BackFiller.java
          core/src/main/java/hudson/os/solaris/ZFSInstaller.java
          core/src/main/java/hudson/scheduler/BaseParser.java
          core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java
          core/src/main/java/hudson/slaves/ChannelPinger.java
          core/src/main/java/hudson/slaves/CloudRetentionStrategy.java
          core/src/main/java/hudson/slaves/ConnectionActivityMonitor.java
          core/src/main/java/hudson/slaves/NodeProvisioner.java
          core/src/main/java/hudson/slaves/WorkspaceList.java
          core/src/main/java/hudson/tasks/ArtifactArchiver.java
          core/src/main/java/hudson/tasks/Fingerprinter.java
          core/src/main/java/hudson/util/CharacterEncodingFilter.java
          core/src/main/java/hudson/util/ProcessTree.java
          core/src/main/java/hudson/util/RingBufferLogHandler.java
          core/src/main/java/hudson/util/Secret.java
          core/src/main/java/hudson/widgets/HistoryWidget.java
          core/src/main/java/jenkins/InitReactorRunner.java
          core/src/main/java/jenkins/model/Configuration.java
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/main/java/jenkins/model/lazy/BuildReference.java
          core/src/main/java/jenkins/security/ApiTokenProperty.java
          core/src/main/java/jenkins/security/BasicHeaderRealPasswordAuthenticator.java
          core/src/main/java/jenkins/security/FrameOptionsPageDecorator.java
          core/src/main/java/jenkins/security/SecureRequester.java
          core/src/main/java/jenkins/security/s2m/CallableDirectionChecker.java
          core/src/main/java/jenkins/security/s2m/DefaultFilePathFilter.java
          core/src/main/java/jenkins/slaves/NioChannelSelector.java
          core/src/main/java/jenkins/slaves/StandardOutputSwapper.java
          core/src/main/java/jenkins/util/SystemProperties.java
          core/src/main/java/jenkins/util/xml/XMLUtils.java
          test/src/test/java/jenkins/util/SystemPropertiesTest.java
          http://jenkins-ci.org/commit/jenkins/cf64ba04fe8b0312bb4492766d62b5a00b790432
          Log:
          Merge pull request #2337 from oleg-nenashev/JENKINS-34755

          JENKINS-34755 - Allow setting of system properties from context.xml in addition to setting from command line

          Compare: https://github.com/jenkinsci/jenkins/compare/409438f36dc8...cf64ba04fe8b

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/ClassicPluginStrategy.java core/src/main/java/hudson/DNSMultiCast.java core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/Functions.java core/src/main/java/hudson/LocalPluginManager.java core/src/main/java/hudson/Main.java core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/TcpSlaveAgentListener.java core/src/main/java/hudson/UDPBroadcastThread.java core/src/main/java/hudson/Util.java core/src/main/java/hudson/WebAppMain.java core/src/main/java/hudson/cli/CLICommand.java core/src/main/java/hudson/init/InitStrategy.java core/src/main/java/hudson/lifecycle/Lifecycle.java core/src/main/java/hudson/lifecycle/WindowsInstallerLink.java core/src/main/java/hudson/model/AbstractBuild.java core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/FullDuplexHttpChannel.java core/src/main/java/hudson/model/Item.java core/src/main/java/hudson/model/LoadStatistics.java core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/Run.java core/src/main/java/hudson/model/Slave.java core/src/main/java/hudson/model/TreeView.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/model/UpdateSite.java core/src/main/java/hudson/model/UsageStatistics.java core/src/main/java/hudson/model/User.java core/src/main/java/hudson/model/ViewJob.java core/src/main/java/hudson/model/WorkspaceCleanupThread.java core/src/main/java/hudson/model/queue/BackFiller.java core/src/main/java/hudson/os/solaris/ZFSInstaller.java core/src/main/java/hudson/scheduler/BaseParser.java core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java core/src/main/java/hudson/slaves/ChannelPinger.java core/src/main/java/hudson/slaves/CloudRetentionStrategy.java core/src/main/java/hudson/slaves/ConnectionActivityMonitor.java core/src/main/java/hudson/slaves/NodeProvisioner.java core/src/main/java/hudson/slaves/WorkspaceList.java core/src/main/java/hudson/tasks/ArtifactArchiver.java core/src/main/java/hudson/tasks/Fingerprinter.java core/src/main/java/hudson/util/CharacterEncodingFilter.java core/src/main/java/hudson/util/ProcessTree.java core/src/main/java/hudson/util/RingBufferLogHandler.java core/src/main/java/hudson/util/Secret.java core/src/main/java/hudson/widgets/HistoryWidget.java core/src/main/java/jenkins/InitReactorRunner.java core/src/main/java/jenkins/model/Configuration.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/jenkins/model/lazy/BuildReference.java core/src/main/java/jenkins/security/ApiTokenProperty.java core/src/main/java/jenkins/security/BasicHeaderRealPasswordAuthenticator.java core/src/main/java/jenkins/security/FrameOptionsPageDecorator.java core/src/main/java/jenkins/security/SecureRequester.java core/src/main/java/jenkins/security/s2m/CallableDirectionChecker.java core/src/main/java/jenkins/security/s2m/DefaultFilePathFilter.java core/src/main/java/jenkins/slaves/NioChannelSelector.java core/src/main/java/jenkins/slaves/StandardOutputSwapper.java core/src/main/java/jenkins/util/SystemProperties.java core/src/main/java/jenkins/util/xml/XMLUtils.java test/src/test/java/jenkins/util/SystemPropertiesTest.java http://jenkins-ci.org/commit/jenkins/cf64ba04fe8b0312bb4492766d62b5a00b790432 Log: Merge pull request #2337 from oleg-nenashev/ JENKINS-34755 JENKINS-34755 - Allow setting of system properties from context.xml in addition to setting from command line Compare: https://github.com/jenkinsci/jenkins/compare/409438f36dc8...cf64ba04fe8b

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/DirectoryBrowserSupport.java
          core/src/main/java/hudson/model/ParametersAction.java
          core/src/main/java/hudson/model/User.java
          core/src/main/java/jenkins/install/InstallUtil.java
          core/src/main/java/jenkins/util/SystemProperties.java
          http://jenkins-ci.org/commit/jenkins/99f80a0b0b93a6d7c928d21849d96e0d642e5d1f
          Log:
          JENKINS-34755 Migrate the stuff and restrict access to the engine in the next release (#2346)

          JENKINS-34755 Migrate to SystemProperties and restrict access to the engine

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/DirectoryBrowserSupport.java core/src/main/java/hudson/model/ParametersAction.java core/src/main/java/hudson/model/User.java core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/util/SystemProperties.java http://jenkins-ci.org/commit/jenkins/99f80a0b0b93a6d7c928d21849d96e0d642e5d1f Log: JENKINS-34755 Migrate the stuff and restrict access to the engine in the next release (#2346) JENKINS-34755 Migrate to SystemProperties and restrict access to the engine

          Code changed in jenkins
          User: evernat
          Path:
          core/src/main/java/hudson/WebAppMain.java
          core/src/main/java/jenkins/util/SystemProperties.java
          test/src/test/java/jenkins/util/SystemPropertiesTest.java
          war/src/main/webapp/WEB-INF/web.xml
          http://jenkins-ci.org/commit/jenkins/65f2a4a406c9d853a4ba9c763acc8f049a82c649
          Log:
          JENKINS-34755 fix read of 'SystemProperties' values before init of the context (#2347)

          • fix read of 'SystemProperties' values before init of the context
          • fix constructor and test
          • revert help-spec_fr.html
          • revert help-spec_fr.html
          • revert help-spec_fr.html

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: evernat Path: core/src/main/java/hudson/WebAppMain.java core/src/main/java/jenkins/util/SystemProperties.java test/src/test/java/jenkins/util/SystemPropertiesTest.java war/src/main/webapp/WEB-INF/web.xml http://jenkins-ci.org/commit/jenkins/65f2a4a406c9d853a4ba9c763acc8f049a82c649 Log: JENKINS-34755 fix read of 'SystemProperties' values before init of the context (#2347) fix read of 'SystemProperties' values before init of the context fix constructor and test revert help-spec_fr.html revert help-spec_fr.html revert help-spec_fr.html

          Oleg Nenashev added a comment -

          released in jenkins-2.4

          Oleg Nenashev added a comment - released in jenkins-2.4

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/util/SystemProperties.java
          http://jenkins-ci.org/commit/jenkins/d8821c86451e7e30d6f3225892f01404000e2a60
          Log:
          JENKINS-34755 Noting since for #2337.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/util/SystemProperties.java http://jenkins-ci.org/commit/jenkins/d8821c86451e7e30d6f3225892f01404000e2a60 Log: JENKINS-34755 Noting since for #2337.

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: