Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35153

Events.JobChannel#job_crud_deleted publishing blocked by AccessControl

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:
    • Sprint:
      1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, pannonian, iapetus

      Description

      This is actually an issue in the pubsub-light-module. The GuavaPubsubBus does an AccessControlled check before allowing publishing of any message. The first part of that is to check for the existence of the model object associated with the event. But of course In the case of this delete event (or any other delete event), the model object no longer exists, causing the security check to fail and for the event to not be published.

      Need to come up with some event specific way of indicating that it's OK to forward the event if the model object does not exist.

        Attachments

          Activity

          tfennelly Tom FENNELLY created issue -
          jamesdumay James Dumay made changes -
          Field Original Value New Value
          Labels blueocean
          jamesdumay James Dumay made changes -
          Epic Link JENKINS-35737 [ 171801 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-m8 [ 46 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9 [ 46 ] 1.0-japan-m9, 1.0-m10 [ 46, 66 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m10 [ 46, 66 ] 1.0-japan-m9 [ 46 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9 [ 46 ] 1.0-japan-m9, 1.0-m11 [ 46, 71 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11 [ 46, 71 ] 1.0-japan-m9, 1.0-m12 [ 46, 76 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m12 [ 46, 76 ] 1.0-japan-m9 [ 46 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9 [ 46 ] 1.0-japan-m9, 1.0-m12 [ 46, 76 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Priority Minor [ 4 ] Critical [ 2 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m12 [ 46, 76 ] 1.0-japan-m9 [ 46 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9 [ 46 ] 1.0-japan-m9, 1.0-m11 [ 46, 71 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11 [ 46, 71 ] 1.0-japan-m9, 1.0-m11, 1.0-m12 [ 46, 71, 76 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 171373 ] JNJira + In-Review [ 184278 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12 [ 46, 71, 76 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-beta-1 [ 46, 71, 76, 86 ]
          jamesdumay James Dumay made changes -
          Priority Critical [ 2 ] Major [ 3 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1 [ 46, 71, 76, 86 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-1 [ 46, 71, 76, 86, 96 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-1 [ 46, 71, 76, 86, 96 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1 [ 46, 71, 76, 86 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1 [ 46, 71, 76, 86 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-2 [ 46, 71, 76, 86, 101 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-4 [ 46, 71, 76, 86, 101 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-2 [ 46, 71, 76, 86, 111 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-2 [ 46, 71, 76, 86, 111 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1 [ 46, 71, 76, 86 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1 [ 46, 71, 76, 86 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-3 [ 46, 71, 76, 86, 101 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-b07/b08 [ 46, 71, 76, 86, 101 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, 1.0-beta-5 [ 46, 71, 76, 86, 106 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic [ 46, 71, 76, 86, 106 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, indian [ 46, 71, 76, 86, 106, 126 ]
          tfennelly Tom FENNELLY made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, indian [ 46, 71, 76, 86, 106, 126 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic [ 46, 71, 76, 86, 106 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic [ 46, 71, 76, 86, 106 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, arctic [ 46, 71, 76, 86, 106, 131 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          Hide
          jamesdumay James Dumay added a comment -

          Tom FENNELLY this one has been hanging around for quite a few sprints. Is it still valid?

          Show
          jamesdumay James Dumay added a comment - Tom FENNELLY this one has been hanging around for quite a few sprints. Is it still valid?
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, arctic [ 46, 71, 76, 86, 106, 131 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic [ 46, 71, 76, 86, 106 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic [ 46, 71, 76, 86, 106 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, tasman [ 46, 71, 76, 86, 106, 136 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, tasman [ 46, 71, 76, 86, 106, 136 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic [ 46, 71, 76, 86, 106 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Component/s blueocean-plugin [ 21481 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic [ 46, 71, 76, 86, 106 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, pannonian [ 46, 71, 76, 86, 106, 211 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, pannonian [ 46, 71, 76, 86, 106, 211 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, panthalassa [ 46, 71, 76, 86, 106, 221 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, panthalassa [ 46, 71, 76, 86, 106, 221 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, pannonian [ 46, 71, 76, 86, 106, 211 ]
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          jamesdumay James Dumay made changes -
          Sprint 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, pannonian [ 46, 71, 76, 86, 106, 211 ] 1.0-japan-m9, 1.0-m11, 1.0-m12, 1.0-pre-beta-1, atlantic, pannonian, iapetus [ 46, 71, 76, 86, 106, 211, 216 ]
          jamesdumay James Dumay made changes -
          Rank Ranked higher
          jamesdumay James Dumay made changes -
          Rank Ranked lower
          tfennelly Tom FENNELLY made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          tfennelly Tom FENNELLY added a comment -

          This is no longer an issue. I'm guessing we made some other changes at some point that made this go away. We are caching a ref to the deleted object, allowing the permission check to happen. Not entirely sure other than those events are going through fine now.

          Show
          tfennelly Tom FENNELLY added a comment - This is no longer an issue. I'm guessing we made some other changes at some point that made this go away. We are caching a ref to the deleted object, allowing the permission check to happen. Not entirely sure other than those events are going through fine now.
          tfennelly Tom FENNELLY made changes -
          Resolution Cannot Reproduce [ 5 ]
          Status In Progress [ 3 ] Closed [ 6 ]

            People

            Assignee:
            tfennelly Tom FENNELLY
            Reporter:
            tfennelly Tom FENNELLY
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: