-
Bug
-
Resolution: Fixed
-
Major
-
None
-
Platform: All, OS: All
-
Powered by SuggestiMate
When using a file parameter, and no file is selected in the build trigger view,
hudson should not 'touch' (create a zero-length) file at the location specified
in the parameter definition.
My use case is to use a file parameter to temporarily ovewrite a project file
that controls the build process. If I don't specify any file in the build page,
I don't want hudson to overwrite my default control file (coming from svn) with
a zero length one.
- is duplicated by
-
JENKINS-19183 File Parameter: Creates an empty file when no file is uploaded
-
- Resolved
-
- links to
[JENKINS-3539] File parameter, file is touched if no argument given
In LTS version 1.509.4 this works.
Version 1.532.2 and 1.555 touch the file again if no argument was given.
Probably caused by https://github.com/jenkinsci/jenkins/commit/4a95cc6f9269108e607077dc9fd57f06e4c9af26
Code changed in jenkins
User: Daniel Beck
Path:
core/src/main/java/hudson/model/FileParameterValue.java
test/src/test/java/hudson/model/ParametersTest.java
http://jenkins-ci.org/commit/jenkins/190f0b6faf8aa49a60f1d2177a0b51d7a5170c42
Log:
[FIXED JENKINS-3539] Prevent empty file creation if left empty
Code changed in jenkins
User: Daniel Beck
Path:
changelog.html
cli/pom.xml
cli/src/main/resources/hudson/cli/client/Messages_pt_BR.properties
core/pom.xml
core/src/main/java/hudson/ClassicPluginStrategy.java
core/src/main/java/hudson/ExtensionFinder.java
core/src/main/java/hudson/FilePath.java
core/src/main/java/hudson/Plugin.java
core/src/main/java/hudson/Util.java
core/src/main/java/hudson/cli/CLICommand.java
core/src/main/java/hudson/diagnosis/OldDataMonitor.java
core/src/main/java/hudson/init/InitStrategy.java
core/src/main/java/hudson/model/AbstractItem.java
core/src/main/java/hudson/model/AbstractModelObject.java
core/src/main/java/hudson/model/AbstractProject.java
core/src/main/java/hudson/model/Cause.java
core/src/main/java/hudson/model/Computer.java
core/src/main/java/hudson/model/FileParameterValue.java
core/src/main/java/hudson/model/FullDuplexHttpChannel.java
core/src/main/java/hudson/model/Items.java
core/src/main/java/hudson/model/Job.java
core/src/main/java/hudson/model/LoadStatistics.java
core/src/main/java/hudson/model/ManagementLink.java
core/src/main/java/hudson/model/Queue.java
core/src/main/java/hudson/model/Run.java
core/src/main/java/hudson/model/Slave.java
core/src/main/java/hudson/model/User.java
core/src/main/java/hudson/model/View.java
core/src/main/java/hudson/model/labels/LabelAtomProperty.java
core/src/main/java/hudson/model/labels/LabelAtomPropertyDescriptor.java
core/src/main/java/hudson/model/listeners/ItemListener.java
core/src/main/java/hudson/model/queue/Executables.java
core/src/main/java/hudson/model/queue/Tasks.java
core/src/main/java/hudson/node_monitors/AbstractDiskSpaceMonitor.java
core/src/main/java/hudson/scm/SCM.java
core/src/main/java/hudson/security/ACL.java
core/src/main/java/hudson/slaves/CloudSlaveRetentionStrategy.java
core/src/main/java/hudson/tasks/ArtifactArchiver.java
core/src/main/java/hudson/tasks/BatchFile.java
core/src/main/java/hudson/tasks/Fingerprinter.java
core/src/main/java/hudson/tasks/Shell.java
core/src/main/java/hudson/tools/AbstractCommandInstaller.java
core/src/main/java/hudson/tools/BatchCommandInstaller.java
core/src/main/java/hudson/tools/CommandInstaller.java
core/src/main/java/hudson/util/LineEndingConversion.java
core/src/main/java/hudson/util/ListBoxModel.java
core/src/main/java/hudson/util/jna/Advapi32.java
core/src/main/java/hudson/util/jna/SHELLEXECUTEINFO.java
core/src/main/java/hudson/util/jna/WINBASE.java
core/src/main/java/jenkins/management/ShutdownLink.java
core/src/main/java/jenkins/model/GlobalConfiguration.java
core/src/main/java/jenkins/model/Jenkins.java
core/src/main/java/jenkins/model/JenkinsLocationConfiguration.java
core/src/main/java/jenkins/util/ProgressiveRendering.java
core/src/main/resources/hudson/AboutJenkins/index_pt_BR.properties
core/src/main/resources/hudson/Messages_pt_BR.properties
core/src/main/resources/hudson/PluginManager/PluginCycleDependenciesMonitor/message_pt_BR.properties
core/src/main/resources/hudson/PluginManager/PluginUpdateMonitor/message_pt_BR.properties
core/src/main/resources/hudson/PluginManager/advanced_pt_BR.properties
core/src/main/resources/hudson/PluginManager/available_pt_BR.properties
core/src/main/resources/hudson/PluginManager/checkUpdates_pt_BR.properties
core/src/main/resources/hudson/PluginManager/installed_pt_BR.properties
core/src/main/resources/hudson/PluginManager/sites_pt_BR.properties
core/src/main/resources/hudson/PluginManager/table_pt_BR.properties
core/src/main/resources/hudson/PluginWrapper/thirdPartyLicenses_pt_BR.properties
core/src/main/resources/hudson/cli/Messages_pt_BR.properties
core/src/main/resources/hudson/diagnosis/Messages_fr.properties
core/src/main/resources/hudson/diagnosis/Messages_pt_BR.properties
core/src/main/resources/hudson/diagnosis/NullIdDescriptorMonitor/message_pt_BR.properties
core/src/main/resources/hudson/lifecycle/WindowsInstallerLink/_restart_pt_BR.properties
core/src/main/resources/hudson/logging/LogRecorder/index_pt_BR.properties
core/src/main/resources/hudson/logging/LogRecorderManager/levels_pt_BR.properties
core/src/main/resources/hudson/markup/EscapedMarkupFormatter/config_pt_BR.properties
core/src/main/resources/hudson/markup/Messages_pt_BR.properties
core/src/main/resources/hudson/model/AbstractBuild/index_pt_BR.properties
core/src/main/resources/hudson/model/AbstractBuild/tasks_pt_BR.properties
core/src/main/resources/hudson/model/AbstractItem/delete_pt_BR.properties
core/src/main/resources/hudson/model/AbstractItem/noWorkspace.jelly
core/src/main/resources/hudson/model/AbstractItem/noWorkspace_fr.properties
core/src/main/resources/hudson/model/AbstractItem/noWorkspace_pt_BR.properties
core/src/main/resources/hudson/model/AbstractProject/configure-common_pt_BR.properties
core/src/main/resources/hudson/model/AbstractProject/sidepanel_pt_BR.properties
core/src/main/resources/hudson/model/AbstractProject/wipeOutWorkspaceBlocked_pt_BR.properties
core/src/main/resources/hudson/model/BuildAuthorizationToken/config_fr.properties
core/src/main/resources/hudson/model/BuildAuthorizationToken/config_pt_BR.properties
core/src/main/resources/hudson/model/Computer/index_pt_BR.properties
core/src/main/resources/hudson/model/Computer/setOfflineCause_pt_BR.properties
core/src/main/resources/hudson/model/ComputerSet/configure_pt_BR.properties
core/src/main/resources/hudson/model/ComputerSet/index_pt_BR.properties
core/src/main/resources/hudson/model/Executor/causeOfDeath_pt_BR.properties
core/src/main/resources/hudson/model/FileParameterValue/value_pt_BR.properties
core/src/main/resources/hudson/model/Job/buildTimeTrend_pt_BR.properties
core/src/main/resources/hudson/model/Job/index_pt_BR.properties
core/src/main/resources/hudson/model/Job/rename_pt_BR.properties
core/src/main/resources/hudson/model/Job/requirePOST_pt_BR.properties
core/src/main/resources/hudson/model/Label/sidepanel_pt_BR.properties
core/src/main/resources/hudson/model/LoadStatistics/main.jelly
core/src/main/resources/hudson/model/Messages_fr.properties
core/src/main/resources/hudson/model/Messages_pt_BR.properties
core/src/main/resources/hudson/model/PasswordParameterDefinition/index.jelly
core/src/main/resources/hudson/model/Run/KeepLogBuildBadge/badge.jelly
core/src/main/resources/hudson/model/Run/delete-retry_pt_BR.properties
core/src/main/resources/hudson/model/Run/logKeep_pt_BR.properties
core/src/main/resources/hudson/model/RunParameterDefinition/config_pt_BR.properties
core/src/main/resources/hudson/model/TextParameterDefinition/config_pt_BR.properties
core/src/main/resources/hudson/model/UpdateCenter/index_pt_BR.properties
core/src/main/resources/hudson/model/User/index_pt_BR.properties
core/src/main/resources/hudson/model/User/sidepanel_pt_BR.properties
core/src/main/resources/hudson/model/View/People/index_pt_BR.properties
core/src/main/resources/hudson/model/View/configure_pt_BR.properties
core/src/main/resources/hudson/model/labels/LabelAtom/configure_pt_BR.properties
core/src/main/resources/hudson/node_monitors/Messages_pt_BR.properties
core/src/main/resources/hudson/os/solaris/ZFSInstaller/message_pt_BR.properties
core/src/main/resources/hudson/scheduler/Messages_pt_BR.properties
core/src/main/resources/hudson/search/Messages_pt_BR.properties
core/src/main/resources/hudson/search/UserSearchProperty/config_pt_BR.properties
core/src/main/resources/hudson/security/FederatedLoginService/UnclaimedIdentityException/error_pt_BR.properties
core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/_entryForm_pt_BR.properties
core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/config_pt_BR.properties
core/src/main/resources/hudson/security/Messages_fr.properties
core/src/main/resources/hudson/security/Messages_pt_BR.properties
core/src/main/resources/hudson/security/csrf/Messages_pt_BR.properties
core/src/main/resources/hudson/slaves/CommandConnector/config_pt_BR.properties
core/src/main/resources/hudson/slaves/DelegatingComputerLauncher/config_pt_BR.properties
core/src/main/resources/hudson/slaves/JNLPLauncher/main_pt_BR.properties
core/src/main/resources/hudson/slaves/Messages_pt_BR.properties
core/src/main/resources/hudson/slaves/SlaveComputer/log_pt_BR.properties
core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo_pt_BR.properties
core/src/main/resources/hudson/tasks/ArtifactArchiver/config_pt_BR.properties
core/src/main/resources/hudson/tasks/BuildTrigger/config_fr.properties
core/src/main/resources/hudson/tasks/BuildTrigger/config_pt_BR.properties
core/src/main/resources/hudson/tasks/Maven/MavenInstallation/config_fr.properties
core/src/main/resources/hudson/tasks/Maven/MavenInstallation/config_nl.properties
core/src/main/resources/hudson/tasks/Maven/MavenInstallation/config_ru.properties
core/src/main/resources/hudson/tasks/Maven/MavenInstallation/config_tr.properties
core/src/main/resources/hudson/tasks/Maven/config_pt_BR.properties
core/src/main/resources/hudson/tasks/Messages_pt_BR.properties
core/src/main/resources/hudson/tools/JDKInstaller/DescriptorImpl/enterCredential_pt_BR.properties
core/src/main/resources/hudson/tools/Messages_pt_BR.properties
core/src/main/resources/hudson/triggers/Messages_pt_BR.properties
core/src/main/resources/hudson/triggers/SCMTrigger/config_pt_BR.properties
core/src/main/resources/hudson/triggers/TimerTrigger/help_fr.html
core/src/main/resources/hudson/util/InsufficientPermissionDetected/index_pt_BR.properties
core/src/main/resources/hudson/util/JNADoublyLoaded/index_pt_BR.properties
core/src/main/resources/hudson/util/Messages_pt_BR.properties
core/src/main/resources/hudson/util/NoHomeDir/index_pt_BR.properties
core/src/main/resources/hudson/views/Messages_fr.properties
core/src/main/resources/hudson/views/StatusColumn/columnHeader.jelly
core/src/main/resources/hudson/views/StatusColumn/columnHeader_fr.properties
core/src/main/resources/hudson/views/WeatherColumn/columnHeader.jelly
core/src/main/resources/hudson/views/WeatherColumn/columnHeader_fr.properties
core/src/main/resources/jenkins/diagnosis/HsErrPidList/index_pt_BR.properties
core/src/main/resources/jenkins/diagnosis/HsErrPidList/message_pt_BR.properties
core/src/main/resources/jenkins/diagnostics/SecurityIsOffMonitor/message_fr.properties
core/src/main/resources/jenkins/diagnostics/SecurityIsOffMonitor/message_pt_BR.properties
core/src/main/resources/jenkins/diagnostics/ooom/Messages_pt_BR.properties
core/src/main/resources/jenkins/management/Messages_fr.properties
core/src/main/resources/jenkins/management/Messages_pt_BR.properties
core/src/main/resources/jenkins/model/Jenkins/MasterComputer/configure_pt_BR.properties
core/src/main/resources/jenkins/model/Jenkins/configure_pt_BR.properties
core/src/main/resources/jenkins/model/Jenkins/load-statistics_pt_BR.properties
core/src/main/resources/jenkins/model/Jenkins/manage.jelly
core/src/main/resources/jenkins/model/Jenkins/manage_pt_BR.properties
core/src/main/resources/jenkins/model/Jenkins/newView_pt_BR.properties
core/src/main/resources/jenkins/model/Jenkins/oops_pt_BR.properties
core/src/main/resources/jenkins/model/Jenkins/systemInfo_pt_BR.properties
core/src/main/resources/jenkins/model/Messages_pt_BR.properties
core/src/main/resources/jenkins/mvn/FilePathGlobalSettingsProvider/config_pt_BR.properties
core/src/main/resources/jenkins/mvn/FilePathSettingsProvider/config_pt_BR.properties
core/src/main/resources/jenkins/mvn/Messages_pt_BR.properties
core/src/main/resources/jenkins/security/Messages_pt_BR.properties
core/src/main/resources/jenkins/slaves/systemInfo/Messages_pt_BR.properties
core/src/main/resources/jenkins/triggers/Messages_fr.properties
core/src/main/resources/jenkins/triggers/Messages_pt_BR.properties
core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/config_fr.properties
core/src/main/resources/jenkins/triggers/ReverseBuildTrigger/config_pt_BR.properties
core/src/main/resources/lib/form/descriptorList.jelly
core/src/main/resources/lib/form/helpLink_pt_BR.properties
core/src/main/resources/lib/form/link.jelly
core/src/main/resources/lib/form/link/link.js
core/src/main/resources/lib/form/repeatableHeteroProperty.jelly
core/src/main/resources/lib/hudson/artifactList_pt_BR.properties
core/src/main/resources/lib/hudson/buildHealth.jelly
core/src/main/resources/lib/hudson/executors_pt_BR.properties
core/src/main/resources/lib/hudson/listScmBrowsers.jelly
core/src/main/resources/lib/hudson/project/config-assignedLabel.jelly
core/src/main/resources/lib/hudson/project/config-assignedLabel_pt_BR.properties
core/src/main/resources/lib/hudson/project/config-blockWhenDownstreamBuilding.jelly
core/src/main/resources/lib/hudson/project/config-blockWhenUpstreamBuilding.jelly
core/src/main/resources/lib/hudson/project/config-concurrentBuild.jelly
core/src/main/resources/lib/hudson/project/config-customWorkspace.jelly
core/src/main/resources/lib/hudson/project/config-disableBuild.jelly
core/src/main/resources/lib/hudson/project/config-disableBuild_fr.properties
core/src/main/resources/lib/hudson/project/config-publishers2_pt_BR.properties
core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
core/src/main/resources/lib/hudson/project/config-quietPeriod_pt_BR.properties
core/src/main/resources/lib/hudson/project/config-retryCount.jelly
core/src/main/resources/lib/hudson/project/config-scm_pt_BR.properties
core/src/main/resources/lib/hudson/project/config-upstream-pseudo-trigger_pt_BR.properties
core/src/main/resources/lib/hudson/queue.jelly
core/src/main/resources/lib/hudson/queue_pt_BR.properties
core/src/main/resources/lib/hudson/scriptConsole_pt_BR.properties
core/src/main/resources/lib/layout/copyButton/copyButton.css
core/src/main/resources/lib/layout/copyButton/copyButton.js
core/src/main/resources/lib/layout/layout_pt_BR.properties
core/src/main/resources/lib/layout/progressiveRendering.jelly
core/src/main/resources/lib/layout/progressiveRendering/progressiveRendering.js
core/src/test/java/hudson/FunctionsTest.java
core/src/test/java/hudson/MarkupTextTest.java
core/src/test/java/hudson/UtilTest.java
core/src/test/java/hudson/console/UrlAnnotatorTest.java
debian/debian/changelog
debian/debian/jenkins.default
debian/debian/jenkins.init
opensuse/readme.html
plugins/pom.xml
pom.xml
rpm/SOURCES/jenkins.init.in
rpm/SOURCES/jenkins.logrotate
test/pom.xml
test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
test/src/main/resources/org/jvnet/hudson/test/ComputerConnectorTester/configure_pt_BR.properties
test/src/main/resources/org/jvnet/hudson/test/SleepBuilder/config_pt_BR.properties
test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
test/src/test/java/hudson/PluginTest.java
test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java
test/src/test/java/hudson/model/ItemsTest.java
test/src/test/java/hudson/model/LabelLoadStatisticsQueueLengthTest.java
test/src/test/java/hudson/model/ListViewTest.java
test/src/test/java/hudson/model/ParametersTest.java
test/src/test/java/hudson/model/ProjectTest.java
test/src/test/java/hudson/model/labels/LabelExpressionTest.java
test/src/test/java/hudson/security/CliAuthenticationTest.java
test/src/test/java/hudson/tasks/BatchFileTest.java
test/src/test/java/hudson/tasks/ShellTest.java
test/src/test/java/hudson/tools/BatchCommandInstallerTest.java
test/src/test/java/hudson/tools/CommandInstallerTest.java
test/src/test/java/hudson/util/LineEndingConversionTest.java
war/pom.xml
war/src/main/webapp/WEB-INF/web.xml
war/src/main/webapp/css/style.css
war/src/main/webapp/scripts/hudson-behavior.js
war/src/realm.properties
http://jenkins-ci.org/commit/jenkins/d5d47edae4afd8491b1eac8b3bef6adb3ca0c5b6
Log:
Merge branch 'master' of https://github.com/jenkinsci/jenkins into JENKINS-3539
Conflicts:
test/src/test/java/hudson/model/ParametersTest.java
Code changed in jenkins
User: Oleg Nenashev
Path:
core/src/main/java/hudson/model/FileParameterValue.java
test/src/test/java/hudson/model/ParametersTest.java
http://jenkins-ci.org/commit/jenkins/0a217ea71b0d33c12d5d841ffea68f7d7acdaa8b
Log:
Merge pull request #1428 from daniel-beck/JENKINS-3539
[FIXED JENKINS-3539] Prevent empty file creation if left empty
Compare: https://github.com/jenkinsci/jenkins/compare/d6f758af6471...0a217ea71b0d
Integrated in jenkins_main_trunk #3752
[FIXED JENKINS-3539] Prevent empty file creation if left empty (Revision 190f0b6faf8aa49a60f1d2177a0b51d7a5170c42)
Result = SUCCESS
daniel-beck : 190f0b6faf8aa49a60f1d2177a0b51d7a5170c42
Files :
- core/src/main/java/hudson/model/FileParameterValue.java
- test/src/test/java/hudson/model/ParametersTest.java
I also noticed that when an upstream project triggers the build of a downstream
project, which has a file parameter, it works as expected, i.e. no file is touched.