Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35450

Rename environment variable: JENKINS_SLAVE_AGENT_PORT to JENKINS_AGENT_PORT

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • core

      Found while using Jenkins 2.6 docker container, so it needs to be fixed both there and in core.

          [JENKINS-35450] Rename environment variable: JENKINS_SLAVE_AGENT_PORT to JENKINS_AGENT_PORT

          Liam Newman created issue -
          Liam Newman made changes -
          Link New: This issue is related to JENKINS-35449 [ JENKINS-35449 ]
          Liam Newman made changes -
          Link New: This issue is related to JENKINS-31095 [ JENKINS-31095 ]

          Oleg Nenashev added a comment -

          This change will be incompatible. -1, needs a better design

          Oleg Nenashev added a comment - This change will be incompatible. -1, needs a better design

          Liam Newman added a comment -

          oleg_nenashev How about providing both vars for a while with at task for removing the "slave" one in six months? Is eternal backward compat required?

          Liam Newman added a comment - oleg_nenashev How about providing both vars for a while with at task for removing the "slave" one in six months? Is eternal backward compat required?

          Liam Newman added a comment -

          The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

          I understand that env vars are effectively part of the API and so changing them is problematic and could be considered out of scope.   But they are also part of the end-user experience (the UI) for every Jenkins user.

          Liam Newman added a comment - The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers. I understand that env vars are effectively part of the API and so changing them is problematic and could be considered out of scope.   But they are also part of the end-user experience (the UI) for every Jenkins user.
          Oleg Nenashev made changes -
          Issue Type Original: Bug [ 1 ] New: Improvement [ 4 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 171747 ] New: JNJira + In-Review [ 184449 ]
          Liam Newman made changes -
          Epic Link New: JENKINS-42816 [ 179816 ]
          Oleg Nenashev made changes -
          Labels New: terminology

            Unassigned Unassigned
            bitwiseman Liam Newman
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: