Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35452

Change Jnlp url from "slave-agent.jnlp" to "agent.jnlp"

    XMLWordPrintable

    Details

    • Similar Issues:
    • Released As:
      Jenkins 2.264

      Description

      Found when launching a jnlp agent from command line:

      "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

      The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".

      The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

      I understand that filenames and urls are effectively part of the API and so changing them is problematic and could be considered out of scope.   But filenames and urls are also part of the end-user experience (the UI) for every Jenkins user. And the files and urls related to adding an agent are some of the first and most commonly used.

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Not a bug.
            As a remoting maintainer I do not plan to work on it. The people responsible for the slave=>agent renaming decision implementation should drive it

            Show
            oleg_nenashev Oleg Nenashev added a comment - Not a bug. As a remoting maintainer I do not plan to work on it. The people responsible for the slave=>agent renaming decision implementation should drive it
            Hide
            annetheagile AnneTheAgile added a comment -

            Oleg Nenashev the places to be changed would be found by this query, am I correct?

            https://github.com/jenkinsci/remoting/search?utf8=%E2%9C%93&q=slave&type=

            Show
            annetheagile AnneTheAgile added a comment - Oleg Nenashev the places to be changed would be found by this query, am I correct? https://github.com/jenkinsci/remoting/search?utf8=%E2%9C%93&q=slave&type=
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            The fix has been released in Jenkins 2.264 . I will tag it as lts candidate so that we consider backporting to 2.263.1

            Show
            oleg_nenashev Oleg Nenashev added a comment - The fix has been released in Jenkins 2.264 . I will tag it as lts candidate so that we consider backporting to 2.263.1
            Hide
            olivergondza Oliver Gondža added a comment -

            Not including into 2.263.1 as the fix is pending polishing. https://github.com/jenkinsci/jenkins/pull/5062#discussion_r527650862

            Show
            olivergondza Oliver Gondža added a comment - Not including into 2.263.1 as the fix is pending polishing. https://github.com/jenkinsci/jenkins/pull/5062#discussion_r527650862

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              bitwiseman Liam Newman
              Votes:
              4 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: