Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35452

Change Jnlp url from "slave-agent.jnlp" to "agent.jnlp"

    • Jenkins 2.264 and 2.277.1

      Found when launching a jnlp agent from command line:

      "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

      The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".

      The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

      I understand that filenames and urls are effectively part of the API and so changing them is problematic and could be considered out of scope.   But filenames and urls are also part of the end-user experience (the UI) for every Jenkins user. And the files and urls related to adding an agent are some of the first and most commonly used.

          [JENKINS-35452] Change Jnlp url from "slave-agent.jnlp" to "agent.jnlp"

          Liam Newman created issue -
          Liam Newman made changes -
          Link New: This issue is related to JENKINS-35451 [ JENKINS-35451 ]
          Liam Newman made changes -
          Link New: This issue is related to JENKINS-35449 [ JENKINS-35449 ]
          Liam Newman made changes -
          Link New: This issue is related to JENKINS-31095 [ JENKINS-31095 ]
          Liam Newman made changes -
          Description Original: Found when launching a jnlp agent from command line:

          "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

          The name of this file should match agreed naming guidelines.
          New: Found when launching a jnlp agent from command line:

          "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

          The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".
          Liam Newman made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          Liam Newman made changes -
          Description Original: Found when launching a jnlp agent from command line:

          "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

          The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".
          New: Found when launching a jnlp agent from command line:

          "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

          The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".

          The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

          I understand that filenames and urls are effectively part of the API and so changing them is problematic and could be considered out of scope.   But filenames and urls are also part of the end-user experience (the UI) for every Jenkins user. And the files and urls related to adding an agent are some of the first and most commonly used.
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 171749 ] New: JNJira + In-Review [ 184451 ]

          Oleg Nenashev added a comment -

          Not a bug.
          As a remoting maintainer I do not plan to work on it. The people responsible for the slave=>agent renaming decision implementation should drive it

          Oleg Nenashev added a comment - Not a bug. As a remoting maintainer I do not plan to work on it. The people responsible for the slave=>agent renaming decision implementation should drive it
          Oleg Nenashev made changes -
          Issue Type Original: Bug [ 1 ] New: Improvement [ 4 ]

            Unassigned Unassigned
            bitwiseman Liam Newman
            Votes:
            4 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: