Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35452

Change Jnlp url from "slave-agent.jnlp" to "agent.jnlp"

    XMLWordPrintable

Details

    • Jenkins 2.264 and 2.277.1

    Description

      Found when launching a jnlp agent from command line:

      "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

      The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".

      The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

      I understand that filenames and urls are effectively part of the API and so changing them is problematic and could be considered out of scope.   But filenames and urls are also part of the end-user experience (the UI) for every Jenkins user. And the files and urls related to adding an agent are some of the first and most commonly used.

      Attachments

        Issue Links

          Activity

            bitwiseman Liam Newman created issue -
            bitwiseman Liam Newman made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-35451 [ JENKINS-35451 ]
            bitwiseman Liam Newman made changes -
            Link This issue is related to JENKINS-35449 [ JENKINS-35449 ]
            bitwiseman Liam Newman made changes -
            Link This issue is related to JENKINS-31095 [ JENKINS-31095 ]
            bitwiseman Liam Newman made changes -
            Description Found when launching a jnlp agent from command line:

            "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

            The name of this file should match agreed naming guidelines.
            Found when launching a jnlp agent from command line:

            "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

            The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".
            bitwiseman Liam Newman made changes -
            Priority Minor [ 4 ] Major [ 3 ]
            bitwiseman Liam Newman made changes -
            Description Found when launching a jnlp agent from command line:

            "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

            The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".
            Found when launching a jnlp agent from command line:

            "java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

            The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".

            The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

            I understand that filenames and urls are effectively part of the API and so changing them is problematic and could be considered out of scope.   But filenames and urls are also part of the end-user experience (the UI) for every Jenkins user. And the files and urls related to adding an agent are some of the first and most commonly used.
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 171749 ] JNJira + In-Review [ 184451 ]
            oleg_nenashev Oleg Nenashev made changes -
            Issue Type Bug [ 1 ] Improvement [ 4 ]
            bitwiseman Liam Newman made changes -
            Epic Link JENKINS-42816 [ 179816 ]
            oleg_nenashev Oleg Nenashev made changes -
            Released As Jenkins 2.264
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            oleg_nenashev Oleg Nenashev made changes -
            Labels lts-candidate
            olivergondza Oliver Gondža made changes -
            Labels lts-candidate 2.263.1-fixed
            olivergondza Oliver Gondža made changes -
            Labels 2.263.1-fixed 2.263.1-rejected
            markewaite Mark Waite made changes -
            Status Resolved [ 5 ] Closed [ 6 ]
            markewaite Mark Waite made changes -
            Released As Jenkins 2.264 Jenkins 2.264 and 2.277.1
            oleg_nenashev Oleg Nenashev made changes -
            Labels 2.263.1-rejected 2.263.1-rejected terminology

            People

              Unassigned Unassigned
              bitwiseman Liam Newman
              Votes:
              4 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: