Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35516

Loading user details throws bad exceptions

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Minor Minor
    • github-oauth-plugin
    • None

      loadUserByUsername has some issues that I can see.

      GithubAuthenticationToken authToken = (GithubAuthenticationToken) SecurityContextHolder.getContext().getAuthentication(); failes with class cast exception when an anonymous user is accessing. It should throw a UserNotFoundException for anonymous users I believe.

      Also, possibly when the github token has timed out and is invalid, the plugin does not redo the login. I'm pretty sure its failing in loadUserByUsername but I'm not totally sure. Will update if I find out.

          [JENKINS-35516] Loading user details throws bad exceptions

          Ivan Meredith added a comment -

          Nvm i was looking at wrong source code, it looks like that has been fixed... trying to figure out why we are setting this issue.

          Ivan Meredith added a comment - Nvm i was looking at wrong source code, it looks like that has been fixed... trying to figure out why we are setting this issue.

          Ivan Meredith added a comment -

          Confirmed this is fixed in latest version

          Ivan Meredith added a comment - Confirmed this is fixed in latest version

            sag47 Sam Gleske
            imeredith Ivan Meredith
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: