• Type: Story
• Resolution: Won't Fix
• Priority: Major
• Component/s: blueocean-plugin
• Labels:

  • blueocean
  • blueocean-imported

[JENKINS-35774] ExtensionPoint wrapper element should have a class

Collapse comment: Michael Neale added a comment - 2016-03-21 15:08

Michael Neale added a comment - 2016-03-21 15:08

tfennelly is this still needed?

Expand comment: Michael Neale added a comment - 2016-03-21 15:08

Michael Neale added a comment - 2016-03-21 15:08 tfennelly is this still needed?

Collapse comment: Josh McDonald added a comment - 2016-03-21 15:16

Josh McDonald added a comment - 2016-03-21 15:16

This doesn't seem like a good idea to me. If your specific extensionpoint needs a className, give it one. IMO ExtensionPoint should be as un-opinionated as possible.

Expand comment: Josh McDonald added a comment - 2016-03-21 15:16

Josh McDonald added a comment - 2016-03-21 15:16 This doesn't seem like a good idea to me. If your specific extensionpoint needs a className, give it one. IMO ExtensionPoint should be as un-opinionated as possible.

Collapse comment: Tom FENNELLY added a comment - 2016-03-22 04:16, Edited by Tom FENNELLY - 2016-03-22 04:17

Tom FENNELLY added a comment - 2016-03-22 04:16 - edited

I was referring to the <div> that ExtensionPoint.jsx adds (see its render function) to wrap the content being rendered from those specific extension point impls. The render functions adds those <div> elements and then the __renderAllExtensions converts them into the react leaf nodes and the specific extension point impl content gets dropped inside that div (or at least that is how I interpret it).

So if there's a way of getting rid of that wrapping div then that'd do the trick. As is, every extension point is a block displayed element.

Expand comment: Tom FENNELLY added a comment - 2016-03-22 04:16, Edited by Tom FENNELLY - 2016-03-22 04:17

Tom FENNELLY added a comment - 2016-03-22 04:16 - edited I was referring to the <div> that ExtensionPoint.jsx adds (see its render function) to wrap the content being rendered from those specific extension point impls. The render functions adds those <div> elements and then the __renderAllExtensions converts them into the react leaf nodes and the specific extension point impl content gets dropped inside that div (or at least that is how I interpret it). So if there's a way of getting rid of that wrapping div then that'd do the trick. As is, every extension point is a block displayed element.

Collapse comment: Josh McDonald added a comment - 2016-03-22 05:03

Josh McDonald added a comment - 2016-03-22 05:03

Right, I got you now, that's definitely a good idea. I think we might want to look at parameterising the TagName as well.

Expand comment: Josh McDonald added a comment - 2016-03-22 05:03

Josh McDonald added a comment - 2016-03-22 05:03 Right, I got you now, that's definitely a good idea. I think we might want to look at parameterising the TagName as well.