[JENKINS-35820] Developer sees the log broken down by step

Type: Story
Resolution: Fixed
Priority: Major
Component/s: blueocean-plugin
Labels:
- blueocean-imported
- japan

Similar Issues:
Powered by SuggestiMate

Show
Epic Link:
Log component
Sprint:
1.0-japan-m9

In Scope

For any node in the railway the developer can click on it and see a list of the steps that had executed for that node
Each step has a status (passed, failed or running)
Clicking on one of the steps expands the log in place.
On successful, aborted, unstable and unknown runs the developer sees all the steps in the log collapsed
On failed run the developer sees all the steps in the log collapsed but the failing step is expanded
On executing run the developer sees all the steps in the log collapsed but the currently executing step is expanded
Not in the mockup: 2px radius on the top and bottom un-expanded steps
Don't fetch the whole log into the browser memory ever (break the "download log" feature if needed)
Show full log in freestyle cases (no step by step break down) but without eagerly loading the whole multi MB log (should only load last 4K (ping Vivek), as jenkins console does now, with a link to "show full log" that then loads the rest. not test with other then pipeline and multibranch
When loading a log (for a step, or whole log for freestyle) and it only loads the last part, offer a link to "Show all" (as Jenkins does now)

Out of scope:

Tailing (~~UX-73~~)
Download load option
Open raw log in new tab (can lazily load from server) in all cases (reasonably formatter, nearly works already but missing newlines)

blocks

JENKINS-35841 Developer can tail the log of an executing stage

Resolved

JENKINS-35822 Developer can view an executing pipeline

Resolved

JENKINS-35886 Log detail link numbers should have a href

Resolved

Thorsten Scherler added a comment - 2016-05-25 12:57 - edited

mneale jdumay it states: On failed run the developer sees all the steps in the log collapsed but the failing step is expanded

what happens if multiple steps fail? Should be the first visible or all?

Thorsten Scherler added a comment - 2016-05-25 12:57 - edited mneale jdumay it states: On failed run the developer sees all the steps in the log collapsed but the failing step is expanded what happens if multiple steps fail? Should be the first visible or all?

Thorsten Scherler added a comment - 2016-05-25 13:11 - edited

There is IMO a problem with the response the REST server sends for running jobs, I recorded the following on a pipeline that has finished the first stage and was running the second:

export const firstFinishedSecondRunning = [
  {
    "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl",
    "displayName": "Stage 1",
    "durationInMillis": 10264,
    "edges": [
      {
        "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl",
        "id": "12"
      }
    ],
    "id": "5",
    "result": "SUCCESS",
    "startTime": "2016-05-25T13:47:40.534+0200",
    "state": "FINISHED"
  },
  {
    "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl",
    "displayName": "Stage 2",
    "durationInMillis": 7271,
    "edges": [
      {
        "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl",
        "id": "16"
      },
      {
        "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl",
        "id": "17"
      },
      {
        "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl",
        "id": "18"
      }
    ],
    "id": "12",
    "result": "UNKNOWN",
    "startTime": "2016-05-25T13:47:50.798+0200",
    "state": "RUNNING"
  },
  {
    "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl",
    "displayName": "firstBranch",
    "durationInMillis": 7269,
    "edges": [],
    "id": "16",
    "result": "SUCCESS",
    "startTime": "2016-05-25T13:47:50.800+0200",
    "state": "FINISHED"
  },
  {
    "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl",
    "displayName": "secondBranch",
    "durationInMillis": 7268,
    "edges": [],
    "id": "17",
    "result": "SUCCESS",
    "startTime": "2016-05-25T13:47:50.801+0200",
    "state": "FINISHED"
  },
  {
    "_class": "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl",
    "displayName": "thirdBranch",
    "durationInMillis": 7267,
    "edges": [],
    "id": "18",
    "result": "SUCCESS",
    "startTime": "2016-05-25T13:47:50.802+0200",
    "state": "FINISHED"
  }
]

As you can see 16-18 are edge jobs and since 12 is currently running they should not have yet a result and the state should be RUNNING. May be related to https://cloudbees.atlassian.net/browse/UX-505?focusedCommentId=37907&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-37907.

The real end result had been

Thorsten Scherler added a comment - 2016-05-25 13:11 - edited There is IMO a problem with the response the REST server sends for running jobs, I recorded the following on a pipeline that has finished the first stage and was running the second: export const firstFinishedSecondRunning = [ { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl" , "displayName" : "Stage 1" , "durationInMillis" : 10264, "edges" : [ { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl" , "id" : "12" } ], "id" : "5" , "result" : "SUCCESS" , "startTime" : "2016-05-25T13:47:40.534+0200" , "state" : "FINISHED" }, { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl" , "displayName" : "Stage 2" , "durationInMillis" : 7271, "edges" : [ { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl" , "id" : "16" }, { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl" , "id" : "17" }, { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl" , "id" : "18" } ], "id" : "12" , "result" : "UNKNOWN" , "startTime" : "2016-05-25T13:47:50.798+0200" , "state" : "RUNNING" }, { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl" , "displayName" : "firstBranch" , "durationInMillis" : 7269, "edges" : [], "id" : "16" , "result" : "SUCCESS" , "startTime" : "2016-05-25T13:47:50.800+0200" , "state" : "FINISHED" }, { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl" , "displayName" : "secondBranch" , "durationInMillis" : 7268, "edges" : [], "id" : "17" , "result" : "SUCCESS" , "startTime" : "2016-05-25T13:47:50.801+0200" , "state" : "FINISHED" }, { "_class" : "io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl" , "displayName" : "thirdBranch" , "durationInMillis" : 7267, "edges" : [], "id" : "18" , "result" : "SUCCESS" , "startTime" : "2016-05-25T13:47:50.802+0200" , "state" : "FINISHED" } ] As you can see 16-18 are edge jobs and since 12 is currently running they should not have yet a result and the state should be RUNNING. May be related to https://cloudbees.atlassian.net/browse/UX-505?focusedCommentId=37907&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-37907 . The real end result had been

Thorsten Scherler added a comment - 2016-05-25 13:26

jdumay an observation regarding the status symbols in front of the node log, we are introducing here a new set of status symbols, wouldn't it be better to reuse the ones from the activity view. This would IMO enhance the recognisability of the this statuses. I understand you are using the same as in the modalHeader, if we stay with that we should extract a new component from the modalHeader code generating the symbols and reuse them in the logNodes.

Thorsten Scherler added a comment - 2016-05-25 13:26 jdumay an observation regarding the status symbols in front of the node log, we are introducing here a new set of status symbols, wouldn't it be better to reuse the ones from the activity view. This would IMO enhance the recognisability of the this statuses. I understand you are using the same as in the modalHeader, if we stay with that we should extract a new component from the modalHeader code generating the symbols and reuse them in the logNodes.

Thorsten Scherler added a comment - 2016-05-25 13:42 - edited

[^screencast_00002.mp4] IMO if a job is failed and the last stage have not run it should not rotate, it will not be run never.

export const runNodesFail = [{
    '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl',
    displayName: 'Stage 1',
    durationInMillis: 10263,
    edges: [{
        '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl',
        id: '12'
    }],
    id: '5',
    result: 'SUCCESS',
    startTime: '2016-05-24T13:42:07.833+0200',
    state: 'FINISHED'
}, {
    '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl',
    displayName: 'Stage 2',
    durationInMillis: 22141,
    edges: [{
        '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl',
        id: '15'
    }, {
        '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl',
        id: '16'
    }],
    id: '12',
    result: 'FAILURE',
    startTime: '2016-05-24T13:42:18.096+0200',
    state: 'FINISHED'
}, {
    '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl',
    displayName: 'firstBranch',
    durationInMillis: 22074,
    edges: [{
        '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl',
        id: '28'
    }],
    id: '15',
    result: 'SUCCESS',
    startTime: '2016-05-24T13:42:18.098+0200',
    state: 'FINISHED'
}, {
    '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl',
    displayName: 'secondBranch',
    durationInMillis: 22076,
    edges: [{
        '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl',
        id: '28'
    }],
    id: '16',
    result: 'FAILURE',
    startTime: '2016-05-24T13:42:18.099+0200',
    state: 'FINISHED'
}, {
    '_class': 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl',
    displayName: 'deploy',
    durationInMillis: null,
    edges: [],
    id: '28',
    result: null,
    startTime: null,
    state: null
}];

Thorsten Scherler added a comment - 2016-05-25 13:42 - edited [^screencast_00002.mp4] IMO if a job is failed and the last stage have not run it should not rotate, it will not be run never. export const runNodesFail = [{ '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl' , displayName: 'Stage 1' , durationInMillis: 10263, edges: [{ '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl' , id: '12' }], id: '5' , result: 'SUCCESS' , startTime: '2016-05-24T13:42:07.833+0200' , state: 'FINISHED' }, { '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl' , displayName: 'Stage 2' , durationInMillis: 22141, edges: [{ '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl' , id: '15' }, { '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl' , id: '16' }], id: '12' , result: 'FAILURE' , startTime: '2016-05-24T13:42:18.096+0200' , state: 'FINISHED' }, { '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl' , displayName: 'firstBranch' , durationInMillis: 22074, edges: [{ '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl' , id: '28' }], id: '15' , result: 'SUCCESS' , startTime: '2016-05-24T13:42:18.098+0200' , state: 'FINISHED' }, { '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl' , displayName: 'secondBranch' , durationInMillis: 22076, edges: [{ '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl$EdgeImpl' , id: '28' }], id: '16' , result: 'FAILURE' , startTime: '2016-05-24T13:42:18.099+0200' , state: 'FINISHED' }, { '_class' : 'io.jenkins.blueocean.service.embedded.rest.PipelineNodeImpl' , displayName: 'deploy' , durationInMillis: null , edges: [], id: '28' , result: null , startTime: null , state: null }];

James Dumay added a comment - 2016-05-25 13:57

tscherler yes we are using the ones from the modal header right now. Circle filled with color vs status background color has to do with what the foreground contrast needs to be. If its white, on its own then we can use the circle variant. If we can't, its filled in and we use the modal header variant.

James Dumay added a comment - 2016-05-25 13:57 tscherler yes we are using the ones from the modal header right now. Circle filled with color vs status background color has to do with what the foreground contrast needs to be. If its white, on its own then we can use the circle variant. If we can't, its filled in and we use the modal header variant.

Michael Neale added a comment - 2016-05-25 14:48

tscherler use finished jobs for now, and then we may have to open other ticket for running states.

Michael Neale added a comment - 2016-05-25 14:48 tscherler use finished jobs for now, and then we may have to open other ticket for running states.

James Dumay added a comment - 2016-05-25 15:00

tscherler

On failed run the developer sees all the steps in the log collapsed but the failing step is expanded
what happens if multiple steps fail? Should be the first visible or all?

If this is referring to the graph, the first failure in the graph should be visible.

James Dumay added a comment - 2016-05-25 15:00 tscherler On failed run the developer sees all the steps in the log collapsed but the failing step is expanded what happens if multiple steps fail? Should be the first visible or all? If this is referring to the graph, the first failure in the graph should be visible.

Michael Neale added a comment - 2016-05-30 16:25

FYI I just added an in-scope (jdumay) as the log api is being corrected by vpandey to only load the last 4K - there will be a need for a user to "show all" in cases where there is a lot of back-log they want to view (as is the case in jenkins now).

Michael Neale added a comment - 2016-05-30 16:25 FYI I just added an in-scope ( jdumay ) as the log api is being corrected by vpandey to only load the last 4K - there will be a need for a user to "show all" in cases where there is a lot of back-log they want to view (as is the case in jenkins now).

Thorsten Scherler added a comment - 2016-05-31 01:33

https://github.com/jenkinsci/blueocean-plugin/pull/212/files#diff-ee06b67a788e43a3e9215a1940ab804fR546

We should simply change that to
`const logUrl = calculateLogUrl(config) + config.fullLog ? ' ?start=0' : '';`

Thorsten Scherler added a comment - 2016-05-31 01:33 https://github.com/jenkinsci/blueocean-plugin/pull/212/files#diff-ee06b67a788e43a3e9215a1940ab804fR546 We should simply change that to `const logUrl = calculateLogUrl(config) + config.fullLog ? ' ?start=0' : '';`

Josh McDonald added a comment - 2016-06-09 22:31

Layout-only component:

Josh McDonald added a comment - 2016-06-09 22:31 Layout-only component:

Assignee:: Thorsten Scherler

Reporter:: James Dumay

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Created:: 2016-05-08 13:49

Updated:: 2016-06-15 08:31

Resolved:: 2016-06-15 08:31

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Thorsten Scherler added a comment - 2016-05-25 12:57, Edited by Thorsten Scherler - 2016-05-25 13:29

Expand comment: Thorsten Scherler added a comment - 2016-05-25 12:57, Edited by Thorsten Scherler - 2016-05-25 13:29

Collapse comment: Thorsten Scherler added a comment - 2016-05-25 13:11, Edited by Thorsten Scherler - 2016-05-25 13:28

Expand comment: Thorsten Scherler added a comment - 2016-05-25 13:11, Edited by Thorsten Scherler - 2016-05-25 13:28

Collapse comment: Thorsten Scherler added a comment - 2016-05-25 13:26

Expand comment: Thorsten Scherler added a comment - 2016-05-25 13:26

Collapse comment: Thorsten Scherler added a comment - 2016-05-25 13:42, Edited by Thorsten Scherler - 2016-05-25 13:43

Expand comment: Thorsten Scherler added a comment - 2016-05-25 13:42, Edited by Thorsten Scherler - 2016-05-25 13:43

Collapse comment: James Dumay added a comment - 2016-05-25 13:57

Expand comment: James Dumay added a comment - 2016-05-25 13:57

Collapse comment: Michael Neale added a comment - 2016-05-25 14:48

Expand comment: Michael Neale added a comment - 2016-05-25 14:48

Collapse comment: James Dumay added a comment - 2016-05-25 15:00

Expand comment: James Dumay added a comment - 2016-05-25 15:00

Collapse comment: Michael Neale added a comment - 2016-05-30 16:25

Expand comment: Michael Neale added a comment - 2016-05-30 16:25

Collapse comment: Thorsten Scherler added a comment - 2016-05-31 01:33

Expand comment: Thorsten Scherler added a comment - 2016-05-31 01:33

Collapse comment: Josh McDonald added a comment - 2016-06-09 22:31

Expand comment: Josh McDonald added a comment - 2016-06-09 22:31

People

Dates