Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35843

Pull requests from branches (not forks) should show up as pull requests

XMLWordPrintable

    • 1.0-m11

      In scope

      Notes
      Currently, all branches are built in a multibranch pipeline project. When a pull request is opened from one branch to master, Jenkins doesn't pick this up as a new build (as it has already built the branch).

      Blue ocean however NEEDS to present this as a PR. Not clear how or where to solve this. When a PR is opened that is a human event implying that attention is now needed, however, with multibranch, no build should be triggered (as it already would have been with the branch).

      Perhaps blue ocean needs to note that a given branch also has a PR open and present it differently (but doesn't explain how it will live-update the UI when PR is opened, but perhaps that is a ticket for another day...)

          [JENKINS-35843] Pull requests from branches (not forks) should show up as pull requests

          Michael Neale added a comment -

          This ticket: https://issues.jenkins-ci.org/browse/JENKINS-33161

          tracks a feature whereby both the branch is built and the PR is built as a speculative merge commit with the master branch.

          This brings it up to parity with pull requests from forks.

          Michael Neale added a comment - This ticket: https://issues.jenkins-ci.org/browse/JENKINS-33161 tracks a feature whereby both the branch is built and the PR is built as a speculative merge commit with the master branch. This brings it up to parity with pull requests from forks.

          Michael Neale added a comment -

          I think this could be kept as a tracking ticket for OSS, I don't think we want to solve this in a blue ocean specific way unless there is pressure for this feature.

          Michael Neale added a comment - I think this could be kept as a tracking ticket for OSS, I don't think we want to solve this in a blue ocean specific way unless there is pressure for this feature.

          Jesse Glick added a comment -

          I think obsolete.

          Jesse Glick added a comment - I think obsolete.

          James Dumay added a comment -

          jglick not obsolete - this ticket is for blue ocean to verify and upgrade dependencies

          James Dumay added a comment - jglick not obsolete - this ticket is for blue ocean to verify and upgrade dependencies

          James Dumay added a comment -

          Github branch source 1.8 has been released https://github.com/jenkinsci/github-branch-source-plugin/commit/949791b2c99fcfffab1899975350ce0fb1600e26

          James Dumay added a comment - Github branch source 1.8 has been released https://github.com/jenkinsci/github-branch-source-plugin/commit/949791b2c99fcfffab1899975350ce0fb1600e26

          Michael Neale added a comment -

          as pointed out by imeredith (and as forgotten by me) - github does not send events for PRs as they open from an origin, so this acts as a bit of a dampener. They will show up as PRs but only when the data is fetched. Opening an origin PR doesn't seem to trigger a webhook from github.

          Michael Neale added a comment - as pointed out by imeredith (and as forgotten by me) - github does not send events for PRs as they open from an origin, so this acts as a bit of a dampener. They will show up as PRs but only when the data is fetched. Opening an origin PR doesn't seem to trigger a webhook from github.

            imeredith Ivan Meredith
            jamesdumay James Dumay
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: