Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35847

Developer should see a condensed version of the change summary

    • 1.0-m6, 1.0-m7, 1.0-pre-beta-1, 1.0-beta-1

      • If the "Changes" line in the summary header overflows it should show "X changes" where X is the number of changes

          [JENKINS-35847] Developer should see a condensed version of the change summary

          James Dumay added a comment -

          jmcdonald I believe tscherler had some difficulty figuring this one out so Ill assign to you for the next sprint.

          James Dumay added a comment - jmcdonald I believe tscherler had some difficulty figuring this one out so Ill assign to you for the next sprint.

          jdumay I do not recall having problems there (it is working in master), the underlying problem is the data, the full name is what you see on the screenshot, it is not coming as Thorsten Scherler from the backend.

          However if you refer to the "X changes" where X is the number of changes -> the problem is that is not possible without doing calculation in js. See https://github.com/cloudbees/blueocean/pull/125#issuecomment-211431309

          {{@i386 I am not sure how to archive to change the text when text-overflow is detected.
          https://developer.mozilla.org/en/docs/Web/CSS/text-overflow I can use only basic support since the string option is only working in firefox and the bigger problem is that not the whole content will be replaced but only the overfloating part.}}

          Basically we need something like https://github.com/contra/react-responsive to change the content. jdumay I can do this issue just it did not fit in the PR where it was raised at that time.

          Thorsten Scherler added a comment - jdumay I do not recall having problems there (it is working in master), the underlying problem is the data, the full name is what you see on the screenshot, it is not coming as Thorsten Scherler from the backend. However if you refer to the "X changes" where X is the number of changes -> the problem is that is not possible without doing calculation in js. See https://github.com/cloudbees/blueocean/pull/125#issuecomment-211431309 {{@i386 I am not sure how to archive to change the text when text-overflow is detected. https://developer.mozilla.org/en/docs/Web/CSS/text-overflow I can use only basic support since the string option is only working in firefox and the bigger problem is that not the whole content will be replaced but only the overfloating part.}} Basically we need something like https://github.com/contra/react-responsive to change the content. jdumay I can do this issue just it did not fit in the PR where it was raised at that time.

          James Dumay added a comment -

          Oh right my apologies Thorston - feel free to assign this one to yourself
          On Mon, Apr 25, 2016 at 7:22 PM, Thorsten Scherler (JIRA) <


          James Dumay
          Product Manager
          CloudBees, Inc.
          Skype: ap_myskype Twitter: i386

          James Dumay added a comment - Oh right my apologies Thorston - feel free to assign this one to yourself On Mon, Apr 25, 2016 at 7:22 PM, Thorsten Scherler (JIRA) < – James Dumay Product Manager CloudBees, Inc. Skype: ap_myskype Twitter: i386

          no apologies needed, just trying to explain the underlying problematic of the change set.

          Thorsten Scherler added a comment - no apologies needed, just trying to explain the underlying problematic of the change set.

          James Dumay added a comment -

          No worries - this ticket can wait until the next sprint
          On Mon, Apr 25, 2016 at 7:29 PM, Thorsten Scherler (JIRA) <


          James Dumay
          Product Manager
          CloudBees, Inc.
          Skype: ap_myskype Twitter: i386

          James Dumay added a comment - No worries - this ticket can wait until the next sprint On Mon, Apr 25, 2016 at 7:29 PM, Thorsten Scherler (JIRA) < – James Dumay Product Manager CloudBees, Inc. Skype: ap_myskype Twitter: i386

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          package.json
          src/main/js/api/git.js
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          src/test/js/edgeCases/folder.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/d8528c200f68632e75b77a016541a0975c29df8b
          Log:
          JENKINS-35847 Refactor gitCommit to return a promise. Add tests for notSet, condensed and notCondensed for a.authors

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: package.json src/main/js/api/git.js src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/edgeCases/folder.js http://jenkins-ci.org/commit/blueocean-acceptance-test/d8528c200f68632e75b77a016541a0975c29df8b Log: JENKINS-35847 Refactor gitCommit to return a promise. Add tests for notSet, condensed and notCondensed for a.authors

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/97e9bd70c6f7807266b823c24fab5f15d7133416
          Log:
          Merge remote-tracking branch 'origin/master' into JENKINS-35847

          Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/d8528c200f68...97e9bd70c6f7

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: src/main/js/page_objects/blueocean/bluePipelineRunDetail.js http://jenkins-ci.org/commit/blueocean-acceptance-test/97e9bd70c6f7807266b823c24fab5f15d7133416 Log: Merge remote-tracking branch 'origin/master' into JENKINS-35847 Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/d8528c200f68...97e9bd70c6f7

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          package.json
          src/main/js/api/git.js
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          src/test/js/edgeCases/folder.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/b587c8baea42c97ae32e13fbc02662a3ab20bac7
          Log:
          FIX Jenkins-35847 (#28)

          • Added git api for creating local git repos for testing
          • stash
          • JENKINS-36660 WIP implementing creation of folder and a freestyle project within the nested path.
          • JENKINS-36660 WIP waiting for ever when uncommenting, seems that sse is not getting informed
          • JENKINS-36660 Extending multibranch AT implementing creation of job
          • JENKINS-36660 Add fixme note so tom knows where the problems lies
          • JENKINS-36660 first working version of creating multibranch in folders
          • JENKINS-36660 add more test to cover various regressions. The close modal test is breaking my balls though since the opener url is equal to the current location but only in AT.
          • JENKINS-36660 Implement regression testing for all tabs when they should show data. Add commit script for the git repo.
          • JENKINS-36660 make sure we do not start without wait for finish
          • JENKINS-36660 Start test for pressing run button. add test to validate activities. move clickTab and related code to url util class
          • JENKINS-36660 Implement check for runButton and start working on queued state
          • JENKINS-36660 WIP queued state testing, infrastructure code to set executors
          • JENKINS-36660 using async series to make sure the changeset has passed before doing next step
          • JENKINS-36660 prepare for merge with current master, Disable tests as long ticket is open,
          • JENKINS-35847 Refactor gitCommit to return a promise. Add tests for notSet, condensed and notCondensed for a.authors

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: package.json src/main/js/api/git.js src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/edgeCases/folder.js http://jenkins-ci.org/commit/blueocean-acceptance-test/b587c8baea42c97ae32e13fbc02662a3ab20bac7 Log: FIX Jenkins-35847 (#28) Added git api for creating local git repos for testing stash JENKINS-36660 WIP implementing creation of folder and a freestyle project within the nested path. JENKINS-36660 WIP remove obsolete variable JENKINS-36660 WIP waiting for ever when uncommenting, seems that sse is not getting informed JENKINS-36660 Add tests for JENKINS-36618 JENKINS-36660 Extending multibranch AT implementing creation of job JENKINS-36660 Add fixme note so tom knows where the problems lies JENKINS-36660 first working version of creating multibranch in folders JENKINS-36660 fix class name JENKINS-36660 add more test to cover various regressions. The close modal test is breaking my balls though since the opener url is equal to the current location but only in AT. JENKINS-36660 Implement regression testing for all tabs when they should show data. Add commit script for the git repo. JENKINS-36660 remove legacy folder JENKINS-36660 fix renamed methood JENKINS-36660 make sure we do not start without wait for finish JENKINS-36660 Start test for pressing run button. add test to validate activities. move clickTab and related code to url util class JENKINS-36660 Implement check for runButton and start working on queued state JENKINS-36660 WIP queued state testing, infrastructure code to set executors JENKINS-36660 Implement checks for queued jobs JENKINS-36660 using async series to make sure the changeset has passed before doing next step JENKINS-36660 make sure we reset the executors JENKINS-36660 prepare for merge with current master, Disable tests as long ticket is open, JENKINS-35847 Refactor gitCommit to return a promise. Add tests for notSet, condensed and notCondensed for a.authors

            tscherler Thorsten Scherler
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: