Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35858

admin - the redux store expose currentX we should drop that and use a pointer to the runs array

    XMLWordPrintable

    Details

    • Similar Issues:
    • Epic Link:

      Description

      logically ... the runs in "currentRuns" must also exist under "runs". The currentRuns is more a helper for the view, but we should just use a pointer in the array as currentRuns selector and not a state variable.

      https://github.com/reactjs/reselect#accessing-react-props-in-selectors

      [ACTION_TYPES.GET_CURRENT_RUN_DATA](state, props,

      { payload }

      ): State

      { const currentRuns = state.get('runs'); return currentRuns[props.pipeline]; }

      ,

        Attachments

          Activity

          There are no comments yet on this issue.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: