Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35975

Configurable relativePath within the Disk Pool for a job

XMLWordPrintable

    • [GSoC] Sprint 1, [GSoC] Sprint 2

      When allocating the workspace using exwsAllocate step, provide a unique workspace for each Pull Request. So the allocated workspace path on the disk shall be like: $physicalPathOnDisk/$jobName/$pullRequestNumber/$buildNumber

      Additional details.

      • The relative path is configurable within Build DSL
      • [Nice2have]: Be able to specify path in the template. Maybe complicated, because for template we may need to resolve build environment variables
      • Workspace cleanup should work properly with such workspaces
      • Plugin should prevent workspace collisions (for example $physicalPathOnDisk/$jobName/A and $physicalPathOnDisk/$jobName/A/B)

      Reference: https://github.com/martinda/external-workspace-manager/blob/master/README.md#advanced-usage-git-pull-request

          [JENKINS-35975] Configurable relativePath within the Disk Pool for a job

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/7538a13e6ff332f60dfaf5ca0bdf287a484b1837
          Log:
          JENKINS-35975 Write tests for the custom workspace feature

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java http://jenkins-ci.org/commit/external-workspace-manager-plugin/7538a13e6ff332f60dfaf5ca0bdf287a484b1837 Log: JENKINS-35975 Write tests for the custom workspace feature

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/20abc7d8566f696d51b7213d94a7504313d76e5d
          Log:
          JENKINS-35975 Add tests when the custom workspace is not a relative path

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java http://jenkins-ci.org/commit/external-workspace-manager-plugin/20abc7d8566f696d51b7213d94a7504313d76e5d Log: JENKINS-35975 Add tests when the custom workspace is not a relative path

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          README.md
          doc/CUSTOM_WORKSPACE_PATH.md
          doc/img/global-workspace-template.png
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/ef22c34ab6a819bfb93d38dc22778ca9b53454c3
          Log:
          JENKINS-35975 Write documentation for global workspace template

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: README.md doc/CUSTOM_WORKSPACE_PATH.md doc/img/global-workspace-template.png http://jenkins-ci.org/commit/external-workspace-manager-plugin/ef22c34ab6a819bfb93d38dc22778ca9b53454c3 Log: JENKINS-35975 Write documentation for global workspace template

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          doc/CUSTOM_WORKSPACE_PATH.md
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/75ed3a71342bf02bd40aabae9c2c4e2a9c3af555
          Log:
          JENKINS-35975 Complete documentation with custom workspace path definition

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: doc/CUSTOM_WORKSPACE_PATH.md http://jenkins-ci.org/commit/external-workspace-manager-plugin/75ed3a71342bf02bd40aabae9c2c4e2a9c3af555 Log: JENKINS-35975 Complete documentation with custom workspace path definition

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          src/main/resources/org/jenkinsci/plugins/ewm/definitions/DiskPool/help-workspaceTemplate.html
          src/main/resources/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep/help-path.html
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/185f92feacf95e39ea505b0d65a846b3b4f16426
          Log:
          JENKINS-35975 Improve help files

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: src/main/resources/org/jenkinsci/plugins/ewm/definitions/DiskPool/help-workspaceTemplate.html src/main/resources/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep/help-path.html http://jenkins-ci.org/commit/external-workspace-manager-plugin/185f92feacf95e39ea505b0d65a846b3b4f16426 Log: JENKINS-35975 Improve help files

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          src/main/java/org/jenkinsci/plugins/ewm/definitions/Disk.java
          src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java
          src/main/java/org/jenkinsci/plugins/ewm/definitions/Template.java
          src/main/java/org/jenkinsci/plugins/ewm/nodes/DiskNode.java
          src/main/java/org/jenkinsci/plugins/ewm/nodes/ExternalWorkspaceProperty.java
          src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep.java
          src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java
          src/test/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStepTest.java
          src/test/java/org/jenkinsci/plugins/ewm/steps/ExwsStepTest.java
          src/test/java/org/jenkinsci/plugins/ewm/steps/WorkspaceCleanupTest.java
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/00beae2f4277f5b0291af08a46777fd8a850fd1f
          Log:
          JENKINS-35975 Restrict Stapler methods for external use. Modify DiskPool constructor to accept workspaceTemplate too

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: src/main/java/org/jenkinsci/plugins/ewm/definitions/Disk.java src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java src/main/java/org/jenkinsci/plugins/ewm/definitions/Template.java src/main/java/org/jenkinsci/plugins/ewm/nodes/DiskNode.java src/main/java/org/jenkinsci/plugins/ewm/nodes/ExternalWorkspaceProperty.java src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep.java src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java src/test/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStepTest.java src/test/java/org/jenkinsci/plugins/ewm/steps/ExwsStepTest.java src/test/java/org/jenkinsci/plugins/ewm/steps/WorkspaceCleanupTest.java http://jenkins-ci.org/commit/external-workspace-manager-plugin/00beae2f4277f5b0291af08a46777fd8a850fd1f Log: JENKINS-35975 Restrict Stapler methods for external use. Modify DiskPool constructor to accept workspaceTemplate too

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          doc/CUSTOM_WORKSPACE_PATH.md
          src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java
          src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateExecution.java
          src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep.java
          src/main/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtil.java
          src/main/resources/org/jenkinsci/plugins/ewm/definitions/DiskPool/help-workspaceTemplate.html
          src/main/resources/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep/help-path.html
          src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/3c969bee9b5950b923a2ee726c45db9ec53fdc28
          Log:
          JENKINS-35975 Add FormValidation for workspace path template

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: doc/CUSTOM_WORKSPACE_PATH.md src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateExecution.java src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep.java src/main/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtil.java src/main/resources/org/jenkinsci/plugins/ewm/definitions/DiskPool/help-workspaceTemplate.html src/main/resources/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep/help-path.html src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java http://jenkins-ci.org/commit/external-workspace-manager-plugin/3c969bee9b5950b923a2ee726c45db9ec53fdc28 Log: JENKINS-35975 Add FormValidation for workspace path template

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          src/main/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtil.java
          src/test/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtilTest.java
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/414f1ef0bc918d664295952a35467823dc4c38ef
          Log:
          JENKINS-35975 Write tests and javadoc for FormValidation method that verifies the input workspace template

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: src/main/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtil.java src/test/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtilTest.java http://jenkins-ci.org/commit/external-workspace-manager-plugin/414f1ef0bc918d664295952a35467823dc4c38ef Log: JENKINS-35975 Write tests and javadoc for FormValidation method that verifies the input workspace template

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alexandru Somai
          Path:
          README.md
          doc/CUSTOM_WORKSPACE_PATH.md
          doc/img/global-workspace-template.png
          src/main/java/org/jenkinsci/plugins/ewm/definitions/Disk.java
          src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java
          src/main/java/org/jenkinsci/plugins/ewm/definitions/Template.java
          src/main/java/org/jenkinsci/plugins/ewm/nodes/DiskNode.java
          src/main/java/org/jenkinsci/plugins/ewm/nodes/ExternalWorkspaceProperty.java
          src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateExecution.java
          src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep.java
          src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsStep.java
          src/main/java/org/jenkinsci/plugins/ewm/strategies/DiskAllocationStrategy.java
          src/main/java/org/jenkinsci/plugins/ewm/strategies/MostUsableSpaceStrategy.java
          src/main/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtil.java
          src/main/resources/org/jenkinsci/plugins/ewm/definitions/DiskPool/config.jelly
          src/main/resources/org/jenkinsci/plugins/ewm/definitions/DiskPool/help-workspaceTemplate.html
          src/main/resources/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep/config.jelly
          src/main/resources/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep/help-path.html
          src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java
          src/test/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStepTest.java
          src/test/java/org/jenkinsci/plugins/ewm/steps/ExwsStepTest.java
          src/test/java/org/jenkinsci/plugins/ewm/steps/WorkspaceCleanupTest.java
          src/test/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtilTest.java
          http://jenkins-ci.org/commit/external-workspace-manager-plugin/cab9d20d692e385f3c51e16d95134d9845bbe9f1
          Log:
          Merge pull request #24 from alexsomai/custom-template

          JENKINS-35975 Allow configurable relative path

          Compare: https://github.com/jenkinsci/external-workspace-manager-plugin/compare/589cc95f4fee...cab9d20d692e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexandru Somai Path: README.md doc/CUSTOM_WORKSPACE_PATH.md doc/img/global-workspace-template.png src/main/java/org/jenkinsci/plugins/ewm/definitions/Disk.java src/main/java/org/jenkinsci/plugins/ewm/definitions/DiskPool.java src/main/java/org/jenkinsci/plugins/ewm/definitions/Template.java src/main/java/org/jenkinsci/plugins/ewm/nodes/DiskNode.java src/main/java/org/jenkinsci/plugins/ewm/nodes/ExternalWorkspaceProperty.java src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateExecution.java src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep.java src/main/java/org/jenkinsci/plugins/ewm/steps/ExwsStep.java src/main/java/org/jenkinsci/plugins/ewm/strategies/DiskAllocationStrategy.java src/main/java/org/jenkinsci/plugins/ewm/strategies/MostUsableSpaceStrategy.java src/main/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtil.java src/main/resources/org/jenkinsci/plugins/ewm/definitions/DiskPool/config.jelly src/main/resources/org/jenkinsci/plugins/ewm/definitions/DiskPool/help-workspaceTemplate.html src/main/resources/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep/config.jelly src/main/resources/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStep/help-path.html src/test/java/org/jenkinsci/plugins/ewm/steps/CustomWorkspaceTest.java src/test/java/org/jenkinsci/plugins/ewm/steps/ExwsAllocateStepTest.java src/test/java/org/jenkinsci/plugins/ewm/steps/ExwsStepTest.java src/test/java/org/jenkinsci/plugins/ewm/steps/WorkspaceCleanupTest.java src/test/java/org/jenkinsci/plugins/ewm/utils/FormValidationUtilTest.java http://jenkins-ci.org/commit/external-workspace-manager-plugin/cab9d20d692e385f3c51e16d95134d9845bbe9f1 Log: Merge pull request #24 from alexsomai/custom-template JENKINS-35975 Allow configurable relative path Compare: https://github.com/jenkinsci/external-workspace-manager-plugin/compare/589cc95f4fee...cab9d20d692e

          Alexandru Somai added a comment -

          Done https://github.com/jenkinsci/external-workspace-manager-plugin/pull/24

          Alexandru Somai added a comment - Done https://github.com/jenkinsci/external-workspace-manager-plugin/pull/24

            alexsomai Alexandru Somai
            alexsomai Alexandru Somai
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: