Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36060

Setup personalization as a new plugin

    XMLWordPrintable

Details

    • 1.0-m10

    Description

      Need to create some extension points in order to property integrate:

      • At the top of the dashboard page to inject the favorites list
      • On right side of various tables to inject the favorite toggle component (pipelines list, pipeline -> branches list)

      Attachments

        Activity

          cliffmeyers Cliff Meyers added a comment -

          michaelneale is this about what you had in mind as far as a separate plugin?

          https://github.com/jenkinsci/blueocean-plugin/compare/feature/JENKINS-36060-personalization-plugin

          I just added it as another Maven module in the same style as blueocean-dashboard. The test EP works just fine. I'm going to start building the card component (JENKINS-35828), then re-merge master once new extension point stuff (JENKINS-35990) is ready.

          cliffmeyers Cliff Meyers added a comment - michaelneale is this about what you had in mind as far as a separate plugin? https://github.com/jenkinsci/blueocean-plugin/compare/feature/JENKINS-36060-personalization-plugin I just added it as another Maven module in the same style as blueocean-dashboard. The test EP works just fine. I'm going to start building the card component ( JENKINS-35828 ), then re-merge master once new extension point stuff ( JENKINS-35990 ) is ready.
          michaelneale Michael Neale added a comment -

          cliffmeyers yes I think it is an OK starting point.

          The alternative is to have it in a separate repo, which depends on blueocean plugin (as a dev time maven dep) so when you run mvn hpi:run - it will launch Jenkins + blue ocean bits. This will work fine (as long as you mvn install blueocean), but may be a bit cumbersome if you have to add things to dashboard to house the EPs for it (but does keep it loosely coupled).

          I think, as long as the deps in the pom.xml for the blueocean-personalisation are kept correct (ie, pretty empty), there won't be an issue with moving it out to its own thing (and it will always be bundled with blue ocean anyway, I don't expect we wouldn't want people to have personalisation, right jamesdumay?).

          michaelneale Michael Neale added a comment - cliffmeyers yes I think it is an OK starting point. The alternative is to have it in a separate repo, which depends on blueocean plugin (as a dev time maven dep) so when you run mvn hpi:run - it will launch Jenkins + blue ocean bits. This will work fine (as long as you mvn install blueocean), but may be a bit cumbersome if you have to add things to dashboard to house the EPs for it (but does keep it loosely coupled). I think, as long as the deps in the pom.xml for the blueocean-personalisation are kept correct (ie, pretty empty), there won't be an issue with moving it out to its own thing (and it will always be bundled with blue ocean anyway, I don't expect we wouldn't want people to have personalisation, right jamesdumay ?).
          tfennelly Tom FENNELLY added a comment -

          New plugin makes sense to me. I'd say keep it in with the other plugins for now and separate them all out together Vs having a floater.

          tfennelly Tom FENNELLY added a comment - New plugin makes sense to me. I'd say keep it in with the other plugins for now and separate them all out together Vs having a floater.
          cliffmeyers Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/304

          People

            cliffmeyers Cliff Meyers
            cliffmeyers Cliff Meyers
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: