Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: openid-plugin
-
Labels:None
-
Similar Issues:
Description
For improved test-ability and upgrades, upgrade the parent pom to the 2.x line. The jenkins.version might also be a candidate for upgrades since it's on a line that's old.
Attachments
Issue Links
- depends on
-
JENKINS-25019 updateSecureSessionFlag fails to set secure cookie flag
-
- Resolved
-
- is related to
-
-
- Open
-
-
-
- Open
-
- links to
Activity
To get around this when using the new test harness, the version must minimally be 1.586 since the change wasn't backported to the 1.580 line.
Kristin Whetstone
added a comment - To get around this when using the new test harness, the version must minimally be 1.586 since the change wasn't backported to the 1.580 line. All tests are passing. I'd appreciate some reviews and eventually a merge from the plugin maintainer. There are still changes that the openid plugin maintainer will want to review. PR10
Kristin Whetstone
added a comment - All tests are passing. I'd appreciate some reviews and eventually a merge from the plugin maintainer. There are still changes that the openid plugin maintainer will want to review. PR10 Code changed in jenkins
User: Stephen Connolly
Path:
pom.xml
src/main/java/hudson/plugins/openid/OpenIdExtension.java
src/main/java/hudson/plugins/openid/OpenIdSession.java
src/main/java/hudson/plugins/openid/OpenIdSsoSecurityRealm.java
src/main/java/hudson/plugins/openid/OpenIdUserProperty.java
src/main/java/hudson/plugins/openid/StaticResourceServer.java
src/main/resources/hudson/plugins/openid/OpenIdLoginService/_openid-form-body.jelly
src/main/resources/hudson/plugins/openid/OpenIdLoginService/loginFragment.jelly
src/main/resources/hudson/plugins/openid/OpenIdLoginService/onAssociationSuccess.jelly
src/main/resources/hudson/plugins/openid/OpenIdUserProperty/config.jelly
src/main/resources/index.jelly
src/test/java/hudson/plugins/openid/OpenIdAXEmailAttributesTest.java
src/test/java/hudson/plugins/openid/OpenIdLoginServiceTest.java
src/test/java/hudson/plugins/openid/OpenIdSsoSecurityRealmTest.java
src/test/java/hudson/plugins/openid/OpenIdTestCase.java
src/test/java/hudson/plugins/openid/OpenIdTestService.java
http://jenkins-ci.org/commit/openid-plugin/bc0db50d1e67af115230f1e5c960a064e72effa7
Log:
Merge pull request #10 from kwhetstone/master
JENKINS-36499 Update to the new Parent POM
Compare: https://github.com/jenkinsci/openid-plugin/compare/37ec8d0fed54...bc0db50d1e67
This was delivered and released in openid 2.2
Kristin Whetstone
added a comment - This was delivered and released in openid 2.2 
I had to bump the version beyond the 1.580 bump in PR11 to handle JENKINS-25019. The left over failures would be related to this.
Unfortunately, the problems left over from this pom bump are not related to the issues that I found earlier. I have actually fixed those issues. The new issue is actually related to serving up the openid xrds.jelly; either it can't be found or the proxy service is in error (fakeproxy.jenkins-ci.org: Name or service not known). This might be related to the move from jenkins-ci.org which I think the maintainer of the plugin should deal with. The "not found 404" errors I'm seeing I think relate to the actual location of the xrds.jelly file. JenkinsRule changed a bunch of things around with accessing files, and this is one of the things that was affected by that.