If I have a single stage that calls an sh script, and that script fails, and I use try..catch, then this stage is marked as green success in the pipeline view, but it should be marked as a failure. I can "fix" this by adding an additional final stage at the end of the Jenkinsfile and then the first stage (previous stage) will correctly be marked as failed.

Here is some simple Jenkinsfile test code that shows how to reproduce this bug:

#!groovy

def machine1 = 'mymachine'

node (machine1) {

currentBuild.result='SUCCESS'

stage "Stage One"

try

catch (err) {
echo "Stage One Failed: ${err}"
currentBuild.result='FAILURE'
}

//
// We need this final stage to mark the end of the preceding stage,
// so that the preceding stage's code will fail if its sh script fails
//
// stage "End"

echo "We've reached the end of the '${env.JOB_NAME}' pipeline. The build has finished."

}

Simply uncomment the penultimate line that says stage "End" and you'll see what I mean.