Details
-
Bug
-
Status: Closed (View Workflow)
-
Blocker
-
Resolution: Fixed
-
None
-
-
1.0-m11
Description
If you go directly to https://ci.blueocean.io/blue/organizations/jenkins/folders%2Fsubfolder%2Fthirdfolder%2FhelloPipeline/detail/helloPipeline/1/pipeline and close that modal, you get redirected to https://ci.blueocean.io/blue/organizations/jenkins/folders/subfolder/thirdfolder/helloPipeline/#helloPipeline-1 which is 404 it should redirect to https://ci.blueocean.io/blue/organizations/jenkins/folders%2Fsubfolder%2Fthirdfolder%2FhelloPipeline/activity
cliffmeyers I think we need to review the onClose function regarding escaping the path
Attachments
Activity
cliffmeyers could we just kill this feature? It's annoying me a lot and won't work with pagination when it lands anyway.
jdumay sure. Just to clarify, when the user opens a run detail directly in browser and then closes, we still want them navigated back to the appropriate page (Activity tab), we just want to eliminate the hash from the URL and stop the "auto scroll" capability?
cliffmeyers good question. jamesdumay what do you mean with kill the feature? The problem lies that the "branch" param needs de/encoding
PR: https://github.com/jenkinsci/blueocean-plugin/pull/344 this fixes the 404. if jamesdumay can verify we should remove the hash / scroll behavior I will do a fix for that too.
cliffmeyers tscherler I think we want to introduce a more nuanced way of doing it after pagination goes in. the behaviour is great when the run is below the fold, but when its not it just causes an unnecessary jump - may be best to kill this feature for the time being.
pretty sure this was a regression