Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3662

Plugins included in hudson.war may not be updated via "Update Manager" or even manually via direct download

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • None
    • Platform: All, OS: All

    Description

      Even after upgrading SSH Slaves plugin to 0.5.1 it still reports in plugins as
      0.5.1 being available for upgrading and 0.4 as installed.
      This seems to be the source of trouble:

      • META-INF/maven/org.jvnet.hudson.plugins/ssh-slaves/pom.xml (both in
        ~/.hudson/plugins/ssh-slaves and ssh-slaves.hpi file itself):

      <version>0.4</version>

      whereas in pom.properties:

      #Generated by Maven
      #Mon Feb 02 15:47:44 GMT 2009
      version=0.4

      groupId=org.jvnet.hudson.plugins
      artifactId=ssh-slaves

      The contents inside seems to be timestamped with 2.02.2009 too, but the file:
      https://hudson.dev.java.net/servlets/ProjectDocumentList?folderID=9380&expandFolder=9380&folderID=5818
      having 0.5.1 seems to be made on 7.05.2009

      This is how it works from automatic upgrade from Hudson.
      When downloading directly from
      https://hudson.dev.java.net/servlets/ProjectDocumentList?folderID=9380&expandFolder=9380&folderID=5818
      I get the correct version.

      Attachments

        Activity

          mindless Alan Harder added a comment -

          Ok, I did see an update hang now.. I tried an update with ssh-slaves and another non-bundled plugin. The non-bundled one finished, but ssh-slaves progress bar never reached the end.. stopping just before the end, as you said. Hudson restart went back to ssh-slaves 0.8 (bundled in Hudson 1.336 that I'm using).

          Thanks for the wiki update!

          mindless Alan Harder added a comment - Ok, I did see an update hang now.. I tried an update with ssh-slaves and another non-bundled plugin. The non-bundled one finished, but ssh-slaves progress bar never reached the end.. stopping just before the end, as you said. Hudson restart went back to ssh-slaves 0.8 (bundled in Hudson 1.336 that I'm using). Thanks for the wiki update!

          This is a core problem.

          mfriedenhagen Mirko Friedenhagen added a comment - This is a core problem.
          mindless Alan Harder added a comment -

          Ok, I've started investigating this.. when the update "hangs" I found that no threads in Hudson are working on it anymore. It downloads the plugin, moves the old file to ".bak" and puts the new file in place, then bails out. I think there must be a RuntimeException that the ExecutorService is silently ignoring. Still digging..

          mindless Alan Harder added a comment - Ok, I've started investigating this.. when the update "hangs" I found that no threads in Hudson are working on it anymore. It downloads the plugin, moves the old file to ".bak" and puts the new file in place, then bails out. I think there must be a RuntimeException that the ExecutorService is silently ignoring. Still digging..

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/UpdateCenter.java
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=25505
          Log:
          [FIXED JENKINS-3662] Fix ability to upgrade bundled plugins when security is enabled.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/java/hudson/model/UpdateCenter.java trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=25505 Log: [FIXED JENKINS-3662] Fix ability to upgrade bundled plugins when security is enabled.

          Worked for me as of 1.340.

          mfriedenhagen Mirko Friedenhagen added a comment - Worked for me as of 1.340.

          People

            mindless Alan Harder
            krystian_nowak Krystian Nowak
            Votes:
            5 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: