Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36675

REGRESSION: unable to launch any multibranch jobs

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • blueocean-plugin
    • None
    • 1.0-m11

      A recent change, in an attempt to fix encoding problems for opening branches with / in the name, resulted in being unable to launch any type of multi branch.

      Change: https://github.com/jenkinsci/blueocean-plugin/commit/11e065f7b8e67065e1ef6a447c2a9d9f34fac2e3

      The destructuring variable was assigned to "branchName" but "name" was still used in the argument to the RunPipeline component.

      I have a PR incoming for this, but also found that it needs to encode the already "once encoded" form again, for Jenkins to work. An encode call was needed on the branchName.

      I then discovered that SSE events were coming back only once encoded. Jenkins, both classic URIs and API requires a "double encoding" for branch names, so I had to change the backend code to emit a message that would encode it correctly. Confused?

      I also note that the PullRequest.jsx will be in a similar state, so that needs to be corrected. Like cliffmeyers points out, these really should be combined, and use some other way to get links rather than assembling them each time which seems to be error prone.

            michaelneale Michael Neale
            michaelneale Michael Neale
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: