Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36700

Steps open and close on load

    XMLWordPrintable

Details

    • 1.0-m11, 1.0-m12

    Description

      See this video https://www.dropbox.com/s/rskasveer1ydule/pipeline-steps-oddness.mov?dl=0

      Few issues here:
      1. Steps open and close on load
      2. When there are no steps we don't display a message (its just empty).

      What we should see:
      1. Steps stay closed
      2. condensed empty state (no icon - just text under the step heading "There are no steps"

      You can use this Pipeline to reproduce the video example:

         stage 'Pre'
         stage 'Stage 1'
         echo 'Hello World 1'
         stage 'Stage 2'
         echo 'Hello World 2'
      

      Attachments

        Activity

          jamesdumay I fixed 1): https://github.com/jenkinsci/blueocean-plugin/pull/355 and regression test added to jenkinsci/blueocean-acceptance-test#9 . both merged

          Regarding 2 I am not really 100% sure what you mean, do you mean that the text should appear like a ResultItem but without Icon, or just plain test underneath the heading?

          tscherler Thorsten Scherler added a comment - jamesdumay I fixed 1): https://github.com/jenkinsci/blueocean-plugin/pull/355 and regression test added to jenkinsci/blueocean-acceptance-test#9 . both merged Regarding 2 I am not really 100% sure what you mean, do you mean that the text should appear like a ResultItem but without Icon, or just plain test underneath the heading?
          jamesdumay James Dumay added a comment -

          For #2, if there are zero steps add a "empty state" JDL component with text inside that says "There are no steps"

          We use the same pattern on the tests tab when there are no tests for the run

          jamesdumay James Dumay added a comment - For #2, if there are zero steps add a "empty state" JDL component with text inside that says "There are no steps" We use the same pattern on the tests tab when there are no tests for the run

          like this?

          tscherler Thorsten Scherler added a comment - like this?
          jamesdumay James Dumay added a comment -

          tscherler LGTM

          jamesdumay James Dumay added a comment - tscherler LGTM
          jamesdumay James Dumay added a comment -

          tscherler can we ditch the Log Toolbar in this case too?

          jamesdumay James Dumay added a comment - tscherler can we ditch the Log Toolbar in this case too?
          tscherler Thorsten Scherler added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/360
          jamesdumay James Dumay added a comment -

          tscherler awesome

          jamesdumay James Dumay added a comment - tscherler awesome

          People

            tscherler Thorsten Scherler
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: