FindBugs: Major issues are reported for the Jenkins core

This issue is archived. You can view it, but you can't modify it. Learn more

XMLWordPrintable

      It would be great to fix the issues and to enable FindBugs by default after it.

      [INFO] BugInstance size is 26
      [INFO] Error size is 0
      [INFO] Total bugs: 26
      [INFO] Possible null pointer dereference of ExtensionList.jenkins in hudson.DescriptorExtensionList.load() [hudson.DescriptorExtensionList, hudson.DescriptorExtensionList] Dereferenced at DescriptorExtensionList.java:[line 185]Known null at DescriptorExtensionList.java:[line 185] NP_NULL_ON_SOME_PATH
      [INFO] hudson.PluginManager.addDependencies(URL, String, Set) is or uses a map or set of URLs, which can be a performance hog [hudson.PluginManager] At PluginManager.java:[lines 631-663] DMI_COLLECTION_OF_URLS
      [INFO] hudson.PluginManager.addDependencies(URL, String, Set) is or uses a map or set of URLs, which can be a performance hog [hudson.PluginManager] At PluginManager.java:[line 631] DMI_COLLECTION_OF_URLS
      [INFO] hudson.PluginManager.loadPluginsFromWar(String, FilenameFilter) is or uses a map or set of URLs, which can be a performance hog [hudson.PluginManager, hudson.PluginManager] At PluginManager.java:[line 599]Another occurrence at PluginManager.java:[line 621] DMI_COLLECTION_OF_URLS
      [INFO] hudson.PluginManager.loadPluginsFromWar(String, FilenameFilter) is or uses a map or set of URLs, which can be a performance hog [hudson.PluginManager] At PluginManager.java:[line 612] DMI_COLLECTION_OF_URLS
      [INFO] hudson.PluginManager.loadPluginsFromWar(String, FilenameFilter) is or uses a map or set of URLs, which can be a performance hog [hudson.PluginManager] At PluginManager.java:[line 612] DMI_COLLECTION_OF_URLS
      [INFO] hudson.Util.pauseBetweenDeletes(int) forces garbage collection; extremely dubious except in benchmarking code [hudson.Util] At Util.java:[line 417] DM_GC
      [INFO] hudson.cli.CliManagerImpl$1 stored into non-transient field CliManagerImpl.authenticationFilter [hudson.cli.CliManagerImpl] At CliManagerImpl.java:[line 56] SE_BAD_FIELD_STORE
      [INFO] Boxing/unboxing to parse a primitive hudson.model.Job.getDynamic(String, StaplerRequest, StaplerResponse) [hudson.model.Job] At Job.java:[line 819] DM_BOXED_PRIMITIVE_FOR_PARSING
      [INFO] ListView.jobNames not guarded against concurrent access; locked 80% of time [hudson.model.ListView, hudson.model.ListView, hudson.model.ListView$Listener, hudson.model.ListView$Listener, hudson.model.ListView$Listener, hudson.model.ListView$Listener, hudson.model.ListView$Listener, hudson.model.ListView, hudson.model.ListView, hudson.model.ListView, hudson.model.ListView, hudson.model.ListView, hudson.model.ListView, hudson.model.ListView] Unsynchronized access at ListView.java:[line 132]Unsynchronized access at ListView.java:[line 133]Synchronized access at ListView.java:[line 519]Synchronized access at ListView.java:[line 475]Synchronized access at ListView.java:[line 476]Synchronized access at ListView.java:[line 480]Synchronized access at ListView.java:[line 478]Synchronized access at ListView.java:[line 311]Synchronized access at ListView.java:[line 372]Synchronized access at ListView.java:[line 382]Synchronized access at ListView.java:[line 260]Synchronized access at ListView.java:[line 179]Synchronized access at ListView.java:[line 274]Synchronized access at ListView.java:[line 249] IS_FIELD_NOT_GUARDED
      [INFO] Potentially ambiguous invocation of either an outer or inherited method java.util.ArrayList.clear() in hudson.model.Queue$ItemList.cancelAll() [hudson.model.Queue$ItemList] At Queue.java:[line 2776] IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD
      [INFO] String.format(String, Object[]) needs printf-style format but called with MessageFormat [hudson.model.UpdateCenter] At UpdateCenter.java:[line 281] VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED
      [INFO] String.format(String, Object[]) needs printf-style format but called with MessageFormat [hudson.model.User] At User.java:[line 448] VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED
      [INFO] Redundant nullcheck of e, which is known to be non-null in hudson.model.queue.Executables.getEstimatedDurationFor(Queue$Executable) [hudson.model.queue.Executables] Redundant null check at Executables.java:[line 77] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
      [INFO] Null passed for non-null parameter of hudson.model.Descriptor.newInstance(StaplerRequest, JSONObject) in hudson.scm.RepositoryBrowsers.createInstance(Class, StaplerRequest, String) [hudson.scm.RepositoryBrowsers] At RepositoryBrowsers.java:[line 77] NP_NONNULL_PARAM_VIOLATION
      [INFO] req must be non-null but is marked as nullable [hudson.security.HudsonPrivateSecurityRealm$Details$DescriptorImpl] At HudsonPrivateSecurityRealm.java:[lines 573-585] NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE
      [INFO] Return value of String.trim() ignored in hudson.security.SecurityRealm.getFrom() [hudson.security.SecurityRealm] At SecurityRealm.java:[line 529] RV_RETURN_VALUE_IGNORED
      [INFO] req must be non-null but is marked as nullable [hudson.security.csrf.DefaultCrumbIssuer$DescriptorImpl] At DefaultCrumbIssuer.java:[line 140] NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE
      [INFO] Boxing/unboxing to parse a primitive new hudson.slaves.ChannelPinger() [hudson.slaves.ChannelPinger] At ChannelPinger.java:[line 64] DM_BOXED_PRIMITIVE_FOR_PARSING
      [INFO] req must be non-null but is marked as nullable [hudson.tasks.Maven$DescriptorImpl] At Maven.java:[line 475] NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE
      [INFO] Impossible downcast from Object[] to hudson.tools.ToolInstallation[] in hudson.tools.ToolDescriptor.getInstallations() [hudson.tools.ToolDescriptor] At ToolDescriptor.java:[line 74] BC_IMPOSSIBLE_DOWNCAST
      [INFO] hudson.util.ChartUtil.awtProblemCause isn't final but should be refactored to be so [hudson.util.ChartUtil] At ChartUtil.java:[line 109] MS_SHOULD_BE_REFACTORED_TO_BE_FINAL
      [INFO] Null passed for non-null parameter of hudson.model.Descriptor.newInstance(StaplerRequest, JSONObject) in hudson.views.ListViewColumn.createDefaultInitialColumnList() [hudson.views.ListViewColumn] At ListViewColumn.java:[line 135] NP_NONNULL_PARAM_VIOLATION
      [INFO] jenkins.slaves.JnlpSlaveAgentProtocol3.ENABLED isn't final but should be refactored to be so [jenkins.slaves.JnlpSlaveAgentProtocol3] At JnlpSlaveAgentProtocol3.java:[line 133] MS_SHOULD_BE_REFACTORED_TO_BE_FINAL
      [INFO] Write to static field jenkins.util.SystemProperties.theContext from instance method jenkins.util.SystemProperties.contextInitialized(ServletContextEvent) [jenkins.util.SystemProperties] At SystemProperties.java:[line 91] ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD
      [INFO] jenkins.util.xml.XMLUtils.setDocumentBuilderFactoryFeature(DocumentBuilderFactory, String, boolean) might ignore java.lang.Exception [jenkins.util.xml.XMLUtils, jenkins.util.xml.XMLUtils] At XMLUtils.java:[line 236]At XMLUtils.java:[line 236] DE_MIGHT_IGNORE
      [INFO] 
      

            Assignee:
            Oleg Nenashev
            Reporter:
            Oleg Nenashev
            Archiver:
            Jenkins Service Account

              Created:
              Updated:
              Resolved:
              Archived: