Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36720

Investigate/cleanup spotbugs issues in Jenkins core

      Currently FindBugs settings ignore all medium-priority issues. It's bad, because this level contains NPE checks and other serious issues.

      TODOs:

      • Remove filtering of medium-priority issues by setting <findbugs.threshold>Medium</findbugs.threshold>
      • Investigate error codes, add low-important once to the ignore list
      • Fix important issues in small pull requests

      This task can be handled by multiple contributors!

          [JENKINS-36720] Investigate/cleanup spotbugs issues in Jenkins core

          Daniel Beck added a comment -

          Is this done completely in 2.191, or just partially?

          Daniel Beck added a comment - Is this done completely in 2.191, or just partially?

          There are several PRs done for this and there are more to come. This is a quite huge task. I think we would be down to 400 spotbugs issues if all PRs would be merged. So I guess this will be in progress for a longer while

          Stefan Spieker added a comment - There are several PRs done for this and there are more to come. This is a quite huge task. I think we would be down to 400 spotbugs issues if all PRs would be merged. So I guess this will be in progress for a longer while

          Oleg Nenashev added a comment -

          I am thinking about Highlighting this story for Hacktoberfest. WDYT stefan_spieker?

          Oleg Nenashev added a comment - I am thinking about Highlighting this story for Hacktoberfest. WDYT stefan_spieker ?

          oleg_nenashev: Yes. That is a good idea. We have a lot issues still to solve. Maybe you should mention then that changing in the main pom the line 109 with this : <findbugs.threshold>Medium</findbugs.threshold> is enough to get all spotbugs issues.

          Stefan Spieker added a comment - oleg_nenashev : Yes. That is a good idea. We have a lot issues still to solve. Maybe you should mention then that changing in the main pom the line 109 with this : <findbugs.threshold>Medium</findbugs.threshold> is enough to get all spotbugs issues.

          Current status:

          [INFO] Total bugs: 400

          Stefan Spieker added a comment - Current status: [INFO] Total bugs: 400

          Oleg Nenashev added a comment -

          Ugh. But it is still a  very good progress, thanks!

          Oleg Nenashev added a comment - Ugh. But it is still a  very good progress, thanks!

          We are on a good way, but still some steps to go:

          [java] Warnings generated: 362

           

          Stefan Spieker added a comment - We are on a good way, but still some steps to go: [java] Warnings generated: 362  

          Oleg Nenashev added a comment -

          Thanks for your hard work stefan_spieker! I really look forward to introduce stricter requirements at some point

          Oleg Nenashev added a comment - Thanks for your hard work stefan_spieker ! I really look forward to introduce stricter requirements at some point

          Probably due to findsecbugs we are at [java] Warnings generated: 591 right now

          Raihaan Shouhell added a comment - Probably due to findsecbugs we are at [java] Warnings generated: 591 right now

          Mark Waite added a comment -

          The current spotbugs exclusion file for Jenkins core includes several items that need to be triaged. Items that need triage are in the section that starts with the text:

          Here lies technical debt. Exclusions in this section have not yet been triaged

          Items after that comment are examples of things to be reviewed as part of this issue.

          Mark Waite added a comment - The current spotbugs exclusion file for Jenkins core includes several items that need to be triaged. Items that need triage are in the section that starts with the text: Here lies technical debt. Exclusions in this section have not yet been triaged Items after that comment are examples of things to be reviewed as part of this issue.

            stefan_spieker Stefan Spieker
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated: