Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36757

incorrect logging formats in setup wizard.


    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core

      In 2.7.1 there are several incorrect logging statements which causes the message to be slightly less than useful.

      $ grep -r -E -n "[^']'{[[:digit:]]"
      hudson/model/UpdateCenter.java:1453:                    LOGGER.log(WARNING, "Update site '{0}' does not declare the connection check URL. "
      jenkins/install/InstallState.java:176:            LOGGER.log(Level.WARNING, "Read install state with blank name: '{0}'. It will be ignored", name);
      jenkins/install/InstallState.java:182:            LOGGER.log(Level.WARNING, "Cannot locate an extension point for the state '{0}'. It will be ignored", name);

      The idea here was presumable to put something in single quotes - however a message format requires a quote to be escaped - or it means use whatever is between the quotes without interpretation.

      So you end up with log messages like:

      Jul 18, 2016 1:52:58 PM hudson.model.UpdateCenter$ConnectionCheckJob run
      WARNING: Update site {0} does not declare the connection check URL. Skipping the network availability check.

            Unassigned Unassigned
            teilo James Nord
            0 Vote for this issue
            4 Start watching this issue