Code changed in jenkins
User: Jesse Glick
Path:
src/test/java/plugins/WorkflowPluginTest.java
http://jenkins-ci.org/commit/acceptance-test-harness/7c815e3bcdb83c68dbfa1d8778ce6465fe7b3517
Log:
JENKINS-36997 Noting that weird script is a workaround for a PATH_MAX problem.

Code changed in jenkins
User: Jesse Glick
Path:
pom.xml
src/main/java/com/cloudbees/jenkins/plugins/sshagent/RemoteAgent.java
src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapper.java
src/main/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepExecution.java
src/main/java/com/cloudbees/jenkins/plugins/sshagent/exec/ExecRemoteAgent.java
src/main/java/com/cloudbees/jenkins/plugins/sshagent/exec/ExecRemoteAgentFactory.java
src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBase.java
src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentBuildWrapperTest.java
src/test/java/com/cloudbees/jenkins/plugins/sshagent/SSHAgentStepWorkflowTest.java
http://jenkins-ci.org/commit/ssh-agent-plugin/8d02c6ca20ce514e8737a15b24bbfa7557930273
Log:
Merge pull request #18 from jglick/ExecRemoteAgent-JENKINS-36997

JENKINS-36997 CLI implementation of RemoteAgent

Compare: https://github.com/jenkinsci/ssh-agent-plugin/compare/f38bb5f22fea...8d02c6ca20ce

We tried this out with:

sshagent(['CredId']) {
  docker.inside('image') {
    // git operations
  }
}

and it did not work.

Using the following did work:

docker.inside('image') {
  sshagent(['CredId']) {
    // git operations
  }
}

That makes sense to me based on how the execution works now with using a CLI implementation.

Thanks for fixing this!

Right, the ssh-agent needs to be run inside the container so its socket is in the same kernel namespace as the commands which try to access it.

Why is this marked as resolved? I use a multibranch pipeline and still suffer from this issue.
I have a master slave setup. Which workspaces now need to be shorter than 108? master or slave or both?
Simply doing ws("test") before the image.inside didn't help although the resulting ws path is really short.

Outside of the container git cloning with inside sshagent(..){ works. Inside container it doesn't and the log says:
docker exec 9859e94c20b84efd81e1752417c1f5144fa198ba76b14e1670f8993512af7d60 ssh-agent
SSH_AUTH_SOCK=/tmp/ssh-GoP5qbl4iakN/agent.13
SSH_AGENT_PID=20

```
$ docker exec --env SSH_AGENT_PID=20 --env SSH_AUTH_SOCK=/tmp/ssh-GoP5qbl4iakN/agent.13 9859e94c20b84efd81e1752417c1f5144fa198ba76b14e1670f8993512af7d60 ssh-add /home/INT/jenkins/short@tmp/private_key_3688909095782238252.key
Identity added: /home/INT/jenkins/short@tmp/private_key_3688909095782238252.key (/home/INT/jenkins/short@tmp/private_key_3688909095782238252.key)

```

hermain As Mike and Jesse alluded to, the new Agent implementation was added which is based on the CLI ssh-agent. If you have a CLI available inside the docker container and use the `sshagent` inside the docker.inside() closure, your git clone should work.

Look for the message like "Exec ssh-agent (binary ssh-agent on a remote machine)" or any errors that mention ssh-agent

devopsfido I managed to resolve the issue but this page was offline at the time so I forgot to mention it here:

The problem in my case was that my git was not a known host inside the container:

image.inside("-u root:root --network=host") {
            sshagent(credentials: [config.gitKeyCredentialsId] ) {
                sh "mkdir ~/.ssh"
                sh "ssh-keyscan git.myCompany.com >> ~/.ssh/known_hosts"
               // call scripts that do git clone...
            }
        }

I hope that helps you and anyone else with a similar problem.

Hello, I'm using latest 1.17 version of SSH Agent Plugin and still expirience the same issue.
Although docker image has ssh-agent cmd line command inside - the socket is created under {{/tmp} so it's inaccesisble

eshepelyuk maybe ssh-agent is not in $PATH or something.

hermain Thank you!  This was exactly our issue.

Works with SSH Agent Plugin v1.17 for us, using declarative pipeline and just a regular agent block:

pipeline {
  agent { docker {
    image 'my_build_image'
    ...
  } }
  ...
  stage("foo") {
    sshagent(credentials: [config.gitKeyCredentialsId] ) {
      sh "mkdir ~/.ssh && ssh-keyscan git.myCompany.com >> ~/.ssh/known_hosts"
      // call scripts that do git clone...
    }
  }
}