Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37259

Client uses LIST output rather than using MLSD command.

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • None
    • Jenkins v2.17
      Publish-over-FTP v1.12

    Description

      The output of the LIST command is not defined, so parsing the output is error-prone.

      The MLSD (and MLST) commands are defined in RFC 3659, provides a "machine readable" directory listing, with a well-defined format. Conformant servers advertise that they support the command (via FEAT), allowing clients to use MLSD command if the server supports it. Apache commons ftp client also supports the mlsd command, albeit via explicit commands.

      The suggested improvement is that the publish-over-ftp uses MLSD command on servers that support it.

      Attachments

        Activity

          slide_o_mix Alex Earl added a comment -

          Thanks, I missed that part in the RFC. I am using ftpClient.hasFeature("MLST") and then using the ftpClient.mlistDir() method to iterate. 

          slide_o_mix Alex Earl added a comment - Thanks, I missed that part in the RFC. I am using ftpClient.hasFeature("MLST") and then using the ftpClient.mlistDir() method to iterate. 
          iepe1eet Paul Millar added a comment -

          Incidentally, a throw-away comment in the FTPClient#listFiles([String)|http://download.oracle.com/javase/1.6.0/docs/api/java/lang/String.html?is-external=true] JavaDoc entry suggests the Apache Commons FTP client automatically chooses between LIST and MLSD.  If so, then perhaps that would be preferrable to testing.for MLST features explicitly.

          iepe1eet Paul Millar added a comment - Incidentally, a throw-away comment in the FTPClient# listFiles ([String)|http://download.oracle.com/javase/1.6.0/docs/api/java/lang/String.html?is-external=true] JavaDoc entry suggests the Apache Commons FTP client automatically chooses between LIST and MLSD.  If so, then perhaps that would be preferrable to testing.for MLST features explicitly.
          slide_o_mix Alex Earl added a comment -

          Will be fixed in 1.13

          slide_o_mix Alex Earl added a comment - Will be fixed in 1.13

          For your information, all publish-over-ftp component type JENKINS issues related to the Publish Over FTP plugin have been transferred to Github: https://github.com/jenkinsci/publish-over-ftp-plugin/issues

          Here is the direct link to this issue in Github: https://github.com/jenkinsci/publish-over-ftp-plugin/issues/63
          And here is the link to a search for related issues: https://github.com/jenkinsci/publish-over-ftp-plugin/issues?q=%22JENKINS-37259%22

          (Note: this is an automated bulk comment)

          gmcdonald Gavin McDonald added a comment - For your information, all publish-over-ftp component type JENKINS issues related to the Publish Over FTP plugin have been transferred to Github: https://github.com/jenkinsci/publish-over-ftp-plugin/issues Here is the direct link to this issue in Github: https://github.com/jenkinsci/publish-over-ftp-plugin/issues/63 And here is the link to a search for related issues: https://github.com/jenkinsci/publish-over-ftp-plugin/issues?q=%22JENKINS-37259%22 (Note: this is an automated bulk comment)

          This Resolved Issue has now been Closed. If you wish to follow up please see the Corresponding Github Issue

          gmcdonald Gavin McDonald added a comment - This Resolved Issue has now been Closed. If you wish to follow up please see the Corresponding Github Issue

          People

            slide_o_mix Alex Earl
            iepe1eet Paul Millar
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: