-
Type:
New Feature
-
Resolution: Fixed
-
Priority:
Major
-
Component/s: saml-plugin
-
None
-
Environment:Jenkins version : 1.642.18.1
SAML-plugin version : 0.5 (we noticed this issue in 0.5 version, we have not tested the new 0.6 version)
We require a small change in Jenkins SAML plugin code, to fulfill our requirement of having a unified Jenkins SSO profile. It's a one line code.
Should we make that change and create a pull request on the SAML github repo? Or if some one from your team could make the required change and create new artifact version for SAML. So we can use the updated version in our Jenkins setup.
Code change we need:
File: SamlSecurityRealm.java
/////////////////////////////////////////
private Saml2Client newClient()
{
Preconditions.checkNotNull(this.idpMetadata);
Saml2Client client = new Saml2Client();
//***this line needs to be added***
client. setSpEntityId( "OUR OWN ID PREFERABLE CONFIGURED IN THE FILE" );
client.setIdpMetadata(this.idpMetadata);
client.setCallbackUrl(getConsumerServiceUrl());
client.setDestinationBindingType("urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect");
client.setMaximumAuthenticationLifetime(Integer.valueOf(this.maximumAuthenticationLifetime));
return client;
}