Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37332

java.io.IOException: Failed to rename during Plugin Update

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Critical
    • Resolution: Fixed
    • core
    • Windows
      Jenkins 2.17

    Description

      We are currently unable to update plugins in our jenkins installation, because this exception occurs:

      java.io.IOException: Failed to rename C:\Program Files (x86)\Jenkins\plugins\windows-slaves.jpi.tmp to C:\Program Files (x86)\Jenkins\plugins\windows-slaves.jpi
      at hudson.model.UpdateCenter$InstallationJob.replace(UpdateCenter.java:1952)
      at hudson.model.UpdateCenter$UpdateCenterConfiguration.install(UpdateCenter.java:1178)
      at hudson.model.UpdateCenter$DownloadJob._run(UpdateCenter.java:1653)
      at hudson.model.UpdateCenter$InstallationJob._run(UpdateCenter.java:1848)
      at hudson.model.UpdateCenter$DownloadJob.run(UpdateCenter.java:1624)
      at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
      at java.util.concurrent.FutureTask.run(Unknown Source)
      at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:110)
      at java.lang.Thread.run(Unknown Source)

      It doesn't seem to affect all plugins, but it also happends for the JUnit plugin.

      Attachments

        Issue Links

          Activity

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/PluginManager.java
            core/src/main/java/hudson/Util.java
            core/src/test/java/hudson/PluginManagerTest.java
            http://jenkins-ci.org/commit/jenkins/37edc1a3b0c5670c24bd06d157f4de91b99f8391
            Log:
            [FIXED JENKINS-37332] - Prevent File descriptor leaks when reading manifests from JARs (#2516)

            • JENKINS-37332 - Improve diagnostics of non-closed streams during reading of the manifests in PluginManager
            • JENKINS-37332 - Leakless processing of JarUrlConnection during Manifest parsing
            • JENKINS-37332 - Also implement leak-safe method for retrieving file modification date
            • JENKINS-37332 - Add spotcheck methods for manifest file access + Javadoc
            • JENKINS-37332 - Also test multi-line and empty attributes in the test

            (cherry picked from commit 96c97860b0f018094c20283b15f3ddb3bdd9effe)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/Util.java core/src/test/java/hudson/PluginManagerTest.java http://jenkins-ci.org/commit/jenkins/37edc1a3b0c5670c24bd06d157f4de91b99f8391 Log: [FIXED JENKINS-37332] - Prevent File descriptor leaks when reading manifests from JARs (#2516) JENKINS-37332 - Improve diagnostics of non-closed streams during reading of the manifests in PluginManager JENKINS-37332 - Leakless processing of JarUrlConnection during Manifest parsing JENKINS-37332 - Also implement leak-safe method for retrieving file modification date JENKINS-37332 - Add spotcheck methods for manifest file access + Javadoc JENKINS-37332 - Also test multi-line and empty attributes in the test (cherry picked from commit 96c97860b0f018094c20283b15f3ddb3bdd9effe)
            oleg_nenashev Oleg Nenashev added a comment -

            danielbeck It has been reopened intentionally since the bug is in LTS now

            oleg_nenashev Oleg Nenashev added a comment - danielbeck It has been reopened intentionally since the bug is in LTS now

            olivergondza I also have this issue on our Jenkins instance (IIRC with the Mailer plugin).

            cobexer Ing. Christoph Obexer added a comment - olivergondza I also have this issue on our Jenkins instance (IIRC with the Mailer plugin).
            oleg_nenashev Oleg Nenashev added a comment -

            2.7.4 release discussion: https://groups.google.com/forum/#!topic/jenkinsci-dev/zIq6EgUPQBI
            Please vote there if you're affected

            oleg_nenashev Oleg Nenashev added a comment - 2.7.4 release discussion: https://groups.google.com/forum/#!topic/jenkinsci-dev/zIq6EgUPQBI Please vote there if you're affected

            Fixed on 2.7 LTS line in 2.7.4.

            olivergondza Oliver Gondža added a comment - Fixed on 2.7 LTS line in 2.7.4.

            People

              oleg_nenashev Oleg Nenashev
              nitek Claus Näveke
              Votes:
              13 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: