Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37397

Allow tool step to use Symbol names instead of classes for tool types

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • pipeline
    • None

    Description

      Related to JENKINS-37386 - now that we're getting @Symbol on ToolDescriptor, it makes sense to change the tool step to take either the descriptor ID (i.e., the class name) or the relevant symbol.

      Attachments

        Issue Links

          depends on

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-37403 Add a convenience static method for getting @Symbol values off an object

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. JENKINS-37386 Add @Symbol to ToolDescriptors

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link PR #16

          Activity

            Ascending order - Click to sort in descending order
            abayer Andrew Bayer added a comment -

            PR up at https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16

            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/steps/ToolStep.java
            src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepRunTest.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/20f2223d2d51f5ed3a6114a3064bf1ebca67e4dc
            Log:
            [FIXED JENKINS-37397] Allow use of @Symbols from tools as tool types.

            Fall back to allowing descriptor IDs as well.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/plugins/workflow/steps/ToolStep.java src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepRunTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/20f2223d2d51f5ed3a6114a3064bf1ebca67e4dc Log: [FIXED JENKINS-37397] Allow use of @Symbols from tools as tool types. Fall back to allowing descriptor IDs as well.

            People

              abayer Andrew Bayer
              abayer Andrew Bayer
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: