Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37397

Allow tool step to use Symbol names instead of classes for tool types

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • pipeline
    • None

    Description

      Related to JENKINS-37386 - now that we're getting @Symbol on ToolDescriptor, it makes sense to change the tool step to take either the descriptor ID (i.e., the class name) or the relevant symbol.

      Attachments

        Issue Links

          Activity

            abayer Andrew Bayer created issue -
            abayer Andrew Bayer made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            abayer Andrew Bayer made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            abayer Andrew Bayer made changes -
            Link This issue relates to JENKINS-37386 [ JENKINS-37386 ]
            abayer Andrew Bayer made changes -
            Description Related to JENKINS-37836 - now that we're getting {{@Symbol}} on {{ToolDescriptor}}, it makes sense to change the {{tool}} step to take either the descriptor ID (i.e., the class name) or the relevant symbol. Related to JENKINS-37386 - now that we're getting {{@Symbol}} on {{ToolDescriptor}}, it makes sense to change the {{tool}} step to take either the descriptor ID (i.e., the class name) or the relevant symbol.
            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/16
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "PR #16 (Web Link)" [ 14727 ]
            jglick Jesse Glick made changes -
            Link This issue depends on JENKINS-37403 [ JENKINS-37403 ]

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/steps/ToolStep.java
            src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepRunTest.java
            http://jenkins-ci.org/commit/workflow-basic-steps-plugin/20f2223d2d51f5ed3a6114a3064bf1ebca67e4dc
            Log:
            [FIXED JENKINS-37397] Allow use of @Symbols from tools as tool types.

            Fall back to allowing descriptor IDs as well.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/plugins/workflow/steps/ToolStep.java src/test/java/org/jenkinsci/plugins/workflow/steps/ToolStepRunTest.java http://jenkins-ci.org/commit/workflow-basic-steps-plugin/20f2223d2d51f5ed3a6114a3064bf1ebca67e4dc Log: [FIXED JENKINS-37397] Allow use of @Symbols from tools as tool types. Fall back to allowing descriptor IDs as well.
            abayer Andrew Bayer made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            abayer Andrew Bayer made changes -
            Component/s pipeline-general [ 21692 ]
            abayer Andrew Bayer made changes -
            Component/s workflow-plugin [ 18820 ]

            People

              abayer Andrew Bayer
              abayer Andrew Bayer
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: