Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37425

Rework the behavior of Toasts for Run, Stop and Replay

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • blueocean-plugin
    • None
    • 1.0-pre-beta-1, pacific, 1.0-b05/b-06

      Reproduction steps

      1. Go to a branch tab
      2. Click the run button of a branch
      3. Toast pops up "queued"

      Expected (as per JENKINS-35813)

      1. Go to a branch tab
      2. Click on the run button of a branch
      3. Toast pops up "OPEN" where clicking open will open the result modal for the run in the queued state

      Revised A/C

      1. Clicking a Run or Replay button should immediately produce a "Started" toast with an "OPEN" link that navigates the user to Run Details. No "Queued" toast should be displayed.
      2. Clicking a Stop button should immediately produce a "Stopping" toast. No further "Stopped" toast is necessary.

      Tech Notes

      1. As part of these refinements, personalization should be updated to use the new RunButton and ReplayButton components.
      2. Try to remove any of the "capabilities" code in DashboardCards by leveraging some new capabilities code.
      3. Try to remove any use of IfCapability in dashboard

        1. shot.png
          shot.png
          12 kB

          [JENKINS-37425] Rework the behavior of Toasts for Run, Stop and Replay

          James Dumay added a comment - - edited

          cliffmeyers also from JENKINS-35813

          When the play icon is clicked a run should start async
          Toast appears
          Toast action "OPEN" opens the result modal for the run that was started

          James Dumay added a comment - - edited cliffmeyers also from JENKINS-35813 When the play icon is clicked a run should start async Toast appears Toast action "OPEN" opens the result modal for the run that was started

          Cliff Meyers added a comment -

          jamesdumay okay got it. So are we axe'ing the "Queued" toast pretty much across the board now? Touching many related tickets, happy to kill 'em all now if that's what you want.

          Cliff Meyers added a comment - jamesdumay okay got it. So are we axe'ing the "Queued" toast pretty much across the board now? Touching many related tickets, happy to kill 'em all now if that's what you want.

          James Dumay added a comment -

          Kill em

          James Dumay added a comment - Kill em

          Michael Neale added a comment - - edited

          Not sure this is truly reliable in the case of freestyle where things really sit in the queued item for a while - we only have an expected run id, not the actual one, so OPEN isn't really advisable is it?

          Michael Neale added a comment - - edited Not sure this is truly reliable in the case of freestyle where things really sit in the queued item for a while - we only have an expected run id, not the actual one, so OPEN isn't really advisable is it?

          James Dumay added a comment -

          michaelneale cliffmeyers Isn't this the same as clicking on the queued run in the activity list?

          James Dumay added a comment - michaelneale cliffmeyers Isn't this the same as clicking on the queued run in the activity list?

          Michael Neale added a comment -

          IF that is the case, then yes. Although https://github.com/jenkinsci/blueocean-plugin/pull/441 is still pending, I am not sure of relationship. It doesn't seem to use that same expected run number value? cc kzantow

          Michael Neale added a comment - IF that is the case, then yes. Although https://github.com/jenkinsci/blueocean-plugin/pull/441 is still pending, I am not sure of relationship. It doesn't seem to use that same expected run number value? cc kzantow

          James Dumay added a comment -

          michaelneale I believe imeredith updated the run modal to accept either a runId or a itemId - so whichever id can be used?

          James Dumay added a comment - michaelneale I believe imeredith updated the run modal to accept either a runId or a itemId - so whichever id can be used?

          Cliff Meyers added a comment -

          WIP PR is here: https://github.com/jenkinsci/blueocean-plugin/pull/466

          I'm going to put this ticket back to "Open" for now since the changes won't be small and I don't want to destabilize anything for JW. jamesdumay and michaelneale if you think it should land before then let me know ASAP and I will see if I can get a PR ready sometime tomorrow.

          Cliff Meyers added a comment - WIP PR is here: https://github.com/jenkinsci/blueocean-plugin/pull/466 I'm going to put this ticket back to "Open" for now since the changes won't be small and I don't want to destabilize anything for JW. jamesdumay and michaelneale if you think it should land before then let me know ASAP and I will see if I can get a PR ready sometime tomorrow.

          James Dumay added a comment -

          cliffmeyers lets punt this over to the next sprint then

          James Dumay added a comment - cliffmeyers lets punt this over to the next sprint then

          Cliff Meyers added a comment -

          PR: https://github.com/jenkinsci/blueocean-plugin/pull/515

          Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/515

            cliffmeyers Cliff Meyers
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: