Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37523

New Item page shows "field cannot be empty" error when attempting to create a duplicate item

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      What incorrect behavior happened?

      When creating a new item, if a duplicate exists, the "duplicate name" text is immediately overriden by "invalid name" error text. This is especially problematic if a user is creating a new item further in the list. In that scenario, the user effectively receives the wrong warning message.

      I've attached some screenshots of the state of the Jenkins under test.

      What was the expected outcome?

      The expected behavior is that the "duplicate name" error text should persist so that the user understands why their input is incorrect.

      Step by step to reproduce it

      1. Create freestyle Job with name "asdf"
      2. Create second freestyle job with "asdf"
      3. Note that the error text for "duplicate name" is appears when mouseclickdown but overridden when the mouseclickup

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Keith Zantow
            Path:
            war/src/main/js/add-item.js
            http://jenkins-ci.org/commit/jenkins/740fef2978d491ac6e3ab752bc70871fdd56546f
            Log:
            JENKINS-37523 - wrong message for duplicate item name during create (#2513)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Keith Zantow Path: war/src/main/js/add-item.js http://jenkins-ci.org/commit/jenkins/740fef2978d491ac6e3ab752bc70871fdd56546f Log: JENKINS-37523 - wrong message for duplicate item name during create (#2513)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: kzantow
            Path:
            src/main/java/org/jenkinsci/test/acceptance/po/JobsMixIn.java
            src/test/java/core/CreateItemTest.java
            http://jenkins-ci.org/commit/acceptance-test-harness/fc1c99575bd215a0a1fcbf7f06ebcfa00fb30ec9
            Log:
            JENKINS-37523 - wrong message displayed for duplicate item name

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kzantow Path: src/main/java/org/jenkinsci/test/acceptance/po/JobsMixIn.java src/test/java/core/CreateItemTest.java http://jenkins-ci.org/commit/acceptance-test-harness/fc1c99575bd215a0a1fcbf7f06ebcfa00fb30ec9 Log: JENKINS-37523 - wrong message displayed for duplicate item name
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            src/main/java/org/jenkinsci/test/acceptance/po/JobsMixIn.java
            src/test/java/core/CreateItemTest.java
            http://jenkins-ci.org/commit/acceptance-test-harness/b77caa669998e449cdd44794030be3fcc1a9ca4b
            Log:
            Merge pull request #175 from kzantow/master

            JENKINS-37523 - wrong message displayed for duplicate item name

            Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/27343783ba00...b77caa669998

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/test/acceptance/po/JobsMixIn.java src/test/java/core/CreateItemTest.java http://jenkins-ci.org/commit/acceptance-test-harness/b77caa669998e449cdd44794030be3fcc1a9ca4b Log: Merge pull request #175 from kzantow/master JENKINS-37523 - wrong message displayed for duplicate item name Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/27343783ba00...b77caa669998

              People

              Assignee:
              kzantow Keith Zantow
              Reporter:
              recampbell Ryan Campbell
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: