Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37565

Update supported Java version to Java7

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: remoting
    • Labels:
      None
    • Similar Issues:
    • Epic Link:

      Description

      Remoting layer could benefit from bumping to Java7 due to its better resource handling and File API methods. Jenkins does not support Java 6 starting from 1.625 (>1 year ago), hence Java 6 is not required anymore

        Attachments

          Issue Links

          is related to

          Task - A task that needs to be done. JENKINS-37566 FindBugs-clean remoting layer

          • Major - Major loss of function.
          • Resolved

            Activity

            Ascending order - Click to sort in descending order
            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Epic Link JENKINS-37564 [ 173676 ]
            oleg_nenashev Oleg Nenashev made changes -
            Assignee Oleg Nenashev [ oleg_nenashev ]
            oleg_nenashev Oleg Nenashev made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            markewaite Mark Waite made changes -
            Description Remoting layer could benefit from bumping to Java7 due to its better resource handling and File API methods. Jenkins does not support Java 6 starting from 1.609.x (>1 year ago), hence Java 6 is not required anymore Remoting layer could benefit from bumping to Java7 due to its better resource handling and File API methods. Jenkins does not support Java 6 starting from 1.625 (>1 year ago), hence Java 6 is not required anymore
            Hide
            Permalink
            oleg_nenashev Oleg Nenashev added a comment -

            Thanks Mark Waite for the version fix. Yes, Java6 is dropped in 1.625. BTW, Java update is still reasonable

            Show
            oleg_nenashev Oleg Nenashev added a comment - Thanks Mark Waite for the version fix. Yes, Java6 is dropped in 1.625. BTW, Java update is still reasonable
            Hide
            Permalink
            markewaite Mark Waite added a comment -

            Oleg Nenashev I agree wholeheartedly. The "try with resources" additions of JDK 7 have been a great help to reduce the amount of code in the git client plugin 2.0 release, and those same additions give me more confidence that the battle against resource leaks might be a "winnable battle".

            Show
            markewaite Mark Waite added a comment - Oleg Nenashev I agree wholeheartedly. The "try with resources" additions of JDK 7 have been a great help to reduce the amount of code in the git client plugin 2.0 release, and those same additions give me more confidence that the battle against resource leaks might be a "winnable battle".
            Hide
            Permalink
            oleg_nenashev Oleg Nenashev added a comment -

            And also Files class with normal file operations, which do not require the return value check...
            There is a bunch of such errors in remoting - JENKINS-37566

            Show
            oleg_nenashev Oleg Nenashev added a comment - And also Files class with normal file operations, which do not require the return value check... There is a bunch of such errors in remoting - JENKINS-37566
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is related to JENKINS-37566 [ JENKINS-37566 ]
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/pom/8334beddd7464851b4a3c18cec8f525430fbf418
            Log:
            Merge pull request #11 from oleg-nenashev/pom-update

            JENKINS-37565 Allow specifying custom java.level

            Compare: https://github.com/jenkinsci/pom/compare/9a115ced6df7...8334beddd746

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/pom/8334beddd7464851b4a3c18cec8f525430fbf418 Log: Merge pull request #11 from oleg-nenashev/pom-update JENKINS-37565 Allow specifying custom java.level Compare: https://github.com/jenkinsci/pom/compare/9a115ced6df7...8334beddd746
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/remoting/94e90bbdf656d9b2695aa27282d5ad86deda342e
            Log:
            JENKINS-37565 - Upgrade source level to Java 7 in remoting 3 (#103)

            This change does not update the code to the Java7 style, but we will do it later

            • Pick the 1.37 release
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/remoting/94e90bbdf656d9b2695aa27282d5ad86deda342e Log: JENKINS-37565 - Upgrade source level to Java 7 in remoting 3 (#103) JENKINS-37565 - Upgrade source level to Java 7 This change does not update the code to the Java7 style, but we will do it later Pick the 1.37 release
            oleg_nenashev Oleg Nenashev made changes -
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Resolved [ 5 ]
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/remoting/9828cd66ddf70b5f5fc3ac5a91de7ee8c96b90bc
            Log:
            JENKINS-37565 - Really allow compiling with Java 7

            Just a leftover fix

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/remoting/9828cd66ddf70b5f5fc3ac5a91de7ee8c96b90bc Log: JENKINS-37565 - Really allow compiling with Java 7 Just a leftover fix
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            pom.xml
            http://jenkins-ci.org/commit/remoting/f0f10b0d9319ec201c085a9f4b35c2014befec9f
            Log:
            JENKINS-37565 - Really allow compiling with Java 7 (#108)

            Just a leftover fix

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/remoting/f0f10b0d9319ec201c085a9f4b35c2014befec9f Log: JENKINS-37565 - Really allow compiling with Java 7 (#108) Just a leftover fix
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Stephen Connolly
            Path:
            core/src/main/java/jenkins/slaves/DefaultJnlpSlaveReceiver.java
            core/src/main/java/jenkins/slaves/IOHubProvider.java
            core/src/main/java/jenkins/slaves/JnlpAgentReceiver.java
            core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol.java
            core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol2.java
            core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol3.java
            core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol4.java
            core/src/main/java/jenkins/slaves/JnlpSlaveHandshake.java
            core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.jelly
            core/src/main/resources/jenkins/slaves/Messages.properties
            core/src/test/java/jenkins/slaves/DefaultJnlpSlaveReceiverTest.java
            pom.xml
            http://jenkins-ci.org/commit/jenkins/71cbe0cc7c601c04509faa618b23194335288fee
            Log:
            [JENKINS-36871, JENKINS-37565] JNLP4-connect implementation and Remoting 3 (#2492)

            • JENKINS-36871 Switch to the new JnlpProtocolHandler based implementation

            Todo

            • [ ] Restore the cookie behaviour (but done right this time)
            • [ ] Perhaps investigate issuing clients with TLS certificates (but would require a UI for managing them)
            • JENKINS-36871 Oleg wants to log an exception that cannot happen
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/jenkins/slaves/DefaultJnlpSlaveReceiver.java core/src/main/java/jenkins/slaves/IOHubProvider.java core/src/main/java/jenkins/slaves/JnlpAgentReceiver.java core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol.java core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol2.java core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol3.java core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol4.java core/src/main/java/jenkins/slaves/JnlpSlaveHandshake.java core/src/main/resources/jenkins/slaves/JnlpSlaveAgentProtocol4/description.jelly core/src/main/resources/jenkins/slaves/Messages.properties core/src/test/java/jenkins/slaves/DefaultJnlpSlaveReceiverTest.java pom.xml http://jenkins-ci.org/commit/jenkins/71cbe0cc7c601c04509faa618b23194335288fee Log: [JENKINS-36871, JENKINS-37565] JNLP4-connect implementation and Remoting 3 (#2492) JENKINS-36871 Switch to the new JnlpProtocolHandler based implementation Todo [ ] Restore the cookie behaviour (but done right this time) [ ] Perhaps investigate issuing clients with TLS certificates (but would require a UI for managing them) JENKINS-36871 License headers and javadocs JENKINS-36871 Restore cookie handling JENKINS-36871 Integrating Agent discovery components JENKINS-36871 Pick up remoting 3.0-SNAPSHOT JENKINS-36871 Pick up newer snapshot JENKINS-36871 Oleg wants to log an exception that cannot happen
            oleg_nenashev Oleg Nenashev made changes -
            Labels lts-candidate
            oleg_nenashev Oleg Nenashev made changes -
            Labels lts-candidate
            Hide
            Permalink
            oleg_nenashev Oleg Nenashev added a comment -

            Released in Jenkins 2.27

            Show
            oleg_nenashev Oleg Nenashev added a comment - Released in Jenkins 2.27

              People

              Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: