Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37684

Support HTTP proxy

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      It seems that the plugin doesn't support http proxy configuration, so all stuff related to that is ignored.

      https://github.com/jenkinsci/aws-lambda-plugin/blob/master/src/main/java/com/xti/jenkins/plugin/awslambda/util/LambdaClientConfig.java#L29

        Attachments

          Issue Links

            Activity

            Hide
            cast Michael Willemse added a comment - - edited

            After looking into it changes will only be required in
            https://github.com/XT-i/aws-lambda-jenkins-plugin/blob/master/src/main/java/com/xti/jenkins/plugin/awslambda/util/LambdaClientConfig.java

            Because the actual host used is not publicly exposed in the AWS java sdk (or at least I haven't found it exposed publicly) I will use the Jenkins.getInstance().proxy configuration without using createProxy defined with a host.

            Since the aws java sdk also supports the noproxyhosts config I will pass it along when constructing the AWSLambdaClient.

            Show
            cast Michael Willemse added a comment - - edited After looking into it changes will only be required in https://github.com/XT-i/aws-lambda-jenkins-plugin/blob/master/src/main/java/com/xti/jenkins/plugin/awslambda/util/LambdaClientConfig.java Because the actual host used is not publicly exposed in the AWS java sdk (or at least I haven't found it exposed publicly) I will use the Jenkins.getInstance().proxy configuration without using createProxy defined with a host. Since the aws java sdk also supports the noproxyhosts config I will pass it along when constructing the AWSLambdaClient.
            Hide
            escoem Emilio Escobar added a comment -

            hello Michael Willemse, I'm going to send the PR with exactly those changes in seconds. Anyway feel free to discard/close if you prefer.

            Show
            escoem Emilio Escobar added a comment - hello Michael Willemse , I'm going to send the PR with exactly those changes in seconds. Anyway feel free to discard/close if you prefer.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Emilio Escobar
            Path:
            src/main/java/com/xti/jenkins/plugin/awslambda/util/LambdaClientConfig.java
            http://jenkins-ci.org/commit/aws-lambda-plugin/834e0118e1a3b79b903e86449011f603f5e2cd27
            Log:
            JENKINS-37684 proxy configuration is supported

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Emilio Escobar Path: src/main/java/com/xti/jenkins/plugin/awslambda/util/LambdaClientConfig.java http://jenkins-ci.org/commit/aws-lambda-plugin/834e0118e1a3b79b903e86449011f603f5e2cd27 Log: JENKINS-37684 proxy configuration is supported
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Michael Willemse
            Path:
            src/main/java/com/xti/jenkins/plugin/awslambda/util/LambdaClientConfig.java
            http://jenkins-ci.org/commit/aws-lambda-plugin/ab1c2dc5974474c286e7aa871218847f16c5717c
            Log:
            Merge pull request #9 from escoem/JENKINS-37684

            JENKINS-37684 proxy configuration is supported

            Compare: https://github.com/jenkinsci/aws-lambda-plugin/compare/3beda0693179...ab1c2dc59744

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Willemse Path: src/main/java/com/xti/jenkins/plugin/awslambda/util/LambdaClientConfig.java http://jenkins-ci.org/commit/aws-lambda-plugin/ab1c2dc5974474c286e7aa871218847f16c5717c Log: Merge pull request #9 from escoem/ JENKINS-37684 JENKINS-37684 proxy configuration is supported Compare: https://github.com/jenkinsci/aws-lambda-plugin/compare/3beda0693179...ab1c2dc59744
            Hide
            cast Michael Willemse added a comment -

            Feature added with noproxyhost support in release 0.5.5

            Show
            cast Michael Willemse added a comment - Feature added with noproxyhost support in release 0.5.5
            Hide
            escoem Emilio Escobar added a comment -
            Show
            escoem Emilio Escobar added a comment - Thanks Michael Willemse
            Hide
            cast Michael Willemse added a comment -

            Thanks for the PR Emilio Escobar

            Show
            cast Michael Willemse added a comment - Thanks for the PR Emilio Escobar

              People

              Assignee:
              cast Michael Willemse
              Reporter:
              escoem Emilio Escobar
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: