• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • core

      Under some conditions (that I'm failing to diagnose) Converter.canConvert(Class type) is being called with null as argument on a converter which is not NullConverter, those calls lead to {{NullPointerException}}s.

          [JENKINS-37757] NPE on XStream serialization

          Daniel Beck added a comment -

          Do you at least have stack traces?

          Daniel Beck added a comment - Do you at least have stack traces?

          Yes:

          java.lang.NullPointerException
            at java.lang.Class.isAssignableFrom(Native Method)
            at com.thoughtworks.xstream.converters.reflection.ExternalizableConverter.canConvert(ExternalizableConverter.java:73)
            at com.thoughtworks.xstream.core.DefaultConverterLookup.registerConverter(DefaultConverterLookup.java:74)
            at com.thoughtworks.xstream.XStream$2.registerConverter(XStream.java:502)
            ...
          

          This is after a XStream constructor call, in one of the registerConverter call in the construction chain.

          Antonio Muñiz added a comment - Yes: java.lang.NullPointerException at java.lang.Class.isAssignableFrom(Native Method) at com.thoughtworks.xstream.converters.reflection.ExternalizableConverter.canConvert(ExternalizableConverter.java:73) at com.thoughtworks.xstream.core.DefaultConverterLookup.registerConverter(DefaultConverterLookup.java:74) at com.thoughtworks.xstream.XStream$2.registerConverter(XStream.java:502) ... This is after a XStream constructor call, in one of the registerConverter call in the construction chain.

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          xstream/src/java/com/thoughtworks/xstream/core/DefaultConverterLookup.java
          http://jenkins-ci.org/commit/xstream/8b101d44c69a1fc46d8020930502e22544ffbc2a
          Log:
          Merge pull request #5 from amuniz/fix-npe

          JENKINS-37757 Protection against NullPointerException

          Compare: https://github.com/jenkinsci/xstream/compare/d3a5bd430863...8b101d44c69a

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: xstream/src/java/com/thoughtworks/xstream/core/DefaultConverterLookup.java http://jenkins-ci.org/commit/xstream/8b101d44c69a1fc46d8020930502e22544ffbc2a Log: Merge pull request #5 from amuniz/fix-npe JENKINS-37757 Protection against NullPointerException Compare: https://github.com/jenkinsci/xstream/compare/d3a5bd430863...8b101d44c69a

          Oleg Nenashev added a comment -

          amuniz any plans to get the fix released?

          Oleg Nenashev added a comment - amuniz any plans to get the fix released?

            amuniz Antonio Muñiz
            amuniz Antonio Muñiz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: