Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37954

Running job has incorrect stage selected before steps start executing

    XMLWordPrintable

Details

    • 1.0-beta-1

    Description

      Problem

      Opening a pipeline that is RUNNING but has no steps shows the final stage incorrectly selected

      • I believe this occurs when there are not any flow nodes available but the Pipeline is running.
      • The last stage is selected and it says there are no steps.
      • When we get flow nodes it switches to the executing stage.

      What should happen

      • The user should see the screen below.
      • The first step is always selected and the empty state says that it is "waiting for the run to start".
      • This is based on the simple rule of "no steps + running".

      Attachments

        Activity

          jamesdumay how important is that you see the steps? The steps are based on the last successful run of a pipeline. In theory we do not know the steps until we are processing them.

          Current solution is simply not showing the steps when the job is queued. I would need to look into "tricking" the pipelineGraph to show the first node selected, but IMO the suggested implementation is cleaner. ....but your call

          tscherler Thorsten Scherler added a comment - jamesdumay how important is that you see the steps? The steps are based on the last successful run of a pipeline. In theory we do not know the steps until we are processing them. Current solution is simply not showing the steps when the job is queued. I would need to look into "tricking" the pipelineGraph to show the first node selected, but IMO the suggested implementation is cleaner. ....but your call

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          src/test/js/queued.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/bf9a61d827674e1aeb9d56930941b94e96543931
          Log:
          JENKINS-37954 better selector for the queued empty state

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/queued.js http://jenkins-ci.org/commit/blueocean-acceptance-test/bf9a61d827674e1aeb9d56930941b94e96543931 Log: JENKINS-37954 better selector for the queued empty state
          michaelneale Michael Neale added a comment -

          ideally the graph still showed, and yes, "tricking" it is fine (or even not selecting nodes). This was included as part of the design as it sets up expectation for the user of how much work the pipeline has to do (same as stage view does in classic) and is a much wanted feature, so that needs to be in there.

          michaelneale Michael Neale added a comment - ideally the graph still showed, and yes, "tricking" it is fine (or even not selecting nodes). This was included as part of the design as it sets up expectation for the user of how much work the pipeline has to do (same as stage view does in classic) and is a much wanted feature, so that needs to be in there.

          michaelneale consider it done

          tscherler Thorsten Scherler added a comment - michaelneale consider it done

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          README.md
          package.json
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          src/test/js/failing.js
          src/test/js/log-karaoke/stages.js
          src/test/resources/test_scripts/noStagesFailing.groovy
          http://jenkins-ci.org/commit/blueocean-acceptance-test/5e890e4df6cf836b50b55bd0efe433945968c39e
          Log:
          Merge remote-tracking branch 'origin/master' into JENKINS-37954

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: README.md package.json src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/failing.js src/test/js/log-karaoke/stages.js src/test/resources/test_scripts/noStagesFailing.groovy http://jenkins-ci.org/commit/blueocean-acceptance-test/5e890e4df6cf836b50b55bd0efe433945968c39e Log: Merge remote-tracking branch 'origin/master' into JENKINS-37954

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          src/test/js/queued.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/8b9894fd3bcc61f603f44314bd6b3497c659fa15
          Log:
          JENKINS-37954 fix the validation of the graph since on the first ru we do not have any information yet

          Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/bf9a61d82767...8b9894fd3bcc

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: src/test/js/queued.js http://jenkins-ci.org/commit/blueocean-acceptance-test/8b9894fd3bcc61f603f44314bd6b3497c659fa15 Log: JENKINS-37954 fix the validation of the graph since on the first ru we do not have any information yet Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/bf9a61d82767...8b9894fd3bcc

          Code changed in jenkins
          User: Thorsten Scherler
          Path:
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          src/test/js/queued.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/0c12cc0ebb958d5d5a7c56fadf36df0c61ad9b51
          Log:
          [FIX JENKINS-37954] better selector for the queued empty state (#33)

          • eslint - formating changes and fix offences
          • JENKINS-37954 fix the validation of the graph since on the first ru we do not have any information yet
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thorsten Scherler Path: src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/queued.js http://jenkins-ci.org/commit/blueocean-acceptance-test/0c12cc0ebb958d5d5a7c56fadf36df0c61ad9b51 Log: [FIX JENKINS-37954] better selector for the queued empty state (#33) JENKINS-37954 better selector for the queued empty state eslint - formating changes and fix offences JENKINS-37954 fix the validation of the graph since on the first ru we do not have any information yet

          People

            tscherler Thorsten Scherler
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: