Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38309

Make ForkScanner return Parallel Branches in same order as others

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • workflow-api-plugin
    • None

      When using the ForkScanner to walk through a flow graph, most things are returned in logical reverse order (end --> start, right), but parallels are done in the opposite (first branch, then second).

      The API doesn't guarantee parallel ordering but it is helpful for consumers to have the same guarantee in place for parallels too, since it turns out to be practical.

          [JENKINS-38309] Make ForkScanner return Parallel Branches in same order as others

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sam Van Oort
          Path:
          src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScanner.java
          src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowScannerTest.java
          src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScannerTest.java
          http://jenkins-ci.org/commit/workflow-api-plugin/dcd2152870040fe8dd1ee4fa616542b6bb3329dc
          Log:
          Ensure that parallels in ForkScanner follow the same reverse-order iteration, per JENKINS-38309

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScanner.java src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowScannerTest.java src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScannerTest.java http://jenkins-ci.org/commit/workflow-api-plugin/dcd2152870040fe8dd1ee4fa616542b6bb3329dc Log: Ensure that parallels in ForkScanner follow the same reverse-order iteration, per JENKINS-38309

          Sam Van Oort added a comment -

          Merged, going into next release.

          Sam Van Oort added a comment - Merged, going into next release.

          Sam Van Oort added a comment -

          Released as v2.4

          Sam Van Oort added a comment - Released as v2.4

            svanoort Sam Van Oort
            svanoort Sam Van Oort
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: